Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Refactors agnhost image pod usage in tests #94438

Merged
merged 1 commit into from Sep 23, 2020
Merged

tests: Refactors agnhost image pod usage in tests #94438

merged 1 commit into from Sep 23, 2020

Conversation

claudiubelu
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

A previous commit added a few agnhost related functions that creates agnhost pods / containers for general purposes.

Refactors tests to use those functions.

Which issue(s) this PR fixes:

Fixes #
Depends On: #87266

Special notes for your reviewer:

/cc @alejandrox1

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 2, 2020
@fejta-bot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 2, 2020
oomichi
oomichi reviewed Sep 2, 2020
View reviewed changes
Copy link
Member

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good cleanup for me, just few comments.

/cc @oomichi

test/e2e/framework/pod/resource.go Outdated
{
Name: "agnhost-pause",
Image: imageutils.GetE2EImage(imageutils.Agnhost),
Args: []string{"pause"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to pass this "pause" as args of NewAgnhostPod()?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above, if no argument is given for args..., NetAgnhostContainer will consider this to be the default.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I got it.
Thanks for your explanation.

/lgtm

test/e2e/network/service.go
{
Name: "pause",
Image: imageutils.GetE2EImage(imageutils.Agnhost),
Args: []string{"pause"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

test/e2e/node/pods.go
{
Name: "agnhost",
Image: imageutils.GetE2EImage(imageutils.Agnhost),
Args: []string{"pause"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2020
@fedebongio
Copy link
Contributor

/assign @yliaog

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 7, 2020
@claudiubelu
Copy link
Contributor Author

/test pull-kubernetes-bazel-test

@claudiubelu claudiubelu force-pushed the tests/agnhost-usage-refactor-4 branch 2 times, most recently from 09be786 to 613aee8 Compare September 8, 2020 14:11
@oomichi
Copy link
Member

oomichi commented Sep 8, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2020
@marosset marosset added this to In Review (v1.20) in SIG-Windows Sep 10, 2020
@claudiubelu
tests: Refactors agnhost image pod usage in tests
89eae73 
A previous commit created a few agnhost related functions that creates agnhost
pods / containers for general purposes.

Refactors tests to use those functions.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2020
alejandrox1
alejandrox1 reviewed Sep 23, 2020
View reviewed changes
Copy link
Contributor

@alejandrox1 alejandrox1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/priority backlog

Thank you @claudiubelu !

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 23, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alejandrox1, claudiubelu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit aad834b into kubernetes:master Sep 23, 2020
SIG-Windows automation moved this from In Review (v1.20) to Done (v1.20) Sep 23, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 23, 2020
@kvaradhan3 kvaradhan3 mentioned this pull request Sep 24, 2020
Closed
This was referenced Feb 13, 2021
Closed
Closed
Closed
Merged
k8s-ci-robot added a commit that referenced this pull request Feb 19, 2021
@k8s-ci-robot
Merge pull request #99220 from jingxu97/automated-cherry-pick-of-#87266-
f6ec471 
#93196-#94438-#94653-#95229-#95867-#96294-#96330-#96479-#96626-#96644-#96690-#96843-upstream-release-1.19

Automated cherry pick of 87266  93196 94438 94653 95229 95867 96294 96330 96479 96626 96644 96690 96843
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandrox1 alejandrox1 alejandrox1 left review comments

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@oomichi oomichi

@alejandrox1 alejandrox1

@yliaog yliaog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@claudiubelu @fejta-bot @fedebongio @oomichi @k8s-ci-robot @alejandrox1 @yliaog