New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing issue where SMB share paths cannot resolve with CRI-containerD on Windows #96396
fixing issue where SMB share paths cannot resolve with CRI-containerD on Windows #96396
Conversation
/sig windows |
/test pull-kubernetes-e2e-aks-engine-azure-windows |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingxu97, marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
/priority important-soon |
/hold cancel I tested these changes with a private kubelet running on nodes configured with both docker and containerd. |
@marosset should we cherry-pick this PR to old releases? what's the minimum supported k8s version for containerd on Windows? |
@andyzhangx I was planning on backporting this to v1.19 this week. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Partially Fixes #94213
Special notes for your reviewer:
Here is the equivalent PR that went into csi-proxy: kubernetes-csi/csi-proxy#98
As mentioned in the comments the underlying issue here is the behavior of the EvalSymlinks call in golang on Windows.
This change is intended as a work-around until a version of containerD for Windows is built with a versin of golang containing the fix (golang/go#42096)
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: