Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OWNERS: Update SIG Release aliases #97700

Merged
merged 7 commits into from Jan 25, 2021
Merged

OWNERS: Update SIG Release aliases #97700

merged 7 commits into from Jan 25, 2021

Conversation

hasheddan
Copy link
Contributor

@hasheddan hasheddan commented Jan 5, 2021 •
edited by justaugustus

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

(Edits from @justaugustus...)

Updates SIG Release OWNERS aliases to:

  • Remove SIG Release approvers alias
    We're currently only using this for changelog approvals and those should
    really be handled by relnotes + RelEng.
  • Syncs release-engineering-* with full Release Managers (https://github.com/kubernetes/sig-release/blob/master/release-managers.md#release-managers)
  • Add Release Managers as build image reviewers
  • Add CHANGELOG aliases
  • Adds @wilsonehusin as CHANGELOG reviewer / approver for 1.21 cycle
  • Add Release Managers as changelog approvers
  • Add 1.21 Release Notes shadows as changelog reviewers

Includes:

Which issue(s) this PR fixes:

xref kubernetes/sig-release#1322

Special notes for your reviewer:

/assign @justaugustus @saschagrunert
/hold
/sig release
/area release-engineering
cc: @kubernetes/release-engineering

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. labels Jan 5, 2021
@k8s-ci-robot
Copy link
Contributor

@hasheddan: The label(s) area/release-engineering cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates SIG Release Owners Aliases to reflect:

Which issue(s) this PR fixes:

xref kubernetes/sig-release#1322

Special notes for your reviewer:

/assign @justaugustus @saschagrunert
/hold
/sig release
/area release-engineering

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/release Categorizes an issue or PR as relevant to SIG Release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 5, 2021
@hasheddan hasheddan mentioned this pull request Jan 5, 2021
Closed
23 tasks
@hasheddan
Copy link
Contributor Author

/area release-eng

@k8s-ci-robot k8s-ci-robot added the area/release-eng Issues or PRs related to the Release Engineering subproject label Jan 5, 2021
@justaugustus justaugustus added this to In progress in SIG Release via automation Jan 8, 2021
saschagrunert
saschagrunert approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2021
justaugustus
justaugustus requested changes Jan 13, 2021
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add @jeremyrickard in, as he'll be confirmed as TL by EOD tomorrow.
ref: https://groups.google.com/g/kubernetes-dev/c/78E3IobBKH0

SIG Release automation moved this from In progress to In Review Jan 13, 2021
@justaugustus justaugustus mentioned this pull request Jan 13, 2021
Closed
justaugustus
justaugustus requested changes Jan 13, 2021
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hasheddan -- One more thing...
Can you pull in the changes from #97135?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2021
@hasheddan
Copy link
Contributor Author

@justaugustus I believe this is ready to go now 👍

saschagrunert
saschagrunert approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2021
@hasheddan hasheddan mentioned this pull request Jan 14, 2021
Closed
23 tasks
justaugustus and others added 2 commits January 25, 2021 05:17
@justaugustus
OWNERS(sig-release): Remove SIG Release approvers alias
3877963 
We're currently only using this for changelog approvals and those should
really be handled by relnotes + RelEng.

Signed-off-by: Stephen Augustus <foo@auggie.dev>
@hasheddan @justaugustus
OWNERS(releng): Sync Release Managers
2ba5d99 
Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Co-authored-by: Stephen Augustus <foo@auggie.dev>
@justaugustus
Copy link
Member

@hasheddan -- I tweaked some things and updated the description to reflect.

cc: @kubernetes/sig-release-leads (for review)

For CHANGELOG:
/cc @wilsonehusin

/triage accepted
/hold cancel

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 25, 2021
@justaugustus
Copy link
Member

Also:
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2021
saschagrunert
saschagrunert approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@justaugustus
Copy link
Member

For top-level approve:
/assign @liggitt @thockin @smarterclayton

xmudrii
xmudrii approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

cpanato
cpanato approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@liggitt
Copy link
Member

liggitt commented Jan 25, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, hasheddan, justaugustus, liggitt, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2021
This was referenced Jan 25, 2021
Merged
Merged
Merged
Closed
@k8s-ci-robot k8s-ci-robot merged commit a03264b into kubernetes:master Jan 25, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 25, 2021
@LappleApple LappleApple moved this from In Review to Done/Closed (1.21) in SIG Release Jan 26, 2021
k8s-ci-robot added a commit that referenced this pull request Feb 20, 2021
@k8s-ci-robot
Merge pull request #98370 from hasheddan/automated-cherry-pick-of-#97…
3339512 
…700-upstream-release-1.19

Automated cherry pick of #97700: OWNERS: Update SIG Release aliases
k8s-ci-robot added a commit that referenced this pull request Feb 20, 2021
@k8s-ci-robot
Merge pull request #98371 from hasheddan/automated-cherry-pick-of-#97…
2535543 
…700-upstream-release-1.18

Automated cherry pick of #97700: OWNERS: Update SIG Release aliases
k8s-ci-robot added a commit that referenced this pull request Feb 21, 2021
@k8s-ci-robot
Merge pull request #98369 from hasheddan/automated-cherry-pick-of-#97…
165e566 
…700-upstream-release-1.20

Automated cherry pick of #97700: OWNERS: Update SIG Release aliases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus requested changes

@saschagrunert saschagrunert saschagrunert approved these changes

@cpanato cpanato cpanato approved these changes

@xmudrii xmudrii xmudrii approved these changes

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@thockin thockin Awaiting requested review from thockin

@wilsonehusin wilsonehusin Awaiting requested review from wilsonehusin

Assignees

@justaugustus justaugustus

@saschagrunert saschagrunert

@liggitt liggitt

@smarterclayton smarterclayton

@cpanato cpanato

@thockin thockin

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
No open projects
SIG Release
  
Done/Closed
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@hasheddan @k8s-ci-robot @justaugustus @liggitt @saschagrunert @cpanato @xmudrii @smarterclayton @thockin