Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CRIContainerLogRotation to GA #99651

Merged
merged 1 commit into from Mar 8, 2021
Merged

Move CRIContainerLogRotation to GA #99651

merged 1 commit into from Mar 8, 2021

Conversation

umohnani8
Copy link
Contributor

Signed-off-by: Urvashi Mohnani umohnani@redhat.com

What type of PR is this?

/kind feature

What this PR does / why we need it:

Graduate the CRIContainerLogRotation feature gate
from beta to GA.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Graduate CRIContainerLogRotation feature gate to GA.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2411-cri-container-log-rotation

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 2, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @umohnani8. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 2, 2021
@umohnani8
Copy link
Contributor Author

@mrunalp @ehashman @derekwaynecarr PTAL

@umohnani8 umohnani8 mentioned this pull request Mar 2, 2021
Closed
4 tasks
@reylejano reylejano mentioned this pull request Mar 2, 2021
Merged
@troy0820
Copy link
Member

troy0820 commented Mar 2, 2021

/sig node
/priority important-soon important-longterm

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 2, 2021
@troy0820 troy0820 added this to Triage in SIG Node PR Triage Mar 2, 2021
ehashman
ehashman reviewed Mar 2, 2021
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/remove-priority important-longterm
/ok-to-test
/triage accepted

pkg/features/kube_features.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 2, 2021
@ehashman ehashman moved this from Triage to Waiting on Author in SIG Node PR Triage Mar 2, 2021
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 3, 2021
@kikisdeliveryservice kikisdeliveryservice moved this from Waiting on Author to Needs Reviewer in SIG Node PR Triage Mar 3, 2021
kikisdeliveryservice
kikisdeliveryservice reviewed Mar 3, 2021
View reviewed changes
Copy link
Member

@kikisdeliveryservice kikisdeliveryservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double checked and those are the only two occurances of CRIContainerLogRotation

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2021
@kikisdeliveryservice kikisdeliveryservice moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Mar 3, 2021
@umohnani8
Move CRIContainerLogRotation to GA
ca99aa5 
Graduate the CRIContainerLogRotation feature gate
from beta to GA.

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2021
@mrunalp
Copy link
Contributor

mrunalp commented Mar 4, 2021

/test pull-kubernetes-e2e-kind

troy0820
troy0820 reviewed Mar 4, 2021
View reviewed changes
Copy link
Member

@troy0820 troy0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2021
@mrunalp
Copy link
Contributor

mrunalp commented Mar 4, 2021

Will wait a bit to see if we get any feedback here - https://groups.google.com/g/kubernetes-sig-node/c/SM1GZ31wNyY

@mrunalp
Copy link
Contributor

mrunalp commented Mar 8, 2021

/approve

@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Mar 8, 2021
@mrunalp
Copy link
Contributor

mrunalp commented Mar 8, 2021

/assign @derekwaynecarr

@dims
Copy link
Member

dims commented Mar 8, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, mrunalp, umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit eb4dafb into kubernetes:master Mar 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 8, 2021
@troy0820 troy0820 mentioned this pull request Mar 15, 2021
Closed
13 tasks
@carlory carlory mentioned this pull request Apr 28, 2021
Merged
@troy0820 troy0820 mentioned this pull request Dec 20, 2021
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehashman ehashman ehashman left review comments

@troy0820 troy0820 troy0820 left review comments

@kikisdeliveryservice kikisdeliveryservice kikisdeliveryservice left review comments

@adisky adisky adisky left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@troy0820 troy0820

@kikisdeliveryservice kikisdeliveryservice

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Triage
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Done
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@umohnani8 @k8s-ci-robot @troy0820 @mrunalp @dims @ehashman @kikisdeliveryservice @adisky @derekwaynecarr