cpuset parsing:Fix more edge cases and add more unit tests #100565

lack · 2021-03-25T19:13:59Z

What type of PR is this?

/kind bug

What this PR does / why we need it:

The cpuset.Parse function missed a couple bad input cases, specifically 1--3 and 10-6. These were silently ignored when they should instead be flagged as invalid.

This now catches these cases and expands the unit tests for cpuset to cover them (and other negative test cases as well).

Parsing of cpuset information now properly detects more invalid input such as "1--3" or "10-6"

k8s-ci-robot · 2021-03-25T19:14:03Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2021-03-25T19:14:07Z

Welcome @lack!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2021-03-25T19:14:08Z

Hi @lack. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mrunalp · 2021-03-25T19:21:38Z

@rphillips @haircommander ptal

pkg/kubelet/cm/cpuset/cpuset.go

odinuge

/ok-to-test

pkg/kubelet/cm/cpuset/cpuset.go

odinuge · 2021-03-26T17:40:38Z

pkg/kubelet/cm/cpuset/cpuset_test.go

+		// Non-numeric entries
+		"nonnumeric", "non-numeric", "no,numbers", "0-a", "a-0", "0,a", "a,0", "1-2,a,3-5",
+		// Incomplete sequences
+		"0,", "0,,", ",3", ",,3", "0,,3",


nit: these are all supported by the kernel, since it just ignores extra commas. Not sure if we should care tho.

This cpuset format is consumed by others too, like kubelet and cri-o, so perhaps it's worth being more picky.

pkg/kubelet/cm/cpuset/cpuset.go

lack · 2021-03-28T02:16:36Z

/retest

ehashman · 2021-04-07T17:56:26Z

/priority important-longterm
/triage accepted

ehashman · 2021-04-21T17:25:55Z

/assign @odinuge

odinuge · 2021-04-22T17:01:17Z

Change looks overall good to me, but I still don't think we should drop support for ranges where the first and last number is the same (eg. 0-0 and 1-1 should be allowed).

The cpuset.Parse function missed a couple bad input cases, specifically "1--3" and "10-6". These were silently ignored when they should instead be flagged as invalid. This now catches these cases and expands the unit tests for cpuset to cover them (and other negative test cases as well). Signed-off-by: Jim Ramsay <jramsay@redhat.com>

lack · 2021-05-11T15:06:30Z

Change looks overall good to me, but I still don't think we should drop support for ranges where the first and last number is the same (eg. 0-0 and 1-1 should be allowed).

Just updated to re-allow these ranges.

lack · 2021-05-11T16:39:58Z

These failures seem unrelated to my change.
/retest

lack · 2021-05-11T19:16:02Z

@odinuge: I think this is ready for review again, if you have a chance!

matthyx · 2021-05-12T05:31:20Z

/uncc

odinuge

/lgtm

lack · 2021-05-12T06:31:39Z

/assign @derekwaynecarr

k8s-ci-robot · 2021-05-17T18:16:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lack, mrunalp, odinuge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/kubelet/cm/cpuset/OWNERS~~ [mrunalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 25, 2021

k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 25, 2021

k8s-ci-robot requested review from krmayankk and matthyx March 25, 2021 19:16

k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 25, 2021

staebler reviewed Mar 25, 2021

View reviewed changes

pkg/kubelet/cm/cpuset/cpuset.go Show resolved Hide resolved

lack force-pushed the cpuset-validation branch from 3579b21 to 7c7ad8a Compare March 25, 2021 20:14

odinuge reviewed Mar 26, 2021

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 26, 2021

odinuge reviewed Mar 26, 2021

View reviewed changes

pkg/kubelet/cm/cpuset/cpuset.go Outdated Show resolved Hide resolved

lack force-pushed the cpuset-validation branch from 7c7ad8a to 34aec38 Compare March 28, 2021 00:56

k8s-ci-robot assigned odinuge Apr 21, 2021

lack force-pushed the cpuset-validation branch from 34aec38 to a21179a Compare May 11, 2021 15:06

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 11, 2021

k8s-ci-robot removed the request for review from matthyx May 12, 2021 05:31

odinuge approved these changes May 12, 2021

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2021

k8s-ci-robot assigned derekwaynecarr May 12, 2021

mrunalp approved these changes May 17, 2021

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2021

k8s-ci-robot merged commit 003dd87 into kubernetes:master May 17, 2021

k8s-ci-robot added this to the v1.22 milestone May 17, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cpuset parsing:Fix more edge cases and add more unit tests #100565

cpuset parsing:Fix more edge cases and add more unit tests #100565

lack commented Mar 25, 2021 •

edited

Loading

k8s-ci-robot commented Mar 25, 2021

k8s-ci-robot commented Mar 25, 2021

k8s-ci-robot commented Mar 25, 2021

mrunalp commented Mar 25, 2021

odinuge left a comment

odinuge Mar 26, 2021

lack Mar 30, 2021

lack commented Mar 28, 2021

ehashman commented Apr 7, 2021

ehashman commented Apr 21, 2021

odinuge commented Apr 22, 2021

lack commented May 11, 2021

lack commented May 11, 2021

lack commented May 11, 2021

matthyx commented May 12, 2021

odinuge left a comment

lack commented May 12, 2021

k8s-ci-robot commented May 17, 2021

cpuset parsing:Fix more edge cases and add more unit tests #100565

cpuset parsing:Fix more edge cases and add more unit tests #100565

Conversation

lack commented Mar 25, 2021 • edited Loading

What type of PR is this?

What this PR does / why we need it:

k8s-ci-robot commented Mar 25, 2021

k8s-ci-robot commented Mar 25, 2021

k8s-ci-robot commented Mar 25, 2021

mrunalp commented Mar 25, 2021

odinuge left a comment

Choose a reason for hiding this comment

odinuge Mar 26, 2021

Choose a reason for hiding this comment

lack Mar 30, 2021

Choose a reason for hiding this comment

lack commented Mar 28, 2021

ehashman commented Apr 7, 2021

ehashman commented Apr 21, 2021

odinuge commented Apr 22, 2021

lack commented May 11, 2021

lack commented May 11, 2021

lack commented May 11, 2021

matthyx commented May 12, 2021

odinuge left a comment

Choose a reason for hiding this comment

lack commented May 12, 2021

k8s-ci-robot commented May 17, 2021

lack commented Mar 25, 2021 •

edited

Loading