Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor master to control plane #103386

Closed

Conversation

gooney152
Copy link

What type of PR is this?

/kind clean up
/wg-naming

What this PR does / why we need it:

refactor "master" to "controlplane"

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot
Copy link
Contributor

@gooney152: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@gooney152: The label(s) kind/clean, kind/up cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind clean up
/wg-naming

What this PR does / why we need it:

refactor "master" to "controlplane"

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 30, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @gooney152. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. labels Jun 30, 2021
@gooney152
Copy link
Author

/test

@k8s-ci-robot
Copy link
Contributor

@gooney152: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gooney152 gooney152 force-pushed the refactor-master-to-control-plane branch from abaffee to dc7f525 Compare June 30, 2021 23:20
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/apiserver area/conformance Issues or PRs related to kubernetes conformance tests area/dependency Issues or PRs related to dependency changes area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubeadm area/kubectl area/kubelet area/provider/gcp Issues or PRs related to gcp provider area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 30, 2021
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 7, 2021
@k8s-ci-robot
Copy link
Contributor

@gooney152: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/kubeadm sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jul 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gooney152
To complete the pull request process, please ask for approval from smarterclayton after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. labels Jul 7, 2021
@gooney152
Copy link
Author

/retest

@gooney152 gooney152 force-pushed the refactor-master-to-control-plane branch from 1dd9948 to 10536b9 Compare July 8, 2021 00:04
@gooney152
Copy link
Author

/retest

@gooney152 gooney152 force-pushed the refactor-master-to-control-plane branch from 7c1da16 to 10536b9 Compare July 8, 2021 00:24
@gooney152
Copy link
Author

/retest

@gooney152 gooney152 force-pushed the refactor-master-to-control-plane branch from 10536b9 to dc7f525 Compare July 8, 2021 00:34
@k8s-ci-robot
Copy link
Contributor

@gooney152: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kind-ipv6 dc7f525 link /test pull-kubernetes-e2e-kind-ipv6
pull-kubernetes-e2e-gce-100-performance dc7f525 link /test pull-kubernetes-e2e-gce-100-performance
pull-kubernetes-verify dc7f525 link /test pull-kubernetes-verify
pull-kubernetes-e2e-kind dc7f525 link /test pull-kubernetes-e2e-kind
pull-kubernetes-conformance-kind-ga-only-parallel dc7f525 link /test pull-kubernetes-conformance-kind-ga-only-parallel
pull-kubernetes-conformance-kind-ipv6-parallel dc7f525 link /test pull-kubernetes-conformance-kind-ipv6-parallel
pull-kubernetes-integration dc7f525 link /test pull-kubernetes-integration
pull-kubernetes-e2e-ubuntu-gce-network-policies dc7f525 link /test pull-kubernetes-e2e-ubuntu-gce-network-policies
pull-kubernetes-e2e-gci-gce-ingress dc7f525 link /test pull-kubernetes-e2e-gci-gce-ingress
pull-kubernetes-node-e2e-containerd dc7f525 link /test pull-kubernetes-node-e2e-containerd
pull-kubernetes-unit dc7f525 link /test pull-kubernetes-unit
pull-kubernetes-e2e-gce-ubuntu-containerd dc7f525 link /test pull-kubernetes-e2e-gce-ubuntu-containerd
pull-kubernetes-e2e-gce-csi-serial dc7f525 link /test pull-kubernetes-e2e-gce-csi-serial
pull-kubernetes-conformance-image-test dc7f525 link /test pull-kubernetes-conformance-image-test
pull-kubernetes-verify-govet-levee dc7f525 link /test pull-kubernetes-verify-govet-levee
pull-kubernetes-typecheck dc7f525 link /test pull-kubernetes-typecheck
pull-kubernetes-dependencies dc7f525 link /test pull-kubernetes-dependencies
pull-kubernetes-files-remake dc7f525 link /test pull-kubernetes-files-remake
pull-kubernetes-e2e-gce-storage-snapshot dc7f525 link /test pull-kubernetes-e2e-gce-storage-snapshot
pull-kubernetes-e2e-gce-storage-slow dc7f525 link /test pull-kubernetes-e2e-gce-storage-slow
check-dependency-stats dc7f525 link /test check-dependency-stats
pull-kubernetes-e2e-gce-alpha-features dc7f525 link /test pull-kubernetes-e2e-gce-alpha-features
pull-kubernetes-local-e2e dc7f525 link /test pull-kubernetes-local-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Archive-it in SIG Node CI/Test Board Jul 8, 2021
@caesarxuchao
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 8, 2021
@neolit123
Copy link
Member

/remove-area kubeadm
/remove-sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot removed area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Jul 10, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 8, 2021
@ritazh
Copy link
Member

ritazh commented Oct 18, 2021

This PR at its current state is too large to review by each individual sigs. Closing this for now. @gooney152 Please separate this change into smaller PRs for each area. Thank you!

/close

@k8s-ci-robot
Copy link
Contributor

@ritazh: Closed this PR.

In response to this:

This PR at its current state is too large to review by each individual sigs. Closing this for now. @gooney152 Please separate this change into smaller PRs for each area. Thank you!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SIG Node PR Triage automation moved this from Waiting on Author to Done Oct 18, 2021
@enj enj removed this from Needs Triage in SIG Auth Old Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/apiserver area/conformance Issues or PRs related to kubernetes conformance tests area/dependency Issues or PRs related to dependency changes area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubectl area/kubelet area/provider/gcp Issues or PRs related to gcp provider area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Development

Successfully merging this pull request may close these issues.

None yet