Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to runc v 1.0.3 #106912

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Update to runc v 1.0.3 #106912

merged 1 commit into from
Jan 19, 2022

Conversation

Letme
Copy link
Contributor

@Letme Letme commented Dec 9, 2021

What type of PR is this?

/kind bug
/kind regression

What this PR does / why we need it:

Current version (1.0.2) of runc prevents Kubernetes from running on RaspberryPi4 with non-hugetlb compiled kernel (standard Raspbian Bullseye). There is a fix inside Runc 1.0.3 for libct/cg/fs2: fix GetStats for unsupported hugetlb (opencontainers/runc#3233), which needs to be delivered to all existing supported Kubernetes versions (I tested v1.21.4 1.21.7 1.22.4 and 1.23.0).

Which issue(s) this PR fixes:

Fixes #

opencontainers/runc#3232

Special notes for your reviewer:

My first contribution, so I am not sure it is this simple.

Does this PR introduce a user-facing change?

Fix libct/cg/fs2: fix GetStats for unsupported hugetlb error on Raspbian Bullseye

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. labels Dec 9, 2021
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 9, 2021

CLA Signed

The committers are authorized under a signed CLA.

  • ✅ Crt Mori (24b5bf2b80cc78e93d0da78004f9a0f6ccc7595c)

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 9, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @Letme!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @Letme. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/dependency Issues or PRs related to dependency changes labels Dec 9, 2021
@Letme
Copy link
Contributor Author

Letme commented Dec 9, 2021

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 9, 2021
@pacoxu
Copy link
Member

pacoxu commented Dec 10, 2021

/sig node
/ok-to-test

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 10, 2021
@pacoxu
Copy link
Member

pacoxu commented Dec 10, 2021

You should run hack/lint-dependencies.sh to check dependencies before update.

To pin dependency version, you should try something like below.

hack/pin-dependency.sh github.com/opencontainers/runc v1.0.3
hack/update-vendor.sh

@pacoxu
Copy link
Member

pacoxu commented Dec 10, 2021

I did a quick example like https://github.com/kubernetes/kubernetes/compare/master...pacoxu:runc-v1.0.3?expand=1 that you can follow.

@Letme
Copy link
Contributor Author

Letme commented Dec 10, 2021

Thanks for the commands - I indeed did it by hand initially. So now with your commands I have cb7ff96e08c and I also ran the lint-dependencies as suggested and that also passed.

@ehashman
Copy link
Member

/priority important-longterm
/triage accepted
/assign @kolyshkin

@Letme Letme requested a review from kolyshkin December 21, 2021 19:12
@Letme
Copy link
Contributor Author

Letme commented Dec 27, 2021

/ping on this... I would love to get it into update, so that I can get more nodes running.

@dims
Copy link
Member

dims commented Jan 7, 2022

@SergeyKanzhelev did you get a chance to peek?

@SergeyKanzhelev
Copy link
Member

Reviewed the release notes, looks good for master. I'm not sure about the cherry-picks though.

/lgtm
/assign @mrunalp

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2022
@SergeyKanzhelev
Copy link
Member

/kind regression

@Letme do you know what version the issue was introduced in?

Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Letme
Copy link
Contributor Author

Letme commented Jan 12, 2022

@SergeyKanzhelev no, but I tested on all currently supported versions (v1.21.4 1.21.7 1.22.4 and 1.23.0) and it was there in all. So I would expect this to get cherry-picked for those versions.

@liggitt
Copy link
Member

liggitt commented Jan 12, 2022

/approve
for dep update

/hold for @mrunalp ack if desired

I'm also unsure about the picks, especially to <= 1.21, since that was still on pre-1.0 runc RCs

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kolyshkin, Letme, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2022
@mrunalp
Copy link
Contributor

mrunalp commented Jan 19, 2022

/lgtm
/cancel hold

@mrunalp
Copy link
Contributor

mrunalp commented Jan 19, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2022
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@pacoxu
Copy link
Member

pacoxu commented Jan 19, 2022

/skip

@Letme
Copy link
Contributor Author

Letme commented Jan 19, 2022

/retest

@k8s-ci-robot
Copy link
Contributor

@Letme: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-integration fadb36e link unknown /test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Letme
Copy link
Contributor Author

Letme commented Jan 19, 2022

/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot merged commit 8b45805 into kubernetes:master Jan 19, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 19, 2022
@Letme
Copy link
Contributor Author

Letme commented Jan 22, 2022

I am a bit puzzled why this was not added to recent 1.23.2 release. Can someone explain? It would fix and existing bug in all the currently supported versions on RaspberryPi's

@Letme
Copy link
Contributor Author

Letme commented Feb 11, 2022

/milestone v1.22
/milestone v1.23

@k8s-ci-robot
Copy link
Contributor

@Letme: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.22
/milestone v1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

10 participants