Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include pod UID in secret/configmap cache key #107831

Merged
merged 1 commit into from Jan 28, 2022
Merged

Include pod UID in secret/configmap cache key #107831

merged 1 commit into from Jan 28, 2022

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jan 28, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

Includes pod uid in the key the kublet configmap/secret manager uses to manage registered pods. Noticed interleaved registerpod/unregisterpod calls in log of #107824 (comment)

xref #105204

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jan 28, 2022
@k8s-ci-robot
Copy link
Contributor

@liggitt: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 28, 2022
@liggitt
Copy link
Member Author

liggitt commented Jan 28, 2022

/assign @wojtek-t @smarterclayton

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jan 28, 2022
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 28, 2022
@liggitt liggitt mentioned this pull request Jan 28, 2022
Closed
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2022
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 28, 2022
@liggitt
Copy link
Member Author

liggitt commented Jan 28, 2022

/retest

@wojtek-t
Copy link
Member

Thanks a lot for fixing this Jordan!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt liggitt mentioned this pull request Jan 28, 2022
Merged
@k8s-ci-robot k8s-ci-robot merged commit f49a15a into kubernetes:master Jan 28, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 28, 2022
@liggitt liggitt deleted the key-pod-by-uid branch January 28, 2022 14:09
@gautierdelorme gautierdelorme mentioned this pull request Mar 16, 2022
Merged
@gautierdelorme gautierdelorme mentioned this pull request Mar 16, 2022
Merged
@rphillips rphillips mentioned this pull request Mar 22, 2022
Merged
@ehashman ehashman mentioned this pull request Apr 8, 2022
Closed
@gnufied gnufied mentioned this pull request Apr 14, 2022
Closed
This was referenced Apr 14, 2022
Merged
Merged
@liggitt liggitt added the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Apr 27, 2022
@openshift-ci-robot openshift-ci-robot mentioned this pull request May 12, 2022
Closed
This was referenced May 25, 2022
Closed
Closed
chenchun pushed a commit to chenchun/kubernetes that referenced this pull request Mar 20, 2024
Merge branch 'tke/v1.20.6-pr107831' into 'tke/v1.20.6' (merge request…
8b57eaf 
… !1034)

移植PR107831，在kubelet secret/configmap缓存中包含pod UID
[Include pod UID in secret/configmap cache key](kubernetes#107831)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@smarterclayton smarterclayton

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liggitt @k8s-ci-robot @wojtek-t @smarterclayton