Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.22] Move kubelet secret and configmap manager calls to sync_Pod functions #108754

Merged
merged 2 commits into from Mar 21, 2022
Merged

[release-1.22] Move kubelet secret and configmap manager calls to sync_Pod functions #108754

merged 2 commits into from Mar 21, 2022

Conversation

gautierdelorme
Copy link
Contributor

@gautierdelorme gautierdelorme commented Mar 16, 2022 •
edited by liggitt

/kind bug
/priority important-soon

Backports #107821 #107831

Fix a 1.22 regression in registering configmap and secret objects for volumes handled by the kubelet, resulting in sporadic "not registered" errors

@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Mar 16, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 16, 2022
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 16, 2022
@rphillips
Copy link
Member

/sig node
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2022
@rphillips
Copy link
Member

rphillips commented Mar 16, 2022 •
edited

/hold

there should be a 1.23 backport merged first, then backport into 1.22.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2022
@gautierdelorme
Copy link
Contributor Author

@rphillips 1.23 backport: #108756

@ehashman ehashman added this to Triage in SIG Node PR Triage Mar 17, 2022
ehashman
ehashman reviewed Mar 17, 2022
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/triage accepted
/hold cancel
/lgtm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 17, 2022
@ehashman ehashman moved this from Triage to Needs Approver in SIG Node PR Triage Mar 17, 2022
@liggitt
Copy link
Member

liggitt commented Mar 19, 2022 •
edited

/lgtm
/approve

This reduced the number of "MountVolume.SetUp failed for volume ... kube-root-ca.crt not registered" event report attempts from ~360 in a typical e2e to ~12.

/hold
for

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2022
@gautierdelorme
Copy link
Contributor Author

/cc @kubernetes/release-managers

for cherrypick approval

@k8s-ci-robot k8s-ci-robot requested a review from a team March 21, 2022 09:16
saschagrunert
saschagrunert approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@saschagrunert saschagrunert added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Mar 21, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gautierdelorme, liggitt, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gautierdelorme
Copy link
Contributor Author

/hold cancel

#108749 and #108756 are both merged

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2022
@k8s-ci-robot k8s-ci-robot merged commit dbb1bfe into kubernetes:release-1.22 Mar 21, 2022
SIG Node PR Triage automation moved this from Needs Approver to Done Mar 21, 2022
@gnufied gnufied mentioned this pull request Apr 14, 2022
Closed
@liggitt liggitt added the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Apr 27, 2022
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehashman ehashman ehashman left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@odinuge odinuge Awaiting requested review from odinuge

Assignees

@rphillips rphillips

@saschagrunert saschagrunert

@liggitt liggitt

@ehashman ehashman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gautierdelorme @rphillips @liggitt @k8s-ci-robot @saschagrunert @ehashman