New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added StartsWith and EndsWith Operators to Label Selectors #107972
Conversation
Welcome @CameronHall! |
Hi @CameronHall. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: CameronHall The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
/uncc |
@CameronHall do we have a KEP for this? if yes, we need to discuss this in API Machinery SIG meeting. |
@leilajal it doesn't look like we have a KEP. Does it still have to be discussed in the SIG meeting? |
@CameronHall it seems for the changes that impact APIs we need a KEP. |
/ok-to-test |
@CameronHall thanks, triaging for now - hoping to see you at the SIG meeting (or reach out to us with a KEP :) ). |
/retest |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
Sometimes we want to be able to select labels with values that “start with” or “end with” a particular string - I have a legitimate use case at the moment with external metrics. I understand that the recent proposition for regular expression support for selectors was rejected with concerns around performance.
In which case, I’m proposing an alternate solution that is more explicit and alleviates the potential performance impacts by bad actors or inefficient regular expressions.
Which issue(s) this PR fixes:
No specific issue yet - but it’s supplementary to #107053
Special notes for your reviewer:
I considered glob pattern support as suggested in #107053 but that’s a lot more effort and pushing the boundary of my Go/Kubernetes knowledge - I also much prefer the explicit nature of this approach with operators.
I have some questions for the team, around additional functionality.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
Does this need a KEP?