Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude non-ready nodes from azure load balancer #108284

Merged
merged 1 commit into from May 4, 2022

Conversation

ricky-rav
Copy link
Contributor

@ricky-rav ricky-rav commented Feb 22, 2022

What type of PR is this?

/kind bug
/kind regression

What this PR does / why we need it:

fix: exclude non-ready nodes and deleted nodes from azure load balancers

Make sure that nodes that are not in the ready state and are not newly created (i.e. not having the "node.cloudprovider.kubernetes.io/uninitialized" taint) get removed from load balancers.
Also remove nodes that are being deleted from the cluster.

Ref: kubernetes-sigs/cloud-provider-azure#1195

Which issue(s) this PR fixes:

Fixes #108283

/priority critical-urgent
/sig cloud-provider
/area provider/azure
cc @feiskyer
cc @nilo19

NONE

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 22, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @ricky-rav. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 22, 2022
@k8s-ci-robot k8s-ci-robot added area/cloudprovider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 22, 2022
@vpickard
Copy link
Contributor

/cc @deads2k

@vpickard
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 23, 2022
@deads2k
Copy link
Contributor

deads2k commented Feb 23, 2022

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 23, 2022
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 23, 2022
@andyzhangx
Copy link
Member

/lgtm
Need approval from @andrewsykim @cheftako

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2022
Copy link
Member

@andrewsykim andrewsykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I'm not a fan of using a separate node cache to filter nodes that are out of band from the node filtering service controller is already doing. It will also become harder to reason as the behaviors deviate over time like this PR is doing.

Approving since this is a bug fix and the separate node cache/filter already exists. I have not reviewed the azure specific changes in a lot of depth though, just approving that this is addressing a bug.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, ricky-rav

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2022
@andrewsykim
Copy link
Member

(I'm not sure this needs to go into v1.24 though, a cherry-pick afterwards might be better but will defer to azure subproject leads on that)

@nilo19
Copy link
Member

nilo19 commented Apr 8, 2022

@feiskyer do we need this on 1.24?

@ricky-rav
Copy link
Contributor Author

@nilo19 we most definitely need it in 1.24 and then I'll have to backport it to previous releases.

@deads2k
Copy link
Contributor

deads2k commented Apr 20, 2022

1.24.0 is about fully baked. Adding to 1.24.z, I'm in favor of

@k8s-ci-robot k8s-ci-robot merged commit 2c581a5 into kubernetes:master May 4, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone May 4, 2022
k8s-ci-robot added a commit that referenced this pull request Jun 25, 2022
…08284-upstream-release-1.23

Automated cherry pick of #108284: fix: exclude non-ready nodes and deleted nodes from azure
k8s-ci-robot added a commit that referenced this pull request Jun 25, 2022
…08284-upstream-release-1.24

Automated cherry pick of #108284: fix: exclude non-ready nodes and deleted nodes from azure
k8s-ci-robot added a commit that referenced this pull request Jun 25, 2022
…08284-upstream-release-1.22

Automated cherry pick of #108284: fix: exclude non-ready nodes and deleted nodes from azure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure load balancer is never updated when node status changes
9 participants