-
Notifications
You must be signed in to change notification settings - Fork 39.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apiserver: Remove the deprecated --service-account-api-audiences
flag
#108624
apiserver: Remove the deprecated --service-account-api-audiences
flag
#108624
Conversation
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@ialidzhikov: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @ialidzhikov. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @mikedanese |
/remove-sig api-machinery |
/assign @mikedanese PTAL. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
/cc @dims |
@ialidzhikov is there more to this than just removing the command line parameter? https://cs.k8s.io/?q=APIAudiences&i=nope&files=&excludeFiles=&repos=kubernetes/kubernetes |
The kubernetes/pkg/kubeapiserver/options/authentication.go Lines 246 to 250 in 92707ca
See the PR description for more details. IMO it is safe to remove the |
@mikedanese can you help checking this PR? |
/ok-to-test |
/assign @liggitt Notes: Simple PR to remove a command line parameter that was deprecated a while ago. |
I found one usage using both, which seems unintentional (https://github.com/cert-manager/aws-privateca-issuer/blob/main/e2e/kind_config/config.yaml#L20-L21)... probably worth reporting an issue to them /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ialidzhikov, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/kind cleanup
/priority backlog
The deprecation happened in v1.13 with #70105.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: