New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubelet: Update deprecation messages from 1.24 to 1.25 #108823
kubelet: Update deprecation messages from 1.24 to 1.25 #108823
Conversation
Hi @ialidzhikov. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Do we have an actual target for when these are getting removed? What is the corresponding KEP? |
The 5 flags do not seems to be related with each other, so I doubt that we will find a KEP that unites them all. |
For this pr:
We'd better change the log to
I think we should clean up the two flags that are not used by k/k anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/triage accept
/priority important-soon
@endocrimes: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/triage accepted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/lgtm
/retest
just a user friendly text update. Looks good
/assign @mrunalp |
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
c0ba2ec
to
0a83f72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
re-applying
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @dims @derekwaynecarr
just bumping version numbers. happy to land this. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, endocrimes, ialidzhikov, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind cleanup
/kind documentation
Similar to #106667
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: