kubelet remove deprecated flag --experimental-allocatable-ignore-eviction

[carlory]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The Kubelet's --experimental-allocatable-ignore-eviction option was marked as deprecated in 1.19. (#91578

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Removed the `--experimental-allocatable-ignore-eviction` command line argument to the kubelet.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: carlory
Once this PR has been reviewed and has the lgtm label, please assign mrunalp for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• cmd/kubelet/OWNERS
• pkg/kubelet/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[carlory]

/kind cleanup

[sftim]

/retitle kubelet remove deprecated flag --experimental-allocatable-ignore-eviction

---

Changelog suggestion

Removed the `--experimental-allocatable-ignore-eviction` command line argument to the kubelet.

[bart0sh]

/triage accepted
/priority important-longterm
/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: d88e5d1239e5039e95065c998d09146002da29cc

[carlory]

/assign @mrunalp

[carlory]

/cc @sjenning

can you take a look?

[kannon92]

So I’ve see some interesting use cases with this cli and swap. The main things I’ve seen are when people want to use swap to avoid evictions. They found this flag helpful to turn off memory evictions.

I also saw a cli change in kops to use this “deprecated” cli.

I’m not sure if we should remove the cli argument.

[kannon92]

kubernetes/kops#15821 For a recent example.

[carlory]

In addition to what you mentioned, @pacoxu also pointed out that the kubernetes/autoscale project also uses the flag in its test cases #108823 (comment).

IMO, any external project shouldn't depend on deprecated flags which maybe removed in a future release. There's a issue #86843 to track this, but it's closed due to inactivity. The --experimental-allocatable-ignore-eviction task is marked as done.

So, I want to ask if we can remove the flag in 1.30 release or have a plan to promote the flag to GA in the future release. Thanks.

/cc @pacoxu @savitharaghunathan @knabben

[carlory]

Friendly ping @tallclair, can you take a look at this PR? Is it time to remove the deprecated flag. I see this flag is mentioned by #122916

[knabben]

Friendly ping @tallclair, can you take a look at this PR? Is it time to remove the deprecated flag. I see this flag is mentioned by #122916

Per discussion in the issue let's wait for the final meeting outcome before proceeding with these changes.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[carlory]

/remove-lifecycle stale