-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace use of term "Minion" #1111
Comments
A few other options:
|
I don't want to change, but if we do I would vote for something bland like "node". |
The name we use in code is kubelet. Any reason why we shouldn't consider that one? (idk if it falls under the "slave" umbrella) |
Kubelet is the name of the agent. "Minion" is what we call the machine the agent runs on. |
I kind of like stevedore but it is long. Hyperetes apparently has some connotations around 'slave' according to wikipedia. I also worry that it is hard to pronounce. We already get enough crap around the name "kubernetes". What do you think about KNode? It is generic (as @lavalamp) wants but also kubernetes specific. |
I vote for a change. Minion did cause confusion to me initially when I first worked on this project. But I don't have a better naming suggestion here, and ok with KNode for sure. |
"(k)node" or "machine" sounds good. |
We often shorten Kubernetes Master to KMaster, so I can see the argument for shortening Kubernetes Node to KNode. Personally I'd prefer to just spell it out and say Kubernetes Node since just "None" seems a bit too generic. |
Knode - pronounced "node". The K is silent. :P On Fri, Aug 29, 2014 at 1:41 PM, roberthbailey notifications@github.com
|
I actually don't see a need, long-term, for distinguishing master vs. minion, since master components will be replicated & distributed across whatever minions are in the correct security zone to run them. I still like short generic terms. "kbox" is better than knode, but I like "box" better. :) Or "unit", which takes a k in front even easier: kunit. |
Please no box or unit. box has pohysical implications, and unit is a On Fri, Aug 29, 2014 at 1:50 PM, Daniel Smith notifications@github.com
|
Having to make up a new word to describe a fairly standard concept (a slave, minion, node, host, box) seems risky. I'd prefer not to make up new terminology for people to learn when they administer new systems. Master is pretty unambiguous, let's pick a word that matches the common use for the things masters control. |
I really think knode is self-explanatory On Fri, Aug 29, 2014 at 2:26 PM, Clayton Coleman notifications@github.com
|
I'm a fan of node / knode / Kubernetes node. |
I'm fine with node, but it's not very consistent with "master", which is also a node/host rather than a component in k8s. How about worker? |
Personally, worker sounds like a process running on one of the pool nodes. If we use KNode, I think it is reasonable that users will figure out that the master host isn't necessarily running on one of the KNodes. A KNode is a node that is part of a k8s cluster. |
+1 for kNode: it's mercifully short, and not confusing. kMachine would also be fine. (Although I like "minion" for being nicely tongue-in-cheek, it's a bit too easily confused with the functionality of a kubelet. But if you want to go down that path, then "vassal" would be nice - historically, some were immensely powerful. I agree that "worker" is confusing.) A "master" is a software function, like a kubelet, not a (k)node, so I'm not sure it matters where it runs. |
I'm not sure why we need a distinctive/cute name for the machines that run kubelets. In all of the documentation and code that K8s devs write, we will almost always be talking about machines that are part of a k8s cluster, and rarely about ones that are not. So "machine" will be clear enough. For the ops folks who run k8s clusters alongside a range of other services, they will already have terms to distinguish machines with different roles, and don't need us to make one up. I vote for "machine". |
"machine" is generic enough for me. I feel like we completely used up our cuteness quota with "Kubernetes". |
Summarizing: The thing that tells other things what to do:
The thing that hosts pods
|
+1 for node over machine. |
Here is what I'd say we go with:
I'm not a huge fan of plain "node" as it is pretty generic. KNode is short and kubernetes specific. |
So here's my counter to "K*" anything (I'm fine with Kubernetes *) - why not "KPods" or "KServices" or "KReplicationControllers"? Mesos doesn't call its slaves "MSlaves" (it's just a Mesos slave), and the same argument probably applies to most systems. It also avoids us having to do terrible things with casing in function definitions (or at least I think they're terrible):
|
I think the K* / Kubernetes is either implied by context and thus unnecessary, or K by itself isn't sufficient to know what it is (if I told a random admin "check out this KNode" he'd look at me like I was crazy). |
Okay -- how about we say the official name is "Kubernetes Node" but that can be abbreviated KNode or Node as necessary. In code and such, plain old Node is perfectly okay if Kubernetes is implied. As for K* -- Pods and ReplicationControllers are unique enough they don't need a K. Services is way too generic already and I'm sure we'll bikeshed on that soon :) Someone want to sign up on doing this? Or did I sign myself up? |
(I was just reading this article on zookeeper where they talk about zNodes. Heh. https://www.found.no/foundation/ZooKeeper-King-of-Coordination/) |
Suggestion: Rather than bikeshedding on each new naming decision, we should bikeshed once on picking a benevolent Name Czar, and then defer to the Czar, after a short discussion period, to make a decision on all Naming issues. That will result in faster progress and more thoughtful, consistent naming throughout the project. |
Why don't we hoist the bikesheding on bikesheding discussion to kubernetes-dev@googlegroups.com? I'm going to call this one -- we'll rename |
Contination of kubernetes#1111 I tried to keep this PR down to just a simple search-n-replace to keep things simple. I may have gone too far in some spots but its easy to roll those back if needed. I avoided renaming `contrib/mesos/pkg/minion` because there's already a `contrib/mesos/pkg/node` dir and fixing that will require a bit of work due to a circular import chain that pops up. So I'm saving that for a follow-on PR. I rolled back some of this from a previous commit because it just got to big/messy. Will follow up with additional PRs Signed-off-by: Doug Davis <dug@us.ibm.com>
Automatic merge from submit-queue Change minion to node Continuation of #1111 I tried to keep this PR down to just a simple search-n-replace to keep things simple. I may have gone too far in some spots but its easy to roll those back if needed - just let me know. I avoided renaming `contrib/mesos/pkg/minion` because there's already a `contrib/mesos/pkg/node` dir and fixing that will require a bit of work due to a circular import chain that pops up. So I'm saving that for a follow-on PR. Signed-off-by: Doug Davis <dug@us.ibm.com>
Automatic merge from submit-queue Remove 'minion' from the code in two places in favor of 'node' Part of #1111
Contination of kubernetes#1111 I tried to keep this PR down to just a simple search-n-replace to keep things simple. I may have gone too far in some spots but its easy to roll those back if needed. I avoided renaming `contrib/mesos/pkg/minion` because there's already a `contrib/mesos/pkg/node` dir and fixing that will require a bit of work due to a circular import chain that pops up. So I'm saving that for a follow-on PR. I rolled back some of this from a previous commit because it just got to big/messy. Will follow up with additional PRs Signed-off-by: Doug Davis <dug@us.ibm.com>
Contination of kubernetes#1111 I tried to keep this PR down to just a simple search-n-replace to keep things simple. I may have gone too far in some spots but its easy to roll those back if needed. I avoided renaming `contrib/mesos/pkg/minion` because there's already a `contrib/mesos/pkg/node` dir and fixing that will require a bit of work due to a circular import chain that pops up. So I'm saving that for a follow-on PR. I rolled back some of this from a previous commit because it just got to big/messy. Will follow up with additional PRs Signed-off-by: Doug Davis <dug@us.ibm.com>
Automatic merge from submit-queue Change minion to node Continuation of kubernetes#1111 I tried to keep this PR down to just a simple search-n-replace to keep things simple. I may have gone too far in some spots but its easy to roll those back if needed - just let me know. I avoided renaming `contrib/mesos/pkg/minion` because there's already a `contrib/mesos/pkg/node` dir and fixing that will require a bit of work due to a circular import chain that pops up. So I'm saving that for a follow-on PR. Signed-off-by: Doug Davis <dug@us.ibm.com>
Minion is still present in scripts in /cluster, such as: kubernetes/cluster/gce/config-default.sh Line 78 in 8b8fb6c
We should at least be able to eradicate it when we fully remove provider-specific code from this repo. |
Not sure if this is the right place and time, but how about having the I think that would remove one level of ambiguity. |
Issues go stale after 90d of inactivity. Prevent issues from auto-closing with an If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or |
I really want to see this finished!!
…On Thu, Dec 28, 2017 at 3:12 PM, fejta-bot ***@***.***> wrote:
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually
close.
Prevent issues from auto-closing with an /lifecycle frozen comment.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1111 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALNCD5osLvD70SJJH83gJYEiT3mWuELMks5tFCBYgaJpZM4Ccr_p>
.
|
https://github.com/kubernetes/kubernetes/search?utf8=%E2%9C%93&q=minion&type= This only exists in a few places in the cluster directory, which we're going to eliminate at some point, so this done enough |
The term "minion" was changed to "node" in 2014, The discussion and eventual deprcation is documented on kubernetes/kubernetes#1111 "A node is a worker machine in Kubernetes, previously known as a minion." - https://kubernetes.io/docs/concepts/architecture/nodes/ updating the documentation to reflect correct terminology
There has been quite a bit of confusion over our use of the term "minion". While it captures what a worker node in a k8s cluster is well, it is highly associated with Salt. This has led to some confusion where people think that Salt is playing a larger role in k8s than it actually is.
I propose that we change from Minion to something that is more Kubernetes specific.
Questions:
The text was updated successfully, but these errors were encountered: