-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #112650: kubelet: increase log level for Path does not exist message #112653
Conversation
@rphillips: This cherry pick PR is for a release branch and has not yet been approved by Release Managers. To merge this cherry pick, it must first be approved ( AFTER it has been approved by code owners, please leave the following comment on a line by itself, with no leading whitespace: /cc kubernetes/release-managers (This command will request a cherry pick review from Release Managers and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.) For details on the patch release process and schedule, see the Patch Releases page. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rphillips: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rphillips The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/king bug |
Sorry, I missed and didn't have a chance to comment on the original PR. The original bug suggests that there are so many these logs that the kubelet grows out of memory. Is hiding the message solves the problem? Will the function keep being called over and over? /hold |
@SergeyKanzhelev The issue mentions a memory leak separate from the log spam. I am unsure about the memory leak, but the leak is probably not in the logger. I don't think we should hold this PR because it clearly fixes a log line that shouldn't be in the normal run path. |
Is there understanding why this line was printed so many times that the issue complained about the log spam? Is this code suppose to be called so many time? |
The function is called by HandlePodCleanups via the Kubelet's HouseKeeping timer (IIRC every 10s). So the kubelet is trying to cleanup some pod paths, getting into a situation where the path has already been cleaned up, and then printing the log spam message. This is for every pod or orphaned pod on the node :). |
is it once per pod or constantly? Will this ever end or it will continue trying to clean up till kubelet restarted? (I'm only speculating based on the original issue report). The problem with hiding a log message in a never-ending retries is that we are hiding the ticking bomb or a memory leak and CPU waste. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
ping @rphillips is this still valid? |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Cherry pick of #112650 on release-1.25.
#112650: kubelet: increase log level for Path does not exist message
For details on the cherry pick process, see the cherry pick requests page.