Automated cherry pick of #115391: allow to mutate pv nodeaffinity label key

[vpnachev]

Cherry pick of #115391 on release-1.25.

#115391: allow to mutate pv nodeaffinity label key

For details on the cherry pick process, see the cherry pick requests page.

PersistentVolume API objects which set NodeAffinities using beta Kubernetes labels for OS, architecture, zone, region, and instance type may now be modified to use the stable Kubernetes labels.

[k8s-ci-robot]

This cherry pick PR is for a release branch and has not yet been approved by Release Managers.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved (/lgtm + /approve) by the relevant OWNERS.

If you didn't cherry-pick this change to all supported release branches, please leave a comment describing why other cherry-picks are not needed to speed up the review process.

If you're not sure is it required to cherry-pick this change to all supported release branches, please consult the cherry-pick guidelines document.

AFTER it has been approved by code owners, please leave the following comment on a line by itself, with no leading whitespace: /cc kubernetes/release-managers

(This command will request a cherry pick review from Release Managers and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)

For details on the patch release process and schedule, see the Patch Releases page.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Hi @vpnachev. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vpnachev
Once this PR has been reviewed and has the lgtm label, please assign smarterclayton for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/apis/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vpnachev]

After changes like kubernetes-sigs/cloud-provider-azure#2653, the deprecated labels are removed from the nodes for k8s 1.26, so we need this bugfix to get out of the situation where the pods cannot be scheduled because the nodes does not match any node in the cluster.

/kind bug
/sig apps
/sig storage
/priority critical-urgent
/cc @msau42

[vpnachev]

/cc @liggitt

[liggitt]

It's not clear to me that this should be backported, since it's not fixing a bug or regression.

[vpnachev]

/priority important-soon

as per #119756 (comment)

[dims]

note from @msau42 on slack - https://kubernetes.slack.com/archives/CJH2GBF7Y/p1697570986616679?thread_ts=1697452046.109219&cid=CJH2GBF7Y

/close

[k8s-ci-robot]

@dims: Closed this PR.

In response to this:

note from @msau42 on slack - https://kubernetes.slack.com/archives/CJH2GBF7Y/p1697570986616679?thread_ts=1697452046.109219&cid=CJH2GBF7Y

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.