-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #115391: allow to mutate pv nodeaffinity label key #119756
Automated cherry pick of #115391: allow to mutate pv nodeaffinity label key #119756
Conversation
This cherry pick PR is for a release branch and has not yet been approved by Release Managers. To merge this cherry pick, it must first be approved ( If you didn't cherry-pick this change to all supported release branches, please leave a comment describing why other cherry-picks are not needed to speed up the review process. If you're not sure is it required to cherry-pick this change to all supported release branches, please consult the cherry-pick guidelines document. AFTER it has been approved by code owners, please leave the following comment on a line by itself, with no leading whitespace: /cc kubernetes/release-managers (This command will request a cherry pick review from Release Managers and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.) For details on the patch release process and schedule, see the Patch Releases page. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @vpnachev. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vpnachev The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
After changes like kubernetes-sigs/cloud-provider-azure#2653, the deprecated labels are removed from the nodes for k8s 1.26, so we need this bugfix to get out of the situation where the pods cannot be scheduled because the nodes does not match any node in the cluster. /kind bug |
/cc @liggitt |
It's not clear to me that this should be backported, since it's not fixing a bug or regression. |
The issue is that older clusters that have configured node affinity of a PV with the now deprecated labels fails to schedule pods to any node as the cloud controller manager no longer maintains those deprecated labels on the nodes. One example is with the Azure Cloud Controller Manager which starting from v1.26 no longer maintain the deprecated labels, for example To get out of this deadlock, it would be nice even for older k8s versions the labels keys to be made mutable and this is why I opened the cherry-picks. |
Ok, for provider azure kubernetes-sigs/cloud-provider-azure#3685 can be used to also get out of the dead lock, though not sure if other CCMs are affected and if they support such option. I will lower the priority. /priority important-soon |
note from @msau42 on slack - https://kubernetes.slack.com/archives/CJH2GBF7Y/p1697570986616679?thread_ts=1697452046.109219&cid=CJH2GBF7Y /close |
@dims: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Cherry pick of #115391 on release-1.26.
#115391: allow to mutate pv nodeaffinity label key
For details on the cherry pick process, see the cherry pick requests page.