Promote KEP-2681 to beta in 1.29 #120257

wzshiming · 2023-08-30T10:10:17Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Promote PodHostIPs condition to beta.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/2681
- [Usage]: <link>
- [Other doc]:

k8s-ci-robot · 2023-08-30T10:10:26Z

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wzshiming · 2023-09-01T11:45:35Z

/test ?

k8s-ci-robot · 2023-09-01T11:45:37Z

@wzshiming: The following commands are available to trigger required jobs:

/test pull-cadvisor-e2e-kubernetes
/test pull-kubernetes-conformance-kind-ga-only-parallel
/test pull-kubernetes-coverage-unit
/test pull-kubernetes-dependencies
/test pull-kubernetes-dependencies-go-canary
/test pull-kubernetes-e2e-gce
/test pull-kubernetes-e2e-gce-100-performance
/test pull-kubernetes-e2e-gce-big-performance
/test pull-kubernetes-e2e-gce-canary
/test pull-kubernetes-e2e-gce-cos
/test pull-kubernetes-e2e-gce-cos-canary
/test pull-kubernetes-e2e-gce-cos-no-stage
/test pull-kubernetes-e2e-gce-network-proxy-http-connect
/test pull-kubernetes-e2e-gce-scale-performance-manual
/test pull-kubernetes-e2e-kind
/test pull-kubernetes-e2e-kind-ipv6
/test pull-kubernetes-integration
/test pull-kubernetes-integration-go-canary
/test pull-kubernetes-kubemark-e2e-gce-scale
/test pull-kubernetes-node-e2e-containerd
/test pull-kubernetes-typecheck
/test pull-kubernetes-unit
/test pull-kubernetes-unit-go-canary
/test pull-kubernetes-update
/test pull-kubernetes-verify
/test pull-kubernetes-verify-go-canary

The following commands are available to trigger optional jobs:

/test check-dependency-stats
/test pull-ci-kubernetes-unit-windows
/test pull-e2e-gce-cloud-provider-disabled
/test pull-kubernetes-conformance-image-test
/test pull-kubernetes-conformance-kind-ga-only
/test pull-kubernetes-conformance-kind-ipv6-parallel
/test pull-kubernetes-cos-cgroupv1-containerd-node-e2e
/test pull-kubernetes-cos-cgroupv1-containerd-node-e2e-features
/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e
/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-eviction
/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-features
/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-serial
/test pull-kubernetes-cross
/test pull-kubernetes-e2e-autoscaling-hpa-cm
/test pull-kubernetes-e2e-autoscaling-hpa-cpu
/test pull-kubernetes-e2e-capz-azure-disk
/test pull-kubernetes-e2e-capz-azure-disk-vmss
/test pull-kubernetes-e2e-capz-azure-file
/test pull-kubernetes-e2e-capz-azure-file-vmss
/test pull-kubernetes-e2e-capz-conformance
/test pull-kubernetes-e2e-capz-windows-alpha-feature-vpa
/test pull-kubernetes-e2e-capz-windows-alpha-features
/test pull-kubernetes-e2e-capz-windows-master
/test pull-kubernetes-e2e-capz-windows-serial-slow-hpa
/test pull-kubernetes-e2e-containerd-gce
/test pull-kubernetes-e2e-ec2
/test pull-kubernetes-e2e-ec2-conformance
/test pull-kubernetes-e2e-gce-correctness
/test pull-kubernetes-e2e-gce-cos-alpha-features
/test pull-kubernetes-e2e-gce-cos-kubetest2
/test pull-kubernetes-e2e-gce-csi-serial
/test pull-kubernetes-e2e-gce-device-plugin-gpu
/test pull-kubernetes-e2e-gce-kubelet-credential-provider
/test pull-kubernetes-e2e-gce-network-proxy-grpc
/test pull-kubernetes-e2e-gce-serial
/test pull-kubernetes-e2e-gce-storage-disruptive
/test pull-kubernetes-e2e-gce-storage-slow
/test pull-kubernetes-e2e-gce-storage-snapshot
/test pull-kubernetes-e2e-gci-gce-autoscaling
/test pull-kubernetes-e2e-gci-gce-ingress
/test pull-kubernetes-e2e-gci-gce-ipvs
/test pull-kubernetes-e2e-inplace-pod-resize-containerd-main-v2
/test pull-kubernetes-e2e-kind-alpha-features
/test pull-kubernetes-e2e-kind-canary
/test pull-kubernetes-e2e-kind-dual-canary
/test pull-kubernetes-e2e-kind-ipv6-canary
/test pull-kubernetes-e2e-kind-ipvs-dual-canary
/test pull-kubernetes-e2e-kind-kms
/test pull-kubernetes-e2e-kind-multizone
/test pull-kubernetes-e2e-kops-aws
/test pull-kubernetes-e2e-storage-kind-disruptive
/test pull-kubernetes-e2e-ubuntu-gce-network-policies
/test pull-kubernetes-integration-eks
/test pull-kubernetes-kind-dra
/test pull-kubernetes-kind-json-logging
/test pull-kubernetes-kind-text-logging
/test pull-kubernetes-kubemark-e2e-gce-big
/test pull-kubernetes-linter-hints
/test pull-kubernetes-local-e2e
/test pull-kubernetes-node-arm64-e2e-containerd-ec2
/test pull-kubernetes-node-arm64-e2e-containerd-serial-ec2
/test pull-kubernetes-node-arm64-ubuntu-serial-gce
/test pull-kubernetes-node-crio-cgrpv1-evented-pleg-e2e
/test pull-kubernetes-node-crio-cgrpv2-e2e
/test pull-kubernetes-node-crio-cgrpv2-e2e-kubetest2
/test pull-kubernetes-node-crio-e2e
/test pull-kubernetes-node-crio-e2e-kubetest2
/test pull-kubernetes-node-e2e-containerd-alpha-features
/test pull-kubernetes-node-e2e-containerd-ec2
/test pull-kubernetes-node-e2e-containerd-features
/test pull-kubernetes-node-e2e-containerd-features-kubetest2
/test pull-kubernetes-node-e2e-containerd-kubetest2
/test pull-kubernetes-node-e2e-containerd-serial-ec2
/test pull-kubernetes-node-e2e-containerd-sidecar-containers
/test pull-kubernetes-node-e2e-containerd-standalone-mode
/test pull-kubernetes-node-e2e-containerd-standalone-mode-all-alpha
/test pull-kubernetes-node-e2e-crio-dra
/test pull-kubernetes-node-kubelet-credential-provider
/test pull-kubernetes-node-kubelet-serial-containerd
/test pull-kubernetes-node-kubelet-serial-containerd-kubetest2
/test pull-kubernetes-node-kubelet-serial-cpu-manager
/test pull-kubernetes-node-kubelet-serial-cpu-manager-kubetest2
/test pull-kubernetes-node-kubelet-serial-crio-cgroupv1
/test pull-kubernetes-node-kubelet-serial-crio-cgroupv2
/test pull-kubernetes-node-kubelet-serial-hugepages
/test pull-kubernetes-node-kubelet-serial-memory-manager
/test pull-kubernetes-node-kubelet-serial-pod-disruption-conditions
/test pull-kubernetes-node-kubelet-serial-topology-manager
/test pull-kubernetes-node-kubelet-serial-topology-manager-kubetest2
/test pull-kubernetes-node-memoryqos-cgrpv2
/test pull-kubernetes-node-swap-fedora
/test pull-kubernetes-node-swap-fedora-serial
/test pull-kubernetes-node-swap-ubuntu-serial
/test pull-kubernetes-unit-experimental
/test pull-kubernetes-verify-strict-lint
/test pull-publishing-bot-validate

Use /test all to run the following jobs that were automatically triggered:

pull-kubernetes-conformance-kind-ga-only-parallel
pull-kubernetes-conformance-kind-ipv6-parallel
pull-kubernetes-dependencies
pull-kubernetes-e2e-ec2
pull-kubernetes-e2e-ec2-conformance
pull-kubernetes-e2e-gce
pull-kubernetes-e2e-gce-cos-alpha-features
pull-kubernetes-e2e-inplace-pod-resize-containerd-main-v2
pull-kubernetes-e2e-kind
pull-kubernetes-e2e-kind-ipv6
pull-kubernetes-integration
pull-kubernetes-linter-hints
pull-kubernetes-node-e2e-containerd
pull-kubernetes-typecheck
pull-kubernetes-unit
pull-kubernetes-verify
pull-kubernetes-verify-strict-lint

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wzshiming · 2023-09-22T07:58:00Z

/test pull-kubernetes-e2e-kind-dual-canary

wzshiming · 2023-10-07T01:55:34Z

test/e2e_node/pod_host_ips.go

 )

-var _ = common.SIGDescribe("Dual Stack Host IP [Feature:PodHostIPs]", func() {
+var _ = common.SIGDescribe("DualStack Host IP [NodeFeature:PodHostIPs] [Feature:PodHostIPs]", func() {


DualStack https://github.com/kubernetes/test-infra/blob/f8adf234323fa8a9d0c97451b24302a78d4f8c4c/config/jobs/kubernetes/sig-network/sig-network-kind.yaml#L28

[NodeFeature:PodHostIPs] https://github.com/kubernetes/test-infra/blob/f8adf234323fa8a9d0c97451b24302a78d4f8c4c/config/jobs/kubernetes/sig-node/containerd.yaml#L165

Add these cases into Testgrid, I'm not sure it's going to work.

wzshiming · 2023-10-07T01:59:54Z

/test all

k8s-ci-robot · 2023-10-07T02:04:06Z

@wzshiming: The label(s) sig/networking cannot be applied, because the repository doesn't have them.

In response to this:

/sig networking

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2023-10-07T10:23:06Z

@wzshiming: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-cadvisor-e2e-kubernetes
/test pull-kubernetes-conformance-kind-ga-only-parallel
/test pull-kubernetes-coverage-unit
/test pull-kubernetes-dependencies
/test pull-kubernetes-dependencies-go-canary
/test pull-kubernetes-e2e-gce
/test pull-kubernetes-e2e-gce-100-performance
/test pull-kubernetes-e2e-gce-big-performance
/test pull-kubernetes-e2e-gce-canary
/test pull-kubernetes-e2e-gce-cos
/test pull-kubernetes-e2e-gce-cos-canary
/test pull-kubernetes-e2e-gce-cos-no-stage
/test pull-kubernetes-e2e-gce-network-proxy-http-connect
/test pull-kubernetes-e2e-gce-scale-performance-manual
/test pull-kubernetes-e2e-kind
/test pull-kubernetes-e2e-kind-ipv6
/test pull-kubernetes-integration
/test pull-kubernetes-integration-go-canary
/test pull-kubernetes-kubemark-e2e-gce-scale
/test pull-kubernetes-node-e2e-containerd
/test pull-kubernetes-typecheck
/test pull-kubernetes-unit
/test pull-kubernetes-unit-go-canary
/test pull-kubernetes-update
/test pull-kubernetes-verify
/test pull-kubernetes-verify-go-canary

The following commands are available to trigger optional jobs:

/test check-dependency-stats
/test pull-ci-kubernetes-unit-windows
/test pull-crio-cgroupv1-node-e2e-eviction
/test pull-crio-cgroupv1-node-e2e-features
/test pull-crio-cgroupv1-node-e2e-hugepages
/test pull-crio-cgroupv1-node-e2e-resource-managers
/test pull-e2e-gce-cloud-provider-disabled
/test pull-kubernetes-conformance-image-test
/test pull-kubernetes-conformance-kind-ga-only
/test pull-kubernetes-conformance-kind-ipv6-parallel
/test pull-kubernetes-cos-cgroupv1-containerd-node-e2e
/test pull-kubernetes-cos-cgroupv1-containerd-node-e2e-features
/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e
/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-eviction
/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-features
/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-serial
/test pull-kubernetes-crio-node-memoryqos-cgrpv2
/test pull-kubernetes-cross
/test pull-kubernetes-e2e-autoscaling-hpa-cm
/test pull-kubernetes-e2e-autoscaling-hpa-cpu
/test pull-kubernetes-e2e-capz-azure-disk
/test pull-kubernetes-e2e-capz-azure-disk-vmss
/test pull-kubernetes-e2e-capz-azure-file
/test pull-kubernetes-e2e-capz-azure-file-vmss
/test pull-kubernetes-e2e-capz-conformance
/test pull-kubernetes-e2e-capz-windows-alpha-feature-vpa
/test pull-kubernetes-e2e-capz-windows-alpha-features
/test pull-kubernetes-e2e-capz-windows-master
/test pull-kubernetes-e2e-capz-windows-serial-slow-hpa
/test pull-kubernetes-e2e-containerd-gce
/test pull-kubernetes-e2e-ec2
/test pull-kubernetes-e2e-ec2-conformance
/test pull-kubernetes-e2e-gce-correctness
/test pull-kubernetes-e2e-gce-cos-alpha-features
/test pull-kubernetes-e2e-gce-cos-kubetest2
/test pull-kubernetes-e2e-gce-csi-serial
/test pull-kubernetes-e2e-gce-device-plugin-gpu
/test pull-kubernetes-e2e-gce-kubelet-credential-provider
/test pull-kubernetes-e2e-gce-network-proxy-grpc
/test pull-kubernetes-e2e-gce-serial
/test pull-kubernetes-e2e-gce-storage-disruptive
/test pull-kubernetes-e2e-gce-storage-slow
/test pull-kubernetes-e2e-gce-storage-snapshot
/test pull-kubernetes-e2e-gci-gce-autoscaling
/test pull-kubernetes-e2e-gci-gce-ingress
/test pull-kubernetes-e2e-gci-gce-ipvs
/test pull-kubernetes-e2e-inplace-pod-resize-containerd-main-v2
/test pull-kubernetes-e2e-kind-alpha-features
/test pull-kubernetes-e2e-kind-canary
/test pull-kubernetes-e2e-kind-dual-canary
/test pull-kubernetes-e2e-kind-ipv6-canary
/test pull-kubernetes-e2e-kind-ipvs-dual-canary
/test pull-kubernetes-e2e-kind-kms
/test pull-kubernetes-e2e-kind-multizone
/test pull-kubernetes-e2e-kops-aws
/test pull-kubernetes-e2e-storage-kind-disruptive
/test pull-kubernetes-e2e-ubuntu-gce-network-policies
/test pull-kubernetes-integration-eks
/test pull-kubernetes-kind-dra
/test pull-kubernetes-kind-json-logging
/test pull-kubernetes-kind-text-logging
/test pull-kubernetes-kubemark-e2e-gce-big
/test pull-kubernetes-linter-hints
/test pull-kubernetes-local-e2e
/test pull-kubernetes-node-arm64-e2e-containerd-ec2
/test pull-kubernetes-node-arm64-e2e-containerd-serial-ec2
/test pull-kubernetes-node-arm64-ubuntu-serial-gce
/test pull-kubernetes-node-crio-cgrpv1-evented-pleg-e2e
/test pull-kubernetes-node-crio-cgrpv2-e2e
/test pull-kubernetes-node-crio-cgrpv2-e2e-kubetest2
/test pull-kubernetes-node-crio-e2e
/test pull-kubernetes-node-crio-e2e-kubetest2
/test pull-kubernetes-node-e2e-containerd-1-7-dra
/test pull-kubernetes-node-e2e-containerd-alpha-features
/test pull-kubernetes-node-e2e-containerd-ec2
/test pull-kubernetes-node-e2e-containerd-features
/test pull-kubernetes-node-e2e-containerd-features-kubetest2
/test pull-kubernetes-node-e2e-containerd-kubetest2
/test pull-kubernetes-node-e2e-containerd-serial-ec2
/test pull-kubernetes-node-e2e-containerd-sidecar-containers
/test pull-kubernetes-node-e2e-containerd-standalone-mode
/test pull-kubernetes-node-e2e-containerd-standalone-mode-all-alpha
/test pull-kubernetes-node-e2e-crio-dra
/test pull-kubernetes-node-kubelet-credential-provider
/test pull-kubernetes-node-kubelet-serial-containerd
/test pull-kubernetes-node-kubelet-serial-containerd-alpha-features
/test pull-kubernetes-node-kubelet-serial-containerd-kubetest2
/test pull-kubernetes-node-kubelet-serial-containerd-sidecar-containers
/test pull-kubernetes-node-kubelet-serial-cpu-manager
/test pull-kubernetes-node-kubelet-serial-cpu-manager-kubetest2
/test pull-kubernetes-node-kubelet-serial-crio-cgroupv1
/test pull-kubernetes-node-kubelet-serial-crio-cgroupv2
/test pull-kubernetes-node-kubelet-serial-hugepages
/test pull-kubernetes-node-kubelet-serial-memory-manager
/test pull-kubernetes-node-kubelet-serial-pod-disruption-conditions
/test pull-kubernetes-node-kubelet-serial-topology-manager
/test pull-kubernetes-node-kubelet-serial-topology-manager-kubetest2
/test pull-kubernetes-node-swap-fedora
/test pull-kubernetes-node-swap-fedora-serial
/test pull-kubernetes-node-swap-ubuntu-serial
/test pull-kubernetes-unit-experimental
/test pull-kubernetes-verify-strict-lint
/test pull-publishing-bot-validate

Use /test all to run the following jobs that were automatically triggered:

pull-kubernetes-conformance-kind-ga-only-parallel
pull-kubernetes-conformance-kind-ipv6-parallel
pull-kubernetes-dependencies
pull-kubernetes-e2e-ec2
pull-kubernetes-e2e-ec2-conformance
pull-kubernetes-e2e-gce
pull-kubernetes-e2e-gce-cos-alpha-features
pull-kubernetes-e2e-kind
pull-kubernetes-e2e-kind-ipv6
pull-kubernetes-integration
pull-kubernetes-linter-hints
pull-kubernetes-node-e2e-containerd
pull-kubernetes-typecheck
pull-kubernetes-unit
pull-kubernetes-verify
pull-kubernetes-verify-strict-lint

In response to this:

/test ci-cos-cgroupv1-containerd-node-e2e-features

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wzshiming · 2023-10-07T10:49:40Z

/test pull-kubernetes-e2e-kind
/test pull-kubernetes-e2e-kind-ipv6

wzshiming · 2023-10-11T11:03:02Z

/retest

wzshiming · 2023-10-12T02:23:24Z

PTAL

/assign @thockin

thockin · 2023-10-14T23:17:14Z

test/e2e_node/pod_host_ips.go

@@ -250,9 +209,91 @@ var _ = common.SIGDescribe("Dual Stack Host IP [Feature:PodHostIPs]", func() {

 			testDownwardAPI(ctx, f, podName, env, expectations)
 		})
+
+		ginkgo.It("rollback", func(ctx context.Context) {


"It" statements need to describe what is being tested - tsee the manyu other examples

thockin

Thanks!

/lgtm
/approve

k8s-ci-robot · 2023-10-19T23:17:21Z

LGTM label has been added.

Git tree hash: ddc2efa433886a192df828831b2afd3a212b3f01

k8s-ci-robot · 2023-10-19T23:17:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin, wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/features/OWNERS~~ [thockin]
~~test/e2e_node/OWNERS~~ [thockin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2023-10-20T00:13:01Z

@wzshiming: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-cos-cgroupv2-containerd-node-e2e-serial	`91ed9cd`	link	false	`/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-serial`
pull-kubernetes-e2e-gce-scale-performance-manual	`91ed9cd`	link	true	`/test pull-kubernetes-e2e-gce-scale-performance-manual`
pull-kubernetes-e2e-gce-canary	`91ed9cd`	link	true	`/test pull-kubernetes-e2e-gce-canary`
pull-cadvisor-e2e-kubernetes	`91ed9cd`	link	true	`/test pull-cadvisor-e2e-kubernetes`
pull-kubernetes-e2e-gce-cos-no-stage	`91ed9cd`	link	true	`/test pull-kubernetes-e2e-gce-cos-no-stage`
pull-kubernetes-e2e-gce-network-proxy-http-connect	`91ed9cd`	link	true	`/test pull-kubernetes-e2e-gce-network-proxy-http-connect`
pull-kubernetes-node-e2e-containerd-features-kubetest2	`91ed9cd`	link	false	`/test pull-kubernetes-node-e2e-containerd-features-kubetest2`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Aug 30, 2023

wzshiming mentioned this pull request Aug 30, 2023

Field status.hostIPs added for Pod kubernetes/enhancements#2681

Open

12 tasks

k8s-ci-robot requested review from dims and smarterclayton August 30, 2023 10:10

wzshiming changed the title ~~Promote KEP-2681 to beta in 1.29~~ [WIP] Promote KEP-2681 to beta in 1.29 Sep 1, 2023

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 1, 2023

wzshiming force-pushed the promote-kep-2681-beta branch from 72c8942 to edc5be3 Compare September 1, 2023 10:24

wzshiming force-pushed the promote-kep-2681-beta branch 3 times, most recently from 57c1cbf to be24ae4 Compare September 1, 2023 10:59

k8s-ci-robot added the area/kubelet label Sep 1, 2023

bart0sh added this to WIP in SIG Node PR Triage Sep 2, 2023

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 4, 2023

wzshiming force-pushed the promote-kep-2681-beta branch from 56a9362 to e66c509 Compare September 4, 2023 06:14

wzshiming force-pushed the promote-kep-2681-beta branch from e630236 to 91ed9cd Compare September 22, 2023 07:57

wzshiming commented Oct 7, 2023

View reviewed changes

wzshiming moved this from PRs Waiting on Author to PRs - Needs Reviewer in SIG Node CI/Test Board Oct 7, 2023

wzshiming moved this from WIP to Needs Reviewer in SIG Node PR Triage Oct 7, 2023

k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Oct 7, 2023

wzshiming force-pushed the promote-kep-2681-beta branch from 91ed9cd to 5863ee7 Compare October 9, 2023 01:59

k8s-ci-robot assigned thockin Oct 12, 2023

thockin reviewed Oct 14, 2023

View reviewed changes

Promote KEP-2681 to beta in 1.29

33f2d48

wzshiming force-pushed the promote-kep-2681-beta branch from 5863ee7 to 33f2d48 Compare October 16, 2023 02:10

thockin reviewed Oct 19, 2023

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2023

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2023

k8s-ci-robot merged commit b32c6ff into kubernetes:master Oct 20, 2023
16 checks passed

SIG Node CI/Test Board automation moved this from PRs - Needs Reviewer to Done Oct 20, 2023

SIG Node PR Triage automation moved this from Needs Reviewer to Done Oct 20, 2023

k8s-ci-robot added this to the v1.29 milestone Oct 20, 2023

wzshiming deleted the promote-kep-2681-beta branch October 20, 2023 04:31

pacoxu mentioned this pull request Oct 23, 2023

[Failing-Test][sig-network] DualStack Host IP [Feature:PodHostIPs] when creating a Pod, it has no PodHostIPs feature should create pod with hostNetwork, add host ips is empty #121424

Closed

aojea mentioned this pull request Oct 23, 2023

Revert "Promote KEP-2681 to beta in 1.29" #121445

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Promote KEP-2681 to beta in 1.29 #120257

Promote KEP-2681 to beta in 1.29 #120257

wzshiming commented Aug 30, 2023 •

edited

k8s-ci-robot commented Aug 30, 2023

wzshiming commented Sep 1, 2023

k8s-ci-robot commented Sep 1, 2023

wzshiming commented Sep 22, 2023

wzshiming Oct 7, 2023 •

edited

wzshiming commented Oct 7, 2023

k8s-ci-robot commented Oct 7, 2023

k8s-ci-robot commented Oct 7, 2023

wzshiming commented Oct 7, 2023

wzshiming commented Oct 11, 2023

wzshiming commented Oct 12, 2023

thockin Oct 14, 2023

wzshiming Oct 16, 2023

thockin left a comment

k8s-ci-robot commented Oct 19, 2023

k8s-ci-robot commented Oct 19, 2023

k8s-ci-robot commented Oct 20, 2023 •

edited

Promote KEP-2681 to beta in 1.29 #120257

Promote KEP-2681 to beta in 1.29 #120257

Conversation

wzshiming commented Aug 30, 2023 • edited

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot commented Aug 30, 2023

wzshiming commented Sep 1, 2023

k8s-ci-robot commented Sep 1, 2023

wzshiming commented Sep 22, 2023

wzshiming Oct 7, 2023 • edited

Choose a reason for hiding this comment

wzshiming commented Oct 7, 2023

k8s-ci-robot commented Oct 7, 2023

k8s-ci-robot commented Oct 7, 2023

wzshiming commented Oct 7, 2023

wzshiming commented Oct 11, 2023

wzshiming commented Oct 12, 2023

thockin Oct 14, 2023

Choose a reason for hiding this comment

wzshiming Oct 16, 2023

Choose a reason for hiding this comment

thockin left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Oct 19, 2023

k8s-ci-robot commented Oct 19, 2023

k8s-ci-robot commented Oct 20, 2023 • edited

wzshiming commented Aug 30, 2023 •

edited

wzshiming Oct 7, 2023 •

edited

k8s-ci-robot commented Oct 20, 2023 •

edited