[KEP-3751] introduce the VolumeAttributesClass API

[carlory]

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

Which issue(s) this PR fixes:

Part of kubernetes/enhancements#3751

Fixes #119297

Special notes for your reviewer:

based on #118863

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/3751-volume-attributes-class

[carlory]

/cc @msau42 @sunnylovestiramisu @xing-yang @gnufied @ConnorJC3

[carlory]

/retest

[jiahuif]

/assign @jpbetz
for API review. Thank you.
/triage accepted

[carlory]

Just a few wording suggestions.

Can you also squash your commits into 2? API changes + generated changes?

done.

/cc @msau42 @sunnylovestiramisu @jpbetz

[msau42]

unit test failure: #121627

[msau42]

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: cef5c945c350b501139606ae59f409d58eb264fa

[carlory]

/assign @deads2k

[carlory]

/assign @liggitt

[jpbetz]

/approve
For API Machinery related changes

[jpbetz]

@liggitt @deads2k Looks like we're down to needing approval for registry and printers. Would either of you be willing to serve as approver for those? Thanks!

[apelisse]

/approve
for printers.

[liggitt]

/approve
for registry package (which will fall under storage once #121210 merges anyway)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, carlory, jpbetz, liggitt, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• api/OWNERS [liggitt,msau42]
• pkg/api/OWNERS [liggitt,msau42]
• pkg/apis/OWNERS [liggitt,msau42]
• pkg/features/OWNERS [jpbetz,liggitt,msau42]
• pkg/generated/openapi/OWNERS [liggitt,msau42]
• pkg/kubeapiserver/OWNERS [jpbetz,liggitt]
• pkg/printers/OWNERS [apelisse,liggitt]
• pkg/registry/OWNERS [liggitt]
• pkg/volume/OWNERS [liggitt,msau42]
• staging/src/k8s.io/api/OWNERS [liggitt,msau42]
• staging/src/k8s.io/client-go/OWNERS [jpbetz,liggitt]
• test/integration/etcd/OWNERS [liggitt,msau42]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Priyankasaggu11929]

/retitle [KEP-3751] introduce the VolumeAttributesClass API

[dipan-db]

Hi, carlory:

Sorry to leave comment on your PR. I have a quick question would to ask for about how to generate this core/v1/generated.pb.go from go struct definition in core/v1/types.go file.

We have a use case that we define a CRD in go struct, and we need to generate the proto related methods for marshal/unmarshal. But we could not successfully generate them.

We are trying to use protoc-gen-gogo and go-to-protobuf, but could not make fully work.

Do you mind share what's the commands should be used to auto gen "core/v1/generated.proto" and "core/v1/generated.pb.go" files based on core/v1/types.go file?

Really appreciate your help and answers.

Di

[carlory]

the kubernetes repo provides a lot of useful scripts under the hack directory, I ran the make update to generate all necessary files in this pr. the CRD doesn't support protobuf, so I am wondering why you need use generated funcs to produce/consume proto format bytes. It cannot recongized by the kube-apiserver.