Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authz webhook matchcondition metrics #123611

Merged
merged 1 commit into from Mar 2, 2024

Conversation

ritazh
Copy link
Member

@ritazh ritazh commented Mar 1, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #123276

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kube-apiserver now reports the following metrics for authorization webhook match conditions:
- `apiserver_authorization_match_condition_evaluation_errors_total` counter metric labeled by authorizer type and name
- `apiserver_authorization_match_condition_exclusions_total` counter metric labeled by authorizer type and name
- `apiserver_authorization_match_condition_evaluation_seconds` histogram metric labeled by authorizer type and name

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-auth/3221-structured-authorization-configuration

/sig auth
/assign @liggitt @palnabarun @enj

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 1, 2024
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 1, 2024
@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 1, 2024
@palnabarun
Copy link
Member

/retest-required

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 1, 2024
@liggitt
Copy link
Member

liggitt commented Mar 1, 2024

There are no nodes that your pod can schedule to - check your requests, tolerations, and node selectors ((combined from similar events): 0/204 nodes are available: 17 Insufficient memory, 189 Insufficient cpu, 2 node(s) had untolerated taint

must be code freeze

/retest

@liggitt
Copy link
Member

liggitt commented Mar 1, 2024

/lgtm
/approve
/hold for ack from @enj or @palnabarun

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 1, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 847d12f91e782742d7e2eff6f0e5a8e2242612ba

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, ritazh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2024
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
Signed-off-by: Jordan Liggitt <liggitt@google.com>
Co-authored-by: Jordan Liggitt <liggitt@google.com>
@liggitt
Copy link
Member

liggitt commented Mar 1, 2024

/lgtm

/hold cancel
will take a post-merge review from @enj when he has time, but am unholding to unblock follow-up metric work

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 1, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b200031cbbcf4be5622260c8f96a8f3ca5f8e3b3

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 1, 2024

@ritazh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
check-dependency-stats da82c53 link false /test check-dependency-stats

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ritazh
Copy link
Member Author

ritazh commented Mar 2, 2024

/retest

@liggitt
Copy link
Member

liggitt commented Mar 2, 2024

unit test failure is #123632 (comment)

@k8s-ci-robot k8s-ci-robot merged commit 3e1da21 into kubernetes:master Mar 2, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Mar 2, 2024
@cici37 cici37 added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Apr 11, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add metrics for webhook matchConditions
6 participants