New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add authz webhook matchcondition metrics #123611
Conversation
/retest-required |
staging/src/k8s.io/apiserver/plugin/pkg/authorizer/webhook/webhook.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/apiserver/plugin/pkg/authorizer/webhook/webhook.go
Outdated
Show resolved
Hide resolved
must be code freeze /retest |
/lgtm |
LGTM label has been added. Git tree hash: 847d12f91e782742d7e2eff6f0e5a8e2242612ba
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, ritazh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
staging/src/k8s.io/apiserver/pkg/authorization/authorizerfactory/metrics.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Jordan Liggitt <liggitt@google.com> Co-authored-by: Jordan Liggitt <liggitt@google.com>
/lgtm /hold cancel |
LGTM label has been added. Git tree hash: b200031cbbcf4be5622260c8f96a8f3ca5f8e3b3
|
@ritazh: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
unit test failure is #123632 (comment) |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #123276
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig auth
/assign @liggitt @palnabarun @enj