fix error checking in kl.killPod within SyncPod

[zhifei92]

What type of PR is this?

/kind bug
/kind cleanup

What this PR does / why we need it:

fix error checking in kl.killPod within SyncPod: when kl.killPod returns nil, wait.Interrupted always returns false, nil, and SyncPod consequently returns — this is not the expected behavior. move it to the correct position

    if err := kl.killPod(ctx, pod, p, nil); err == nil {
        if wait.Interrupted(err) {
            return false, err
        }

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

refs #117412, hi @smarterclayton , could you review it for me, thx.

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Please note that we're already in Test Freeze for the release-1.30 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.30.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Apr 17 01:52:11 UTC 2024.

[k8s-ci-robot]

Hi @zhifei92. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhifei92
Once this PR has been reviewed and has the lgtm label, please assign derekwaynecarr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/kubelet/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[zhifei92]

/sig node

[bart0sh]

/triage accepted
/priority important-longterm
/ok-to-test
/release-note-none

@zhifei92 Thank you for your contribution! As this is a bugfix, please provide e2e test case to cover the issue.

[zhifei92]

/test pull-kubernetes-conformance-kind-ga-only-parallel

[zhifei92]

/retest

[zhifei92]

/retest-required

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 65f2d3b2700f059f4b2c58d96b6066648a292d7f

[zhifei92]

/assign @wojtek-t Please help review this.

[rphillips]

/lgtm

[zhifei92]

@derekwaynecarr hi, this PR needs an approval label, please help review it.

[zhifei92]

hi @rphillips @bart0sh do we need anyone's else review?

[bart0sh]

do we need anyone's else review?

As this pr already lgtm-ed, we need SIG-node approvers to take a look

/assign @mrunlap @derekwaynecarr @dchen1107
for approval

[k8s-ci-robot]

@bart0sh: GitHub didn't allow me to assign the following users: mrunlap.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

do we need anyone's else review?

As this pr already lgtm-ed, we need SIG-node approvers to take a look

/assign @mrunlap @derekwaynecarr @dchen1107
for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bart0sh]

/assign @mrunalp