Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CephRBD volume plugin and its csi migration support are removed #124546

Merged
merged 1 commit into from May 10, 2024

Conversation

carlory
Copy link
Member

@carlory carlory commented Apr 26, 2024

What type of PR is this?

/kind cleanup
/kind api-change
/kind deprecation

What this PR does / why we need it:

the CephRBD plugin and csi migration were deprecated in 1.28. In 1.31, we want to remove the support.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

ACTION REQUIRED:

CephRBD volume plugin ( `kubernetes.io/rbd`) was removed in this release. And its csi migration support was also removed, so the `rbd` volume type became non-functional. Alternative is to use RBD CSI driver (https://github.com/ceph/ceph-csi/) in your Kubernetes Cluster. A re-deployment of your application is required to use the new driver if you were using `kubernetes.io/rbd` volume plugin before upgrading cluster version to 1.31+.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 26, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Apr 26, 2024
@k8s-ci-robot k8s-ci-robot added area/kubelet area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 26, 2024
@carlory
Copy link
Member Author

carlory commented Apr 26, 2024

/cc @humblec @saad-ali @dims @jsafrane

#124519 want to remove the file cmd/kube-controller-manager/app/plugins_providers.go. that file is used to register some volume plugins for the kube-controller-manager. i.e. kubernetes.io/rbd is one of them.

In 1.31, we plan to remove the kubernetes.io/rbd support. so let's merge this PR before #124519. It's more reasonable.

@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@dims
Copy link
Member

dims commented Apr 26, 2024

/assign @msau42 @xing-yang

@dims
Copy link
Member

dims commented May 7, 2024

@carlory hit me up after rebase and the CI jobs are green please

@bart0sh bart0sh moved this from Triage to Needs Approver in SIG Node PR Triage May 8, 2024
@haircommander haircommander moved this from Triage to Archive-it in SIG Node CI/Test Board May 8, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2024
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 9, 2024
@carlory
Copy link
Member Author

carlory commented May 9, 2024

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label May 9, 2024
@carlory
Copy link
Member Author

carlory commented May 9, 2024

/retest

@carlory
Copy link
Member Author

carlory commented May 9, 2024

/test pull-kubernetes-e2e-kind-cloud-provider-loadbalancer

1 similar comment
@carlory
Copy link
Member Author

carlory commented May 9, 2024

/test pull-kubernetes-e2e-kind-cloud-provider-loadbalancer

@carlory
Copy link
Member Author

carlory commented May 10, 2024

Ping @dims, the unrequired job /test pull-kubernetes-e2e-kind-cloud-provider-loadbalancer always fails, I tested it on master branch and got same result #124776. #124729 is trying to fix it.

Do we need block this PR to be merged?

@dims
Copy link
Member

dims commented May 10, 2024

Do we need block this PR to be merged?

Not for this PR.

/approve
/lgtm
/skip

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ac4567120687ec2f775f36652ccf551cfb586f38

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, dims, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 10, 2024

@carlory: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-kind-cloud-provider-loadbalancer c8e91b9 link false /test pull-kubernetes-e2e-kind-cloud-provider-loadbalancer

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit df074ed into kubernetes:master May 10, 2024
21 checks passed
SIG Node CI/Test Board automation moved this from Archive-it to Done May 10, 2024
SIG Node PR Triage automation moved this from Needs Approver to Done May 10, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone May 10, 2024
@carlory carlory deleted the remove-rbd branch May 10, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Development

Successfully merging this pull request may close these issues.

None yet

9 participants