Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate csi migration for ceph rbd #118303

Merged

Conversation

carlory
Copy link
Member

@carlory carlory commented May 28, 2023

What type of PR is this?

/kind deprecation

What this PR does / why we need it:

Based on https://groups.google.com/g/kubernetes-sig-storage/c/h5751_B5LQM, the consensus was to start the deprecation in v1.28.

This commit start the deprecation process of RDB plugin from in-tree drivers.

kubernetes/enhancements#2923 (comment)

Does this PR introduce a user-facing change?

ACTION REQUIRED:
Deprecated support for CSI migration of Ceph RBD volumes.

Users who were relying on Kubernetes' ability to migrate to an out-of-tree storage driver should complete
that migration before the support for it is removed.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/2923-csi-migration-ceph-rbd 

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 28, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 28, 2023
@carlory
Copy link
Member Author

carlory commented May 28, 2023

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 28, 2023
@carlory carlory changed the title deprecate csi migration for ceph rdb deprecate csi migration for ceph rbd May 28, 2023
@carlory carlory force-pushed the deprecate-cephrdb-plugin-migration branch from cde771b to 8a80d35 Compare May 28, 2023 14:08
@carlory carlory force-pushed the deprecate-cephrdb-plugin-migration branch from 8a80d35 to 4e6d929 Compare May 29, 2023 00:35
@sftim
Copy link
Contributor

sftim commented May 31, 2023

What are we deprecating? The changelog isn't clear. Are we asking people not to migrate (deprecation means “please stop doing”)?

Maybe:

Deprecated support for CSI migration of Ceph RBD volumes.

Users who were relying on Kubernetes' ability to migrate to an out-of-tree storage driver should complete
that migration before the support for it is removed.

@carlory
Copy link
Member Author

carlory commented May 31, 2023

@sftim thanks for your comment. It's updated now.

@humblec
Copy link
Contributor

humblec commented Jul 3, 2023

/lgtm from rbd pov
cc @xing-yang

@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fa6065465c39cb8c0591971617f0652bbfbf088c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7472634 into kubernetes:master Jul 14, 2023
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 14, 2023
@humblec
Copy link
Contributor

humblec commented Jul 16, 2023

Thanks @xing-yang 👍

@xing-yang
Copy link
Contributor

xing-yang commented Aug 11, 2023

@carlory @humblec I think we need to add "ACTION REQUIRED: " in the release notes.

@humblec
Copy link
Contributor

humblec commented Aug 11, 2023

@xing-yang true. @carlory can you please add ACTION required as I have done @ #118552

@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 11, 2023
@carlory
Copy link
Member Author

carlory commented Aug 11, 2023

@xing-yang updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants