dependencies: ginkgo v2.19.0, gomega v1.33.1 #125045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
With ginkgo-e2e.sh from master and pull-kubernetes-e2e-kind as example, I see no output after "Running in parallel across 25 processes" for over 10 minutes, giving the wrong impression that the job is stuck. With the modified ginkgo-e2e.sh in the second commit, ginkgo runs with |
pohly
force-pushed
the
ginkgo-gomega-update
branch
from
a573618
to
0506086
Compare
|
:-/ Direct Dependencies: 187
-Transitive Dependencies: 328
-Total Dependencies: 368
+Transitive Dependencies: 334
+Total Dependencies: 374
Max Depth Of Dependencies: 19
All dependencies: |
k8s-ci-robot
removed
the
lgtm
pohly
changed the title
|
While this PR was pending, @onsi added added better support for the Kubernetes E2E labels to v2.19.0. I included that update in this PR, hence the loss of the LGTM. |
|
/approve share the same concern from Jordan above - #125045 (comment) |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 664111d74624e69ddcb21af0379d28be71b1c181
|
|
need one final approval from you @liggitt PTAL. thanks! |
pohly
force-pushed
the
ginkgo-gomega-update
branch
from
3ed1de6
to
3de7e44
Compare
k8s-ci-robot
removed
the
lgtm
Ginkgo v2.18.0 allows tweaking the output so that it's easier to follow while a job runs in Prow (onsi/ginkgo#1347). Using this in hack/ginkgo-e2e.sh will follow in a separate commit. Gomega gets bumped to the latest release to keep it up-to-date. Ginkgo v1.19.0 adds support for --label-filter with labels that represent sets (like our Feature:<Foo>).
We typically have plenty of skipped tests in an E2E run, which causes Ginkgo to print many S characters (one for each skipped test). This easily fills up an entire console window. Now the default is to silence that output. GINKGO_SILENCE_SKIPS=n reverts to the previous behavior. By default, Ginkgo prints all progress characters (S and o) in a single line. Buffering in Prow causes that output to occur only after the run is over, which defeats the purpose of having those characters. Now a newline is added after each character, so there is visible progress in Prow while Ginkgo runs.
pohly
force-pushed
the
ginkgo-gomega-update
branch
from
3de7e44
to
f3adf49
Compare
|
/retest |
|
@liggitt : I updated the PR to not have the undesirable dependencies. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 632025c29dbe1b65156a77be1664d1dc6ce3f8a0
|
k8s-ci-robot
added
the
approved
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
This was referenced Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The most interesting aspect of the new Ginkgo is tweaking the output so that it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in hack/ginkgo-e2e.sh is included in a separate commit.
Gomega gets bumped to the latest release to keep it up-to-date.
While this PR was pending, @onsi added added better support for the Kubernetes E2E labels to v2.19.0.
Which issue(s) this PR fixes:
Related-to: onsi/ginkgo#1347
Special notes for your reviewer:
Does this PR introduce a user-facing change?