Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Job resource #12910

Merged
merged 1 commit into from Sep 11, 2015
Merged

New Job resource #12910

merged 1 commit into from Sep 11, 2015

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Aug 19, 2015

I'm adding new job resource as defined in #11746. I picked up the initial changes from #7380, but per @erictune suggestion I'm placing the new object in expapi.

@smarterclayton @derekwaynecarr @sdminonne @akaram @bprashanth fyi

@k8s-bot
Copy link

k8s-bot commented Aug 19, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@soltysh soltysh mentioned this pull request Aug 19, 2015
@pmorie
Copy link
Member

pmorie commented Aug 19, 2015

@k8s-bot ok to test

On Wednesday, August 19, 2015, Kubernetes Bot notifications@github.com
wrote:

Can one of the admins verify that this patch is reasonable to test? (reply
"ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.


Reply to this email directly or view it on GitHub
#12910 (comment)
.

@k8s-bot
Copy link

k8s-bot commented Aug 19, 2015

GCE e2e build/test failed for commit e9694a22b32bb2b4d881fb1fd8213438c3c0f40e.

@k8s-bot
Copy link

k8s-bot commented Aug 20, 2015

GCE e2e build/test failed for commit bfb5cffdc21f9c3e2501009f39ca20ef9080a88d.

@k8s-bot
Copy link

k8s-bot commented Aug 20, 2015

GCE e2e build/test failed for commit b24ad73d32ada6f39f3891cd64abfa8b273a428c.

@soltysh
Copy link
Contributor Author

soltysh commented Aug 21, 2015

I think I've reached a state where I can focus entirely on the controller logic, and that's the plan for the next few days.

@k8s-bot
Copy link

k8s-bot commented Aug 21, 2015

GCE e2e build/test failed for commit 8d9777a2a1f6bad79971938f8b632c239fa8ff2e.

@j3ffml
Copy link
Contributor

j3ffml commented Aug 21, 2015

I am not familiar enough with these components to be a useful reviewer. Reassigning to @davidopp to review/redirect.

@davidopp
Copy link
Member

Assigning to @erictune who has been shepherding the job controller work.

@k8s-bot
Copy link

k8s-bot commented Aug 24, 2015

GCE e2e build/test passed for commit 6af2890719b329b5fcaf70ebb74156708f4ea1c2.

@soltysh soltysh changed the title [WIP] - New Job resource New Job resource Aug 25, 2015
@soltysh
Copy link
Contributor Author

soltysh commented Aug 25, 2015

@erictune after talking to @smarterclayton I've decided to split the work into two separate PRs to simplify the reviews. This one contains the new job resource, validation, generated stuff and storage (1st commit). The 2nd commit contains the client API for jobs. The controller part will be in a separate PR. Does it make sense or should I split it more?

@k8s-github-robot k8s-github-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 11, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/XL

@soltysh
Copy link
Contributor Author

soltysh commented Sep 11, 2015

Rebased, tests should be ok now. For the record, previous commit with @smarterclayton comments was soltysh@3ab923f

@k8s-bot
Copy link

k8s-bot commented Sep 11, 2015

GCE e2e build/test passed for commit 067f96514c4309fc081f7ae3224e76223d62f26c.

@k8s-bot
Copy link

k8s-bot commented Sep 11, 2015

GCE e2e build/test passed for commit 08fbc3126ebfeb01c0fb8a64af1a4b82ad8ff2f6.

@erictune
Copy link
Member

LGTM

@erictune
Copy link
Member

Please squash commits.

@soltysh
Copy link
Contributor Author

soltysh commented Sep 11, 2015

Squashed.

@k8s-bot
Copy link

k8s-bot commented Sep 11, 2015

GCE e2e build/test passed for commit e55c59e.

@erictune erictune added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-merge labels Sep 11, 2015
@k8s-github-robot
Copy link

Continuous integration appears to have missed, closing and re-opening to trigger it

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Sep 11, 2015

GCE e2e build/test passed for commit e55c59e.

@k8s-github-robot
Copy link

Automatic merge from SubmitQueue

k8s-github-robot pushed a commit that referenced this pull request Sep 11, 2015
@k8s-github-robot k8s-github-robot merged commit bafa762 into kubernetes:master Sep 11, 2015
@karlkfi
Copy link
Contributor

karlkfi commented Sep 11, 2015

@soltysh I see this got merged without docs changes. Are those gonna be part of #13254? Not sure where experimental APIs get documented, but we should figure it out.

@erictune
Copy link
Member

@karlkfi It seems we do not do automatic generation of static docs for experimental api group. We should. Filed #13883 for that.

@karlkfi
Copy link
Contributor

karlkfi commented Sep 11, 2015

I was thinking more like a user-guide section for the new API/resource, but yes, those too.

@soltysh
Copy link
Contributor Author

soltysh commented Sep 14, 2015

@erictune thanks
@karlkfi I'll be adding samples as a separate PR to current ones. These are already quite big, I don't won't to clutter them more. I'll tag you in one.

@soltysh soltysh deleted the job_controller branch September 16, 2015 10:23
@erictune erictune added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller-manager lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants