Kubelet serialize image pulls had incorrect default #16749
Conversation
|
Labelling this PR as size/XS |
k8s-github-robot
added
the
size/XS
| @@ -129,7 +129,7 @@ kubelet | |||
| --rkt-stage1-image="": image to use as stage1. Local paths and http/https URLs are supported. If empty, the 'stage1.aci' in the same directory as '--rkt-path' will be used | |||
| --root-dir="/var/lib/kubelet": Directory path for managing kubelet files (volume mounts,etc). | |||
| --runonce[=false]: If true, exit after spawning pods from local manifests or remote urls. Exclusive with --api-servers, and --enable-server | |||
| --serialize-image-pulls[=false]: Pull images one at a time. We recommend *not* changing the default value on nodes that run docker daemon with version < 1.9 or an Aufs storage backend. Issue #10959 has more details. [default=true] | |||
| --serialize-image-pulls[=true]: Pull images one at a time. We recommend *not* changing the default value on nodes that run docker daemon with version < 1.9 or an Aufs storage backend. Issue #10959 has more details. [default=true] | |||
There was a problem hiding this comment.
I think we should drop the [default=true] portion, since that can be wrong... (that gets removed back in the flag definition)
There was a problem hiding this comment.
Just like it was wrong here. The default was false but the description lied and said it was true. The default values of flags are already shown. Notice how that part of the doc was updated when he fixed it, but the little lying string at the end didn't change (well I guess it stopped lying)
|
GCE e2e test build/test passed for commit b403e30. |
|
Thanks for the fix @derekwaynecarr! Good catch! LGTM. |
vishh
added
the
lgtm
|
@derekwaynecarr Thanks for fixing this! The default value is only setting to SimpleKubelet, not real one in the original pr. :-( LGTM |
|
I manually merged this pr since all tests passed except shippable. Shippable is not running for hours. |
|
cc/ @vishh Please cherry pick this pr to 1.1 branch. Thanks! |
Kubelet serialize image pulls had incorrect default
…upstream-release-1.1 Automated cherry pick of #16749
…of-#16749-upstream-release-1.1 Automated cherry pick of kubernetes#16749
…of-#16749-upstream-release-1.1 Automated cherry pick of kubernetes#16749
please review @vishh @dchen1107 @smarterclayton @liggitt
The default should have been
trueas documented.