Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Close() in streaming decoder #24915

Merged

Conversation

wojtek-t
Copy link
Member

[This would be useful for changes in clients to support protobufs.]

@wojtek-t wojtek-t added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 28, 2016
@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 28, 2016
@wojtek-t wojtek-t force-pushed the read_closer_in_streaming_decoder branch from cba84a7 to 3175d18 Compare April 28, 2016 07:46
@smarterclayton
Copy link
Contributor

LGTM

@smarterclayton
Copy link
Contributor

@k8s-bot test this issue #24905 "should be updated when static pod updated"

@smarterclayton smarterclayton added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2016
@smarterclayton
Copy link
Contributor

@k8s-bot test this issue #24937

1 similar comment
@smarterclayton
Copy link
Contributor

@k8s-bot test this issue #24937

@wojtek-t wojtek-t added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Apr 29, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Apr 29, 2016

GCE e2e build/test passed for commit 3175d18.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit c0fca43 into kubernetes:master Apr 29, 2016
@wojtek-t wojtek-t deleted the read_closer_in_streaming_decoder branch May 17, 2016 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants