kubelet: Optionally, have kubelet exit if lock file contention is observed, using --exit-on-lock-contention flag #25596

derekparker · 2016-05-13T22:57:26Z

This patch adds the --bootstrap flag, which must be used in conjunction
with the --lock-file flag. When provided, it causes the kubelet to wait
for inotify events for that lock file. When an 'open' event is received,
the kubelet will exit.

This patch implements the proposal at #23343.

k8s-bot · 2016-05-13T22:58:09Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

k8s-bot · 2016-05-13T22:58:23Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

derekparker · 2016-05-13T22:58:28Z

cc: @vishh @aaronlevy

Happy to add test for this, and would appreciate being pointed in the right direction there (I assume e2e).

k8s-bot · 2016-05-13T22:59:10Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

derekparker · 2016-05-13T23:00:26Z

Also, cc: @dchen1107 @mikedanese

vishh · 2016-05-13T23:18:26Z

ok to test

philips · 2016-05-14T10:04:57Z

Adding cc for @derekwaynecarr as he was on the original proposal review on #23343.

gabrtv · 2016-05-15T20:37:00Z

👍 Really hoping this lands in 1.3..

aaronlevy · 2016-05-16T17:38:10Z

cmd/kubelet/app/options/options.go

@@ -220,6 +221,7 @@ func (s *KubeletServer) AddFlags(fs *pflag.FlagSet) {
 	fs.StringVar(&s.CgroupRoot, "cgroup-root", s.CgroupRoot, "Optional root cgroup to use for pods. This is handled by the container runtime on a best effort basis. Default: '', which means use the container runtime default.")
 	fs.StringVar(&s.ContainerRuntime, "container-runtime", s.ContainerRuntime, "The container runtime to use. Possible values: 'docker', 'rkt'. Default: 'docker'.")
 	fs.StringVar(&s.LockFilePath, "lock-file", s.LockFilePath, "<Warning: Alpha feature> The path to file for kubelet to use as a lock file.")
+	fs.BoolVar(&s.Bootstrap, "bootstrap", s.Bootstrap, "Whether kubelet should exit upon lock-file contention during bootstrap.")


Wondering if it might be better to have a more specific name for this flag. --bootstrap is a bit generic, where maybe something along the lines of --exit-on-lock-contention would be more descriptive of the use/functionality.

I agree with this, the flag name isn't very clear to somebody looking at it for the first time. Definitely up for suggestions, and I wouldn't mind what you've suggested @aaronlevy.

+1 on renaming the flag. The word bootstrap is confusing even in the description.

derekparker · 2016-05-17T23:15:22Z

@vishh @dchen1107 can I get a review on this, please? CI is happy.

vishh · 2016-05-18T17:58:48Z

cmd/kubelet/app/server_linux.go

+
+import (
+	"github.com/golang/glog"
+	"golang.org/x/exp/inotify"


Have you looked at https://github.com/fsnotify/fsnotify? I believe it works across OSes.

I did, but it does not contain the "open" event, so I went with inotify instead, which was already vendored. https://github.com/fsnotify/fsnotify/blob/master/fsnotify.go#L25

vishh · 2016-05-18T18:01:24Z

cmd/kubelet/app/server_unsupported.go

+import "errors"
+
+func watchForLockfileContention(path string, done chan struct{}) error {
+	return errors.New("kubelet unsupported in this build")


We need kubelet to build and run across different platforms. So we need a stub for features that are OS dependent.

Yeah, that's why I added this file/function. To enable kubelet to build across platforms. Did you want something more than this?

Won't this implementation make the kubelet exit right away when run on OSX?

Yes, if this flag was supplied, but the kubelet doesn't actually work correctly on OSX, correct?

We support development on OSX to some extent. So we want integration tests
to function on OSX.

On Wed, May 18, 2016 at 3:57 PM, Derek Parker notifications@github.com
wrote:

In cmd/kubelet/app/server_unsupported.go
#25596 (comment)
:

http://www.apache.org/licenses/LICENSE-2.0

+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package app
+
+import "errors"
+
+func watchForLockfileContention(path string, done chan struct{}) error {

return errors.New("kubelet unsupported in this build")

Yes, if this flag was supplied, but the kubelet doesn't actually work
correctly on OSX, correct?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/kubernetes/kubernetes/pull/25596/files/46ddb9c0dd62d6ad34e9dcf8e3c8ff5d62fac4d2#r63797541

This shouldn't effect the integration tests then, at least, as none of them should hit this code path.

vishh · 2016-05-18T18:02:22Z

Just a couple of comments. Overall LGTM.

derekparker · 2016-05-18T21:46:53Z

@vishh updated PR based on feedback, ready for another round of review. Main change is updating the flag name.

derekparker · 2016-05-18T23:07:24Z

Added handling for IN_DELETE_SELF event.

vishh · 2016-05-18T23:16:11Z

LGTM

derekparker · 2016-05-18T23:18:43Z

@vishh need me to squash this?

derekparker · 2016-05-18T23:20:52Z

Squashed.

vishh · 2016-05-18T23:21:34Z

@derekparker While you are at it, can you update the commit to include the updated flag name?

This patch adds the --exit-on-lock-contention flag, which must be used in conjunction with the --lock-file flag. When provided, it causes the kubelet to wait for inotify events for that lock file. When an 'open' event is received, the kubelet will exit.

derekparker · 2016-05-18T23:22:58Z

@vishh done.

k8s-bot · 2016-05-19T00:01:36Z

GCE e2e build/test passed for commit f307e97.

I have 140 commits in this directory and I get a lot of cleanup reviews and want to be able to approve changes to hack/.golint_failures. 0e69316 delete unused cache b9c7007 enable token review when openapi is generated d5bbc35 make deps-approvers the approvers of sample-cli-plugin/Godeps 4186abf bzl: fix update-bazel.sh 7b47229 remove deprecated /proxy paths b973840 gke-certificates-controller: rm -rf 4961065 cluster: remove unused functions 1e2b644 cluster: move logging library to hack/ bef68f7 cluster: build gci mounter like other go binaries fe7ba9e kubeadm: use kubelet bootstrap instead of reimplementing 3c39173 fixit: break sig-cluster-lifecycle tests into subpackage 64f77eb enable race detection on integration tests cdcfa35 promote tls-bootstrap to beta ff4a814 migrate set generation to go genrule 3600d49 delete benchmark integration tests that don't work at all 21617a6 don't use build tags to mark integration tests 59fc948 bump rules_go and go version for bazel builds ba5c285 bazel: implement git build stamping ad42b42 move kubeadm api group testing to kubeadm package c8ce55f Revert "Merge pull request kubernetes#41132 from kubernetes/revert-40893-kubelet-auth" cbe5bd9 bump gazel to v14 86d9493 remove second CA used for kubelet auth in favor of webhook auth 04a7880 update repo local config to allow redirects from gopkg.in 44b7246 autogenerated 96c146c promote certificates.k8s.io to beta 087016d update gazel to v8 837eee4 pin gazel to v3 e225625 add a configuration for kubelet to register as a node with taints 584689f implement kubectl procelain csr commands 93f737e fix verify-bazel.sh on mac and windows 5dc7554 bazel: implement set-gen as a bazel genrule 61bd6aa remove docs/user-guide from bindata search path 224e32b make godep licenses/copyright check case insensitive 1cd2968 godep: vendor go-bindata d380cb1 fix realpath issue on mac ea632fa Revert "disable bazel build" 27116c6 rename build/ to build-tools/ ee15c80 disable bazel build 999c967 ignore BUILD in the flags-underscore.py validation b250a88 don't check BUILD file when verifying godeps a2eec91 add bazel presubmits to verify BUILD files are up to date c17a8a7 kubectl: apply prune should fallback to basic delete when a resource has no reaper 25e4dcc kubeadm: fix conversion macros and add kubeadm to round trip testing 6d17a87 kubectl: add two more test of kubectl apply --prune 62960aa add a test for kubectl apply --prune 6339d91 add a test to test-cmd.sh for apply -f with label selector b421bf4 build kube-discovery and kubeadm with release 0c76cf5 fix hack/verify-codegen.sh 9f379df add an option to controller-manager to auto approve all CSRs 95e2e29 move kube-dns to the cluster/addons/ directory f3de21b move integration tests into individual pacakges af0177e cleanup hack/verify-govet.sh to throttle process creation 2c93ea5 Merge pull request kubernetes#27289 from mikedanese/split-verify ee34c76 split verify out of unit/integration suite d046275 now that go test runs iteration loops, use that instead of custom executor 1ef1906 Merge pull request kubernetes#26197 from wonderfly/update_default_master_image fbf6bbc Merge pull request kubernetes#25596 from derekparker/inotify 3e1c0b5 run kube-addon-manager in a pod c5cc0c3 Merge pull request kubernetes#24277 from ihmccreery/upgrade-timeout 132c427 add linux fastbuild option to ./build/release.sh 2857baa use defaults in test-dockerized for etcd prefix and api versions 695211e Merge pull request kubernetes#21105 from caesarxuchao/watchCacheForIntegration 2172e0d Merge pull request kubernetes#21108 from mml/slow-flake 1478cf3 Merge pull request kubernetes#21090 from ihmccreery/feature-reboot b3172a4 kubelet: add a pidfile b1743a6 this is a manual reversion of kubernetes#20702 5b27055 Merge pull request kubernetes#19378 from ihmccreery/remove-update-jobs b743827 Merge pull request kubernetes#19659 from ihmccreery/timeout-reboot a6589f7 hack: ignore cluster/env.sh in boilerplate check f71657d retrofit the scheduler with the leader election client. bf763bb Merge pull request kubernetes#19498 from pwittrock/nodelabels 22cfa5e build: move some of hack/lib/ into a new cluster/lib/ b174fc9 Merge pull request kubernetes#18994 from bprashanth/flannel_suite a09d85b expose master count configuration in a cli option on apiserver c2753d7 bump ci go version to 1.5.2 0655e65 fall back to old behavior when deciding mem availablity during build 1d9d11c run kube-proxy in a static pod 91de3a1 cleanup some nits in hack/get-build.sh cd79c6c fix unbound variable error in hace/get-build.sh 5e64590 renable enable var to correct name and only use it when needed 9bdb860 add apigroup installer and tests e6d3b47 add componentconfig api group to autogen stuff 88008de Merge pull request kubernetes#16459 from mikedanese/enable-exp d28d134 Merge pull request kubernetes#16533 from ihmccreery/upgrade-test-fixes 3343522 enable deployment and daemonset in gce upgrade tests 7cbf249 Merge pull request kubernetes#15836 from wojtek-t/codecgen_from_godeps 92404e7 add upgrade test between 1.0 and 1.1 for gce 95b8394 Merge pull request kubernetes#15861 from mikedanese/upgrade-num-minion ece5779 increase NUM_MINIONS for jenkins gce upgrade test b8b35af actually promote daemonset simple test out of flaky and skip all daemonset tests in gke d379a36 copy directory not contents of directory 402e68e add slow test for terminated pod garbage collection c0943f1 add intermediate e2e runs to gce upgrade 10d56ff promote simple daemonset test out of flaky b635fc5 Merge pull request kubernetes#15228 from mesosphere/sttts-conformance-tags 392f33e Merge pull request kubernetes#14054 from mikedanese/register-master fa60bbe add flag to kubelet to ignore the cidr passed down by the apiserver on the master 53e14c7 diff all of pkg/ when verifying swagerspec instead of just pkg/api/ 05ef8ed Merge pull request kubernetes#15104 from mikedanese/ds-e2e fe820fc break up daemonset test into two tests 833be48 enable all experimental flags with one controller 905e971 be explicit about minion group size in upgrade test ae7d3d5 add gce-upgrade to jenkins/e2e.sh 376faea add pod garbage collection b0457be Merge pull request kubernetes#13058 from mvdan/go1.5 a48f218 Merge pull request kubernetes#13754 from tummychow/labels-deps 1fec199 Merge pull request kubernetes#13824 from kubernetes/revert-13547-hpa-kubeup fa40ced move contrib/for-tests to test/images f061875 updating all references in .sh scripts 8326697 rewrite all links to prs to k8s links fb02b33 fix build 8e48431 Revert "demote to flaky tests from parallel e2e" b56edd1 Merge pull request kubernetes#11727 from ZJU-SEL/build-nonstatic-hyperkube cf4cb1a Merge pull request kubernetes#10474 from kargakis/scale-multiple-controllers e376a09 demote to flaky service tests from parallel e2e 7c47d6b Merge pull request kubernetes#12009 from smarterclayton/fix_cmd_config 0269e2b Merge pull request kubernetes#11941 from GoogleCloudPlatform/enact_version_md 94a387d Revert "Improve conversion to support multiple packages" 1a613c4 Merge pull request kubernetes#9971 from smarterclayton/make_conversion_more_flexible 0ae48c4 Merge pull request kubernetes#11927 from wojtek-t/remove_shell_services 59a1dd4 Merge pull request kubernetes#11789 from mbforbes/nodesNetwork 6294070 Merge pull request kubernetes#11803 from wojtek-t/move_back_from_flaky daa6d4d Merge pull request kubernetes#11285 from liggitt/ca 9f16fd9 Merge pull request kubernetes#11860 from ingvagabund/delimiter-for-X-option-eparis c0acfbc Merge pull request kubernetes#11421 from nikhiljindal/exposeServcPort ae1c8e5 Merge pull request kubernetes#11737 from thockin/cleanup-remove-v1beta3 01ee1b8 Merge pull request kubernetes#10840 from jbeda/master d4d99de make mungedoc exit 1 if manual changes are needed and wire up erro message. 337772a fix all tests 055115a fake realpath, and standardize treatment of trailing / of dirs in gendoc b4514ee fix run-gendocs to point to new repo location c053b9a add documentation and script on how to get recent and "nightly" builds 719870f add publishing of latest-green.txt to jenkins e2e tests on success 1e130e0 remove --machines from code and docs dbb47fe remove e2e run before cluster upgrade de55e17 e2e test cluster stability during upgrade c9fcf45 fix bad cmd-test for patch. 9f91532 fix error where we can't use patch and add cmd-test for patch and file update

googlebot added the cla: yes label May 13, 2016

derekparker mentioned this pull request May 13, 2016

kubelet: Allow runonce mode to contact apiserver #23074

Closed

k8s-github-robot assigned dchen1107 May 13, 2016

k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/old-docs size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 13, 2016

derekparker force-pushed the inotify branch from c3cbeca to b6c3a59 Compare May 13, 2016 23:11

vishh assigned vishh and unassigned dchen1107 May 13, 2016

philips mentioned this pull request May 14, 2016

docs: Self-hosted Kubelet proposal #23343

Merged

aaronlevy reviewed May 16, 2016
View reviewed changes

derekparker force-pushed the inotify branch 4 times, most recently from cd1ec11 to f482824 Compare May 17, 2016 20:19

k8s-github-robot added the needs-ok-to-merge label May 17, 2016

vishh reviewed May 18, 2016
View reviewed changes

vishh added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels May 18, 2016

vishh changed the title ~~kubelet: Add --bootstrap flag~~ kubelet: Optionally, have kubelet exit if lock file contention is observed, using --bootstrap flag May 18, 2016

vishh added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-merge labels May 18, 2016

vishh added this to the v1.3 milestone May 18, 2016

derekparker force-pushed the inotify branch from 7c85d79 to eb1d1e1 Compare May 18, 2016 23:20

vishh changed the title ~~kubelet: Optionally, have kubelet exit if lock file contention is observed, using --bootstrap flag~~ kubelet: Optionally, have kubelet exit if lock file contention is observed, using --exit-on-lock-file-contention flag May 18, 2016

vishh changed the title ~~kubelet: Optionally, have kubelet exit if lock file contention is observed, using --exit-on-lock-file-contention flag~~ kubelet: Optionally, have kubelet exit if lock file contention is observed, using --exit-on-lock-contention flag May 18, 2016

derekparker force-pushed the inotify branch from eb1d1e1 to f307e97 Compare May 18, 2016 23:22

yifan-gu removed the needs-ok-to-merge label May 18, 2016

k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2016

vishh added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2016

mikedanese merged commit fbf6bbc into kubernetes:master May 20, 2016

mikedanese mentioned this pull request Feb 4, 2020

add myself to hack/OWNERS #87826

Merged

derekwaynecarr mentioned this pull request Oct 8, 2020

Moving lock related flags to Kubelet configuration #91877

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kubelet: Optionally, have kubelet exit if lock file contention is observed, using --exit-on-lock-contention flag #25596

kubelet: Optionally, have kubelet exit if lock file contention is observed, using --exit-on-lock-contention flag #25596

derekparker commented May 13, 2016

k8s-bot commented May 13, 2016

k8s-bot commented May 13, 2016

derekparker commented May 13, 2016

k8s-bot commented May 13, 2016

derekparker commented May 13, 2016

vishh commented May 13, 2016

philips commented May 14, 2016

gabrtv commented May 15, 2016

aaronlevy May 16, 2016

derekparker May 16, 2016

vishh May 18, 2016

derekparker commented May 17, 2016

vishh May 18, 2016

derekparker May 18, 2016

vishh May 18, 2016

vishh May 18, 2016

derekparker May 18, 2016

vishh May 18, 2016

derekparker May 18, 2016

vishh May 18, 2016

derekparker May 18, 2016

vishh commented May 18, 2016

derekparker commented May 18, 2016

derekparker commented May 18, 2016

vishh commented May 18, 2016

derekparker commented May 18, 2016

derekparker commented May 18, 2016

vishh commented May 18, 2016

derekparker commented May 18, 2016

k8s-bot commented May 19, 2016

kubelet: Optionally, have kubelet exit if lock file contention is observed, using --exit-on-lock-contention flag #25596

kubelet: Optionally, have kubelet exit if lock file contention is observed, using --exit-on-lock-contention flag #25596

Conversation

derekparker commented May 13, 2016

k8s-bot commented May 13, 2016

k8s-bot commented May 13, 2016

derekparker commented May 13, 2016

k8s-bot commented May 13, 2016

derekparker commented May 13, 2016

vishh commented May 13, 2016

philips commented May 14, 2016

gabrtv commented May 15, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

derekparker commented May 17, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vishh commented May 18, 2016

derekparker commented May 18, 2016

derekparker commented May 18, 2016

vishh commented May 18, 2016

derekparker commented May 18, 2016

derekparker commented May 18, 2016

vishh commented May 18, 2016

derekparker commented May 18, 2016

k8s-bot commented May 19, 2016