[DO NOT MERGE] fix apply issue

[adohe-zz]

Please note this is not a final PR. Just open this for a discussion.

When we use kubectl apply to create resource, we update the annotation, add the last-applied-configuration. But this last-applied-configuration is not the real configuration we used to create the resource, it's just read from the command input. e.g:

Create a deployment with apply -f:

[tony@localhost kubernetes]$ cluster/kubectl.sh apply -f nginx-dpl.yaml
deployment "nginx-deployment" created
[tony@localhost kubernetes]$ cat nginx-dpl.yaml
apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  name: nginx-deployment
spec:
  replicas: 1
  template:
    metadata:
      labels:
        app: nginx
        test: abcd
    spec:
      containers:
      - name: nginx
        image: nginx:1.7.9
        ports:
        - containerPort: 80

The last-applied-configuration would be:

{

    "kind":"Deployment",
    "apiVersion":"extensions/v1beta1",
    "metadata":{
        "name":"nginx-deployment",
        "creationTimestamp":null
    },
    "spec":{
        "replicas":1,
        "template":{
            "metadata":{
                "creationTimestamp":null,
                "labels":{
                    "app":"nginx",
                    "test":"abcd"
                }
            },
            "spec":{
                "containers":[
                    {
                        "name":"nginx",
                        "image":"nginx:1.7.9",
                        "ports":[
                            {
                                "containerPort":80
                            }
                        ],
                        "resources":{
                        }
                    }
                ]
            }
        },
        "strategy":{
        }
    },
    "status":{
    }

}

but the real configuration sent to apiserver would be:

{

    "kind":"Deployment",
    "apiVersion":"extensions/v1beta1",
    "metadata":{
        "name":"nginx-deployment",
        "namespace":"default",
        "creationTimestamp":null,
        "labels":{
            "app":"nginx",
            "test":"abcd"
        },
        "annotations":{
            "kubectl.kubernetes.io/last-applied-configuration":"{\"kind\":\"Deployment\",\"apiVersion\":\"extensions/v1beta1\",\"metadata\":{\"name\":\"nginx-deployment\",\"creationTimestamp\":null},\"spec\":{\"replicas\":1,\"template\":{\"metadata\":{\"creationTimestamp\":null,\"labels\":{\"app\":\"nginx\",\"test\":\"abcd\"}},\"spec\":{\"containers\":[{\"name\":\"nginx\",\"image\":\"nginx:1.7.9\",\"ports\":[{\"containerPort\":80}],\"resources\":{}}]}},\"strategy\":{}},\"status\":{}}"
        }
    },
    "spec":{
        "replicas":1,
        "selector":{
            "matchLabels":{
                "app":"nginx",
                "test":"abcd"
            }
        },
        "template":{
            "metadata":{
                "creationTimestamp":null,
                "labels":{
                    "app":"nginx",
                    "test":"abcd"
                }
            },
            "spec":{
                "containers":[
                    {
                        "name":"nginx",
                        "image":"nginx:1.7.9",
                        "ports":[
                            {
                                "containerPort":80,
                                "protocol":"TCP"
                            }
                        ],
                        "resources":{
                        },
                        "terminationMessagePath":"/dev/termination-log",
                        "imagePullPolicy":"IfNotPresent"
                    }
                ],
                "restartPolicy":"Always",
                "terminationGracePeriodSeconds":30,
                "dnsPolicy":"ClusterFirst",
                "securityContext":{
                }
            }
        },
        "strategy":{
            "type":"RollingUpdate",
            "rollingUpdate":{
                "maxUnavailable":1,
                "maxSurge":1
            }
        }
    },
    "status":{
    }

}

The last-applied-configuration annotation has no fields which we set by default. I think this has leads some bugs for apply usage.

[k8s-bot]

GCE e2e build/test failed for commit 36ee8f3.

• Build Log
• Test Artifacts
• Internal Jenkins Results

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

[bgrant0607]

We shouldn't touch this annotation in the server at the moment.

[bgrant0607]

Thanks, @adohe, but I'm closing this for now, since it's not the right approach.

[lavalamp]

@adohe Background info: not including the defaults is actually quite important to be able to compute a diff of what the user is intending to change. If you include defaults, it may appear that the user is trying to clear fields that the user actually has no opinion about.