Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up test, by not running with custom etcd prefix #26416

Merged
merged 1 commit into from
May 27, 2016
Merged

Speed up test, by not running with custom etcd prefix #26416

merged 1 commit into from
May 27, 2016

Conversation

wojtek-t
Copy link
Member

Ref #25940

Since we don't test upgrades or stuff like that in unit tests & integration tests, it doesn't make much sense to test different etcd prefixes.

@ixdy

@wojtek-t wojtek-t added release-note-none Denotes a PR that doesn't merit a release note. and removed cla: yes labels May 27, 2016
@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 27, 2016
@wojtek-t
Copy link
Member Author

@kubernetes/sig-api-machinery

@k8s-bot
Copy link

k8s-bot commented May 27, 2016

GCE e2e build/test failed for commit 19ccbb9.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@wojtek-t
Copy link
Member Author

@k8s-bot e2e test this please github issue: #26210

@wojtek-t
Copy link
Member Author

@lavalamp @ixdy This PR saves 10-15 minutes when running unit/integration tests.

@wojtek-t wojtek-t mentioned this pull request May 27, 2016
Closed
@smarterclayton
Copy link
Contributor

Lgtm - I agree that we are not testing upgrades / behavior effectively with this.

@smarterclayton smarterclayton added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. lgtm "Looks good to me", indicates that a PR is ready to be merged. e2e-not-required labels May 27, 2016
@ncdc
Copy link
Member

ncdc commented May 27, 2016

💯 👏

@k8s-bot
Copy link

k8s-bot commented May 27, 2016

GCE e2e build/test passed for commit 19ccbb9.

@wojtek-t wojtek-t assigned smarterclayton and unassigned lavalamp May 27, 2016
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 1cb0888 into kubernetes:master May 27, 2016
@derekwaynecarr
Copy link
Member

🍻

@lavalamp lavalamp mentioned this pull request May 28, 2016
Closed
@lavalamp
Copy link
Member

Please see #26489-- this test wasn't about upgrades and it isn't tested elsewhere so far as I know, we can't just remove it.

@wojtek-t wojtek-t deleted the dont_run_mulitple_registries_prefix branch June 15, 2016 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smarterclayton smarterclayton

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@wojtek-t @k8s-bot @smarterclayton @ncdc @k8s-github-robot @derekwaynecarr @lavalamp @googlebot