Add 'kubectl set resources' #27206

JacobTanenbaum · 2016-06-10T22:17:36Z

Add "kubectl set resources" for easier updating container memory/cpu limits/requests (for pods or resources with pod templates).

Usage

kubectl set resources (-f FILENAME | TYPE NAME) ([--limits=LIMITS & --requests=REQUESTS])

Examples
Set a deployments nginx container cpu limits to "200m and memory to "512Mi"
kubectl set resources deployment nginx -c=nginx --limits=cpu=200m,memory=512Mi

Set the limit and requests for all containers in nginx
kubectl set resources deployment nginx --limits=cpu=200m,memory=512Mi --requests=cpu=100m,memory=256Mi

Print the result (in yaml format) of updating nginx container limits from a local, without hitting the server
kubectl set resources -f path/to/file.yaml --limits=cpu=200m,memory=512Mi --local -o yaml

Remove limits on containers in nginx
kubectl set resources deployment nginx --limits=cpu=0,memory=0

Ref: #21648

EDIT: removed the '--remove' flag example

This change is

googlebot · 2016-06-10T22:17:37Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

pwittrock · 2016-06-11T01:43:49Z

@JacobTanenbaum I'll take a look at this next week. It won't get merged until after 1.3 freeze is over.

0xmichalis · 2016-06-11T12:13:46Z

@kubernetes/kubectl

derekwaynecarr · 2016-06-11T15:11:55Z

I like the feature.

How about 'kubectl set resources' instead?

/cc @vishh

On Saturday, June 11, 2016, Michail Kargakis notifications@github.com
wrote:

@kubernetes/kubectl https://github.com/orgs/kubernetes/teams/kubectl

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#27206 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AF8dbBqwK6WYeuPE8FmyXl7GLPdweHv1ks5qKqaggaJpZM4IzYBd
.

smarterclayton · 2016-06-11T18:01:09Z

Yeah, to avoid having to have two commands (one for limits, one for resources).

smarterclayton · 2016-06-11T18:05:07Z

pkg/kubectl/cmd/set/set_limit.go

+	allErrs := []error{}
+	patches := CalculatePatches(o.Infos, o.Encoder, func(info *resource.Info) (bool, error) {
+		transformed := false
+		_, err := o.UpdatePodSpecForObject(info.Object, func(spec *api.PodSpec) error {


Other things may have resources besides pods (quota and limits). We should make an argument for or against whether this command should be polymorphic to type. The container selector is probably the main issue - we'd need a different selector for sub quota info.

googlebot · 2016-06-19T20:45:55Z

CLAs look good, thanks!

JacobTanenbaum · 2016-06-19T20:49:10Z

Does everyone like 'kubectl set resources'?

JacobTanenbaum · 2016-06-19T20:55:54Z

pkg/kubectl/cmd/set/set_limit.go

+			continue
+		}
+
+		//no changes


@smarterclayton I believe that I put the continue where you meant. If I understand correctly an empty patch is not an error so I added a note to stderr when a patch is empty that the resource was not changed

vishh · 2016-06-21T19:00:10Z

I prefer kubectl set resources as well.

eparis · 2016-10-13T13:10:34Z

hack/make-rules/test-cmd.sh

@@ -2211,6 +2242,7 @@ __EOF__
  kubectl delete deployment nginx-deployment "${kube_flags[@]}"


+


why add whitespace?

Whitespace removed

eparis · 2016-10-13T13:10:56Z

pkg/cloudprovider/providers/openstack/MAINTAINERS.md

@@ -4,3 +4,6 @@


 [![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/pkg/cloudprovider/providers/openstack/MAINTAINERS.md?pixel)]()
+
+
+[![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/_tmp/pkg/cloudprovider/providers/openstack/MAINTAINERS.md?pixel)]()


This is a bug of some sort... should not be here.

Removed entry

eparis · 2016-10-13T18:46:03Z

The unit/integration test failure can be reliably recreated doing make test-cmd

Apparently:

output_message=$(! kubectl get pod --context="" --kubeconfig=missing 2>&1)

is the failing line. Before this PR the command returned an error. After the PR the command does not return an error.

eparis · 2016-10-13T18:48:45Z

The command should fail and output_message should include missing: no such file or directory

instead it is passing and output_message is getting No resources found.

Add a way to set resource limits/requests on running pods Ref: kubernetes#21648 I squashed the commits to make rebasing easier Change log: - fixed a typo that caused the command to be run with kubectl set set instead of the correct kubectl set limit - added a ResourcesWithPodTemplates to pkg/kubectl/cmd/util/factory.go instead of hardcoding these resources move there description all in one place - Fixing some of the flow control in kubectl set limit - update the help info - changed the name of ResourcesWithPodTemplates to ResourcesWithPodSpecs to more accuratly describe what it is doing and changed the variable names to lower case to conform to go's variable naming convention - changing the name of the command from 'set limit' to 'set resources' - Adding the new file pkg/kubectl/cmd/set/set_resources.go - changes to the test cases to reflect the change from 'kubectl set limit' to 'kubectl set resources' - comment removed - adding the man page to the git repository attempting to fix Jenkins tests - adding the user guide - fixed a few typos - typo in hack/cmd-test.sh - implamenting suggestions for command help text - adding the dry-run flag - removing the "remove" option in favor of zeroing out request/limits in order to remove them - changed limits/requests to requests/limit - changing ResourcesWithPodSpec - updated generated docs and removed whitespace - change priint on success message from "resource limits/requests updated" to "resource requirements updated" - minor rebasing issues - 'hack/test-cmd.sh' now passes - cmdutil.PrintSuccess added another argument - fixing mungedocs failure - removed whitespace from hack/make-rules/test-cmd.sh and an erroneous entry from pkg/cloudprovider/providers/openstack/MAINTAINERS.md - fixed typo in Short: field of the cobra command - rebased - Creating a new factory in the ResourcesWithPodSpecs() so that the testing will pass - changing ResourcesWithPodSpecs, it doesn't need to be a method of factory

k8s-github-robot · 2016-10-15T00:14:16Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-ci-robot · 2016-10-15T00:35:02Z

Jenkins GKE smoke e2e failed for commit 901bbee. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

k8s-github-robot · 2016-10-15T00:55:34Z

Automatic merge from submit-queue

googlebot added the cla: no label Jun 10, 2016

k8s-github-robot assigned pwittrock Jun 10, 2016

k8s-github-robot added kind/old-docs size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 10, 2016

smarterclayton reviewed Jun 11, 2016
View reviewed changes

0xmichalis mentioned this pull request Jun 12, 2016

openshift ex registry and similar should enable easy updating openshift/origin#1175

Closed

pwittrock assigned janetkuo Jun 14, 2016

JacobTanenbaum force-pushed the add_limit branch from 333194d to 2efc82e Compare June 19, 2016 20:45

googlebot added cla: yes and removed cla: no labels Jun 19, 2016

k8s-github-robot removed the kind/old-docs label Jun 19, 2016

JacobTanenbaum reviewed Jun 19, 2016
View reviewed changes

k8s-github-robot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 22, 2016

derekwaynecarr added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2016

JacobTanenbaum force-pushed the add_limit branch from cea9096 to 9691082 Compare October 10, 2016 15:48

k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2016

derekwaynecarr added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2016

JacobTanenbaum force-pushed the add_limit branch from 9691082 to f11796b Compare October 13, 2016 13:05

k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2016

eparis added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2016

eparis reviewed Oct 13, 2016

View reviewed changes

JacobTanenbaum force-pushed the add_limit branch from f11796b to abd67fa Compare October 13, 2016 13:46

k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 13, 2016

JacobTanenbaum force-pushed the add_limit branch from abd67fa to d8c4a5c Compare October 13, 2016 17:31

JacobTanenbaum force-pushed the add_limit branch from d8c4a5c to ee27d2c Compare October 13, 2016 21:23

k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 13, 2016

k8s-github-robot mentioned this pull request Oct 13, 2016

[k8s.io] Deployment scaled rollout deployment should not block on annotation check {Kubernetes e2e suite} #34717

Closed

JacobTanenbaum force-pushed the add_limit branch 2 times, most recently from 7123dfa to 43e6e16 Compare October 14, 2016 02:46

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 14, 2016

JacobTanenbaum force-pushed the add_limit branch from 43e6e16 to 901bbee Compare October 14, 2016 12:36

k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 14, 2016

eparis added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2016

eparis added this to the v1.5 milestone Oct 14, 2016

k8s-github-robot merged commit e2ef58e into kubernetes:master Oct 15, 2016

knobunc mentioned this pull request Oct 17, 2016

adding 'oc set resources' openshift/origin#11384

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add 'kubectl set resources' #27206

Add 'kubectl set resources' #27206

JacobTanenbaum commented Jun 10, 2016 •

edited by vishh

Loading

googlebot commented Jun 10, 2016

pwittrock commented Jun 11, 2016

0xmichalis commented Jun 11, 2016

derekwaynecarr commented Jun 11, 2016

smarterclayton commented Jun 11, 2016 via email

smarterclayton Jun 11, 2016

googlebot commented Jun 19, 2016

JacobTanenbaum commented Jun 19, 2016

JacobTanenbaum Jun 19, 2016

vishh commented Jun 21, 2016

eparis Oct 13, 2016

JacobTanenbaum Oct 13, 2016

eparis Oct 13, 2016

JacobTanenbaum Oct 13, 2016

eparis commented Oct 13, 2016

eparis commented Oct 13, 2016

k8s-github-robot commented Oct 15, 2016

k8s-ci-robot commented Oct 15, 2016

k8s-github-robot commented Oct 15, 2016

		@@ -2211,6 +2242,7 @@ __EOF__
		kubectl delete deployment nginx-deployment "${kube_flags[@]}"

		@@ -4,3 +4,6 @@


		[![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/pkg/cloudprovider/providers/openstack/MAINTAINERS.md?pixel)]()


		[![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/_tmp/pkg/cloudprovider/providers/openstack/MAINTAINERS.md?pixel)]()

Add 'kubectl set resources' #27206

Add 'kubectl set resources' #27206

Conversation

JacobTanenbaum commented Jun 10, 2016 • edited by vishh Loading

googlebot commented Jun 10, 2016

pwittrock commented Jun 11, 2016

0xmichalis commented Jun 11, 2016

derekwaynecarr commented Jun 11, 2016

smarterclayton commented Jun 11, 2016 via email

smarterclayton Jun 11, 2016

Choose a reason for hiding this comment

googlebot commented Jun 19, 2016

JacobTanenbaum commented Jun 19, 2016

JacobTanenbaum Jun 19, 2016

Choose a reason for hiding this comment

vishh commented Jun 21, 2016

eparis Oct 13, 2016

Choose a reason for hiding this comment

JacobTanenbaum Oct 13, 2016

Choose a reason for hiding this comment

eparis Oct 13, 2016

Choose a reason for hiding this comment

JacobTanenbaum Oct 13, 2016

Choose a reason for hiding this comment

eparis commented Oct 13, 2016

eparis commented Oct 13, 2016

k8s-github-robot commented Oct 15, 2016

k8s-ci-robot commented Oct 15, 2016

k8s-github-robot commented Oct 15, 2016

JacobTanenbaum commented Jun 10, 2016 •

edited by vishh

Loading