Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Federation][init-06] Check for the availability of federation API server's service loadbalancer address before waiting. #35863

Merged
merged 1 commit into from
Nov 4, 2016
Merged

[Federation][init-06] Check for the availability of federation API server's service loadbalancer address before waiting. #35863

merged 1 commit into from
Nov 4, 2016

Conversation

madhusudancs
Copy link
Contributor

@madhusudancs madhusudancs commented Oct 30, 2016 •
edited by k8s-oncall
Loading

Please review only the last commit here. This is based on PR #35862 which will be reviewed independently.

Design Doc: PR #34484

cc @kubernetes/sig-cluster-federation @nikhiljindal

This change is Reviewable

@madhusudancs madhusudancs added area/cluster-federation release-note-none Denotes a PR that doesn't merit a release note. labels Oct 30, 2016
@madhusudancs madhusudancs added this to the v1.5 milestone Oct 30, 2016
@madhusudancs madhusudancs assigned ghost Oct 30, 2016
@madhusudancs madhusudancs mentioned this pull request Oct 30, 2016
Merged
@k8s-github-robot k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 30, 2016
ghost
ghost reviewed Oct 31, 2016
View reviewed changes
federation/pkg/kubefed/init/init.go
@@ -528,3 +528,13 @@ func printSuccess(cmdOut io.Writer, ips, hostnames []string) error {
return err
}

func pollImmediateInfinite(interval time.Duration, condition wait.ConditionFunc) error {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not put this in the wait library with PollInfinite?

ghost
ghost approved these changes Oct 31, 2016
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, then LGTM. Feel free to apply the label when done.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit 8c449cbbfe2a7489c6e7e41c7841f13d50259191. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE etcd3 e2e failed for commit 8c449cbbfe2a7489c6e7e41c7841f13d50259191. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GCE e2e failed for commit 8c449cbbfe2a7489c6e7e41c7841f13d50259191. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit 8c449cbbfe2a7489c6e7e41c7841f13d50259191. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE e2e failed for commit 8c449cbbfe2a7489c6e7e41c7841f13d50259191. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins Kubemark GCE e2e failed for commit 8c449cbbfe2a7489c6e7e41c7841f13d50259191. Full PR test history.

The magic incantation to run this job again is @k8s-bot kubemark e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE Node e2e failed for commit 8c449cbbfe2a7489c6e7e41c7841f13d50259191. Full PR test history.

The magic incantation to run this job again is @k8s-bot node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@madhusudancs
[Federation][init-06] Check for the availability of federation API se…
caef02c 
…rver's service loadbalancer address before waiting.

This speeds up the tests. Otherwise tests end up unnecessarily waiting for the
poll interval/duration which is 5 seconds right now.
@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit 8c449cbbfe2a7489c6e7e41c7841f13d50259191. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 4, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit caef02c. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@madhusudancs
Copy link
Contributor Author

@k8s-bot cvm gke e2e test this

@madhusudancs
Copy link
Contributor Author

@quinton-hoole addressed the comment and rebased the PR. Adding the LGTM label.

@madhusudancs madhusudancs added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2016
@k8s-github-robot k8s-github-robot merged commit caef02c into kubernetes:master Nov 4, 2016
@madhusudancs madhusudancs deleted the federation-kubefed-init-06 branch November 4, 2016 17:30
@madhusudancs madhusudancs mentioned this pull request Nov 17, 2016
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@madhusudancs @k8s-ci-robot @googlebot @k8s-github-robot