Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It should be fast and painless to deploy a Federation of Kubernetes clusters #97

Closed
6 of 22 tasks
ghost opened this issue Sep 30, 2016 · 25 comments
Closed
6 of 22 tasks

It should be fast and painless to deploy a Federation of Kubernetes clusters #97

ghost opened this issue Sep 30, 2016 · 25 comments
Assignees
@madhusudancs
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Milestone
v1.6

Comments

@ghost
Copy link

ghost commented Sep 30, 2016 •
edited by madhusudancs

Description

  • It should be easy to deploy a Federation control plane into one (or more) clusters using a single kubectl command
  • It should be easy to add a cluster to a Federation using a single kubectl command (including configuring credentials/secrets)
  • It should be easy to add a new cluster to a federation while creating the cluster using kubeadm
  • It should be easy to include a federation control plane when creating a new cluster using kubeadm

Progress Tracker

  • Before Alpha
    • Write and maintain draft quality doc
      • During development keep a doc up-to-date about the desired experience of the feature and how someone can try the feature in its current state. Think of it as the README of your new feature and a skeleton for the docs to be written before the Kubernetes release. Paste link to Google Doc: DOC-LINK
    • Design Approval
      • Design Proposal. This goes under docs/proposals. Doing a proposal as a PR allows line-by-line commenting from community, and creates the basis for later design documentation. Paste link to merged design proposal here: Simplified Federation Control Plane Deployment. kubernetes#34484 (Yet to be merged)
      • Decide which repo this feature's code will be checked into. Not everything needs to land in the core kubernetes repo. Core - kubernetes/kubernetes
      • [ ] Initial API review (if API). Maybe same PR as design doc. PR-NUMBER
        • Any code that changes an API (/pkg/apis/...)
        • cc @kubernetes/api
      • Identify shepherd (your SIG lead and/or kubernetes-pm@googlegroups.com will be able to help you). My Shepherd is: @quinton-hoole
        • A shepherd is an individual who will help acquaint you with the process of getting your feature into the repo, identify reviewers and provide feedback on the feature. They are not (necessarily) the code reviewer of the feature, or tech lead for the area.
        • The shepherd is not responsible for showing up to Kubernetes-PM meetings and/or communicating if the feature is on-track to make the release goals. That is still your responsibility.
      • Identify secondary/backup contact point. My Secondary Contact Point is: @allannaim (and/or GH Handle)
    • Write (code + tests + docs) then get them merged. ALL-PR-NUMBERS
  • Before Beta
    • Testing is sufficient for beta
    • User docs with tutorials: kubefed v1.6 update website#2899
      • Updated walkthrough / tutorial in the docs repo: kubernetes/kubernetes.github.io
      • cc @kubernetes/docs on docs PR
      • cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
    • Thorough API review
      • cc @kubernetes/api
  • Before Stable
    • docs/proposals/foo.md moved to docs/design/foo.md
      • cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
    • Soak, load testing
    • detailed user docs and examples
      • cc @kubernetes/docs
      • cc @kubernetes/feature-reviewers on this issue to get approval before checking this off

FEATURE_STATUS is used for feature tracking and to be updated by @kubernetes/feature-reviewers.
FEATURE_STATUS: IN_DEVELOPMENT

More advice:

Design

  • Once you get LGTM from a @kubernetes/feature-reviewers member, you can check this checkbox, and the reviewer will apply the "design-complete" label.

Coding

  • Use as many PRs as you need. Write tests in the same or different PRs, as is convenient for you.
  • As each PR is merged, add a comment to this issue referencing the PRs. Code goes in the http://github.com/kubernetes/kubernetes repository,
    and sometimes http://github.com/kubernetes/contrib, or other repos.
  • When you are done with the code, apply the "code-complete" label.
  • When the feature has user docs, please add a comment mentioning @kubernetes/feature-reviewers and they will
    check that the code matches the proposed feature and design, and that everything is done, and that there is adequate
    testing. They won't do detailed code review: that already happened when your PRs were reviewed.
    When that is done, you can check this box and the reviewer will apply the "code-complete" label.

Docs

  • Write user docs and get them merged in.
  • User docs go into http://github.com/kubernetes/kubernetes.github.io.
  • When the feature has user docs, please add a comment mentioning @kubernetes/docs.
  • When you get LGTM, you can check this checkbox, and the reviewer will apply the "docs-complete" label.
@ghost ghost added the sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. label Sep 30, 2016
@ghost ghost added this to the v1.5 milestone Sep 30, 2016
@ghost ghost assigned madhusudancs Sep 30, 2016
@ghost
Copy link
Author

ghost commented Sep 30, 2016

Assigned to @madhusudancs

@idvoretskyi
Copy link
Member

@quinton-hoole @kubernetes/sig-cluster-federation can you clarify the actual status of the feature?

@madhusudancs
Copy link
Contributor

@idvoretskyi The design doc is out for review - kubernetes/kubernetes#34484.

Two questions:

  1. How do you expect the status to be updated in the future?
  2. (Semi-related to the previous one) It looks like I can't edit the issue description here, while I can in the Kubernetes core repo. Why?

@idvoretskyi
Copy link
Member

@madhusudancs please, use the checkboxes in the issue description message to define the actual feature state.

@madhusudancs
Copy link
Contributor

@idvoretskyi I tried. But I couldn't check the boxes.

@madhusudancs
Copy link
Contributor

@idvoretskyi also, how about changing the replace.me lines?

@idvoretskyi
Copy link
Member

@madhusudancs can you update the feature request with the actual status? (as I can see, you should have enough permissions to do it)

@madhusudancs
Copy link
Contributor

Code PRs:
kubernetes/kubernetes#35153
kubernetes/kubernetes#35492
kubernetes/kubernetes#35493
kubernetes/kubernetes#35494
kubernetes/kubernetes#35495
kubernetes/kubernetes#35592
kubernetes/kubernetes#35593
kubernetes/kubernetes#35594
kubernetes/kubernetes#35856
kubernetes/kubernetes#35859
kubernetes/kubernetes#35860
kubernetes/kubernetes#35861
kubernetes/kubernetes#35862
kubernetes/kubernetes#35863
kubernetes/kubernetes#35864
kubernetes/kubernetes#35865
kubernetes/kubernetes#35866
kubernetes/kubernetes#35867
kubernetes/kubernetes#36045
kubernetes/kubernetes#36047
kubernetes/kubernetes#36048
kubernetes/kubernetes#36294

@madhusudancs
Copy link
Contributor

@idvoretskyi done.

@jaredbhatti
Copy link

Ping. Is there a docs PR for this?

@allannaim
Copy link

allannaim commented Nov 28, 2016 via email

@madhusudancs
Copy link
Contributor

@jaredbhatti not yet, but I am working on it. I will send it out for review ASAP.

@madhusudancs madhusudancs mentioned this issue Nov 30, 2016
Merged
@madhusudancs
Copy link
Contributor

cc @kubernetes/feature-reviewers because the issue template advises to. But I am not entirely sure for what I am ping. The docs PR is here - kubernetes/website#1822

@idvoretskyi
Copy link
Member

@kubernetes/docs @jaredbhatti FYI ^

@idvoretskyi
Copy link
Member

@quinton-hoole @madhusudancs can you confirm that this item targets beta in 1.6?

@idvoretskyi idvoretskyi modified the milestones: next-milestone, v1.5 Dec 13, 2016
@madhusudancs
Copy link
Contributor

madhusudancs commented Dec 14, 2016 •
edited

@idvoretskyi we are planning to take it to GA in v1.6. How do I indicate that? What labels should I add?

@idvoretskyi idvoretskyi modified the milestones: v1.6, next-milestone Dec 14, 2016
@idvoretskyi idvoretskyi added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed (deprecated) alpha-in-1.5 labels Dec 14, 2016
@idvoretskyi
Copy link
Member

@madhusudancs "stage/stable" is a rigth label (already updated).

@madhusudancs madhusudancs added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status labels Feb 13, 2017
@idvoretskyi
Copy link
Member

idvoretskyi commented Mar 6, 2017 •
edited

@madhusudancs please, provide us with the release notes and documentation PR or link at the features spreadsheet.

Also, please, select the valid checkpoints at the Progress Tracker.

@jaredbhatti
Copy link

Pingity ping. Is there a Docs PR for this? Is one needed?

@madhusudancs
Copy link
Contributor

@jaredbhatti this needs a doc update. There is no PR yet. I am working on it as we speak. I will update this issue as soon as I send out a PR.

@jaredbhatti
Copy link

jaredbhatti commented Mar 17, 2017 via email

@madhusudancs
Copy link
Contributor

cc @kubernetes/feature-reviewers for docs approval.

@jaredbhatti Docs PR here - kubernetes/website#2899

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 22, 2017
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 21, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

ingvagabund pushed a commit to ingvagabund/enhancements that referenced this issue Apr 2, 2020
@openshift-merge-robot
Merge pull request kubernetes#97 from yuqi-zhang/ignition-spec-3
b5d54fc 
enhancement: add ignition dual spec 2/3 support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madhusudancs madhusudancs

Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
None yet
Milestone
v1.6
Development

No branches or pull requests
6 participants
@madhusudancs @idvoretskyi @allannaim @jaredbhatti @k8s-ci-robot @fejta-bot