Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Federation][init-08] Refactor the tests by pulling the common utilities into a testing package. #35865

Merged
merged 3 commits into from
Nov 4, 2016
Merged

[Federation][init-08] Refactor the tests by pulling the common utilities into a testing package. #35865

merged 3 commits into from
Nov 4, 2016

Conversation

madhusudancs
Copy link
Contributor

@madhusudancs madhusudancs commented Oct 30, 2016 •
edited by k8s-oncall
Loading

Please review only the last commit here. This is based on PR #35864 which will be reviewed independently.

Design Doc: PR #34484

cc @kubernetes/sig-cluster-federation @nikhiljindal

This change is Reviewable

@madhusudancs madhusudancs added area/cluster-federation release-note-none Denotes a PR that doesn't merit a release note. labels Oct 30, 2016
@madhusudancs madhusudancs added this to the v1.5 milestone Oct 30, 2016
@madhusudancs madhusudancs assigned ghost Oct 30, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit 5accac6. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit 5accac6. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins Kubemark GCE e2e failed for commit 5accac6. Full PR test history.

The magic incantation to run this job again is @k8s-bot kubemark e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE e2e failed for commit 5accac6. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@madhusudancs madhusudancs mentioned this pull request Oct 30, 2016
Merged
@k8s-github-robot k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 30, 2016
@ghost
Copy link

ghost commented Oct 31, 2016

I didn't review the code in detail (as that is done in a separate PR). But moving it to a library makes perfect sense. LGTM.

@ghost ghost added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2016
@madhusudancs
[Federation][init-06] Check for the availability of federation API se…
caef02c 
…rver's service loadbalancer address before waiting.

This speeds up the tests. Otherwise tests end up unnecessarily waiting for the
poll interval/duration which is 5 seconds right now.
@madhusudancs
[Federation][init-07] Pull the default federation namespace into a co…
dd365b4 
…nstant.
@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 4, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit 72109a9a1ab6bb4ab4af806a8e3540feb3b56e1b. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@madhusudancs
[Federation][init-08] Refactor the tests by pulling the common utilit…
efea270 
…ies into a testing package.

This makes these utilities reusable by other packages.
@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit 87a21223a33626757a6b32703436f49dfb4d7df7. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE etcd3 e2e failed for commit 72109a9a1ab6bb4ab4af806a8e3540feb3b56e1b. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@madhusudancs
Copy link
Contributor Author

Just rebased the PR and fixed the failing tests/builds. Adding the LGTM label back.

@madhusudancs madhusudancs added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GCE Node e2e failed for commit 72109a9a1ab6bb4ab4af806a8e3540feb3b56e1b. Full PR test history.

The magic incantation to run this job again is @k8s-bot node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GCE e2e failed for commit efea270. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit f64253a into kubernetes:master Nov 4, 2016
k8s-github-robot pushed a commit that referenced this pull request Nov 4, 2016
Merge pull request #35866 from madhusudancs/federation-kubefed-init-f…
9531442 
…akeclient

Automatic merge from submit-queue

Make the fake command factory return the clientset with appropriate rest clients for all the API groups.

Please review only the last commit here. This is based on PR #35865 which will be reviewed independently.

Design Doc: PR #34484

cc @kubernetes/sig-cluster-federation @nikhiljindal
@madhusudancs madhusudancs deleted the federation-kubefed-init-08 branch November 4, 2016 17:30
@madhusudancs madhusudancs mentioned this pull request Nov 17, 2016
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@madhusudancs @k8s-ci-robot @k8s-github-robot @googlebot