Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Federation][init-10a] Make the federation API server and controller manager image names configurable. #36045

Merged
merged 2 commits into from
Nov 7, 2016
Merged

[Federation][init-10a] Make the federation API server and controller manager image names configurable. #36045

merged 2 commits into from
Nov 7, 2016

Conversation

madhusudancs
Copy link
Contributor

@madhusudancs madhusudancs commented Nov 2, 2016 •
edited by k8s-oncall
Loading

This enables testing non-release images.

Please review only the last commit here. This is based on PR #35959 which will be reviewed independently.

Design Doc: PR #34484

cc @kubernetes/sig-cluster-federation @nikhiljindal

This change is Reviewable

@madhusudancs madhusudancs added area/cluster-federation release-note-none Denotes a PR that doesn't merit a release note. labels Nov 2, 2016
@madhusudancs madhusudancs added this to the v1.5 milestone Nov 2, 2016
@madhusudancs madhusudancs assigned ghost Nov 2, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit 573a454989950423804700313ec938b0fc7310db. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE e2e failed for commit 573a454989950423804700313ec938b0fc7310db. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit 573a454989950423804700313ec938b0fc7310db. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins Kubemark GCE e2e failed for commit 573a454989950423804700313ec938b0fc7310db. Full PR test history.

The magic incantation to run this job again is @k8s-bot kubemark e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE etcd3 e2e failed for commit 573a454989950423804700313ec938b0fc7310db. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit 573a454989950423804700313ec938b0fc7310db. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE Node e2e failed for commit 573a454989950423804700313ec938b0fc7310db. Full PR test history.

The magic incantation to run this job again is @k8s-bot node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GCE e2e failed for commit 573a454989950423804700313ec938b0fc7310db. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@madhusudancs madhusudancs mentioned this pull request Nov 2, 2016
Merged
@k8s-github-robot k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 2, 2016
@k8s-github-robot k8s-github-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 4, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit ea75e0f. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@ghost
Copy link

ghost commented Nov 4, 2016

Thanks @madhusudancs. Only nits, then LGTM. Feel free to apply the label once addressed to your satisfaction.

@madhusudancs
Copy link
Contributor Author

@quinton-hoole I don't see the comments (nits). It is not published?

@madhusudancs
[Federation][init-10a] Make the federation API server and controller …
8d8eca5 
…manager image names configurable.

This enables testing non-release images.
@k8s-github-robot k8s-github-robot merged commit 8d8eca5 into kubernetes:master Nov 7, 2016
ghost
ghost reviewed Nov 7, 2016
View reviewed changes
federation/pkg/kubefed/init/init.go
util.AddSubcommandFlags(cmd)
cmd.Flags().String("dns-zone-name", "", "DNS suffix for this federation. Federated Service DNS names are published with this suffix.")
cmd.Flags().String("image", defaultImage, "Image to use for federation API server and controller manager binaries.")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Add an example to illustrate a valid value.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@quinton-hoole defaultImage is printed in the help text. I think that illustrates a valid value. If I were to add an example, I would just repeat that.

federation/pkg/kubefed/init/init.go
@@ -109,8 +110,11 @@ func NewCmdInit(cmdOut io.Writer, config util.AdminConfig) *cobra.Command {
},
}

defaultImage := fmt.Sprintf("%s:%s", hyperkubeImageName, version.Get())
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: So we default to the explicit version of this build/release? Should we not default to the latest version rather?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@quinton-hoole Yeah, that's the most ideal default behavior. But there is no good/stable way to automatically detect the latest version right now. There is no API or anything as such to determine the latest version on the client machines and no technique is future proof. Given that, I think this is a reasonable default.

@ghost
Copy link

ghost commented Nov 7, 2016

@madhusudancs Yes, sorry, I forgot to press the "publish" button :-(

@madhusudancs madhusudancs deleted the federation-kubefed-init-10a branch November 16, 2016 02:08
@madhusudancs madhusudancs mentioned this pull request Nov 17, 2016
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@madhusudancs @k8s-ci-robot @googlebot @k8s-github-robot