Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Federation][init-10c] Fix hyperkube binary path in the image and disable auth mechanisms we don't support for now. #36048

Merged
merged 4 commits into from
Nov 7, 2016
Merged

[Federation][init-10c] Fix hyperkube binary path in the image and disable auth mechanisms we don't support for now. #36048

merged 4 commits into from
Nov 7, 2016

Conversation

madhusudancs
Copy link
Contributor

@madhusudancs madhusudancs commented Nov 2, 2016 •
edited
Loading

Please review only the last commit here. This is based on PR #36047 which will be reviewed independently.

Design Doc: PR #34484

cc @kubernetes/sig-cluster-federation @nikhiljindal

This change is Reviewable

@madhusudancs madhusudancs added area/cluster-federation release-note-none Denotes a PR that doesn't merit a release note. labels Nov 2, 2016
@madhusudancs madhusudancs added this to the v1.5 milestone Nov 2, 2016
@madhusudancs madhusudancs assigned ghost Nov 2, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit 7e5027aa5d9ffdfe65f1e74fe4ce788c454e52cc. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins Kubemark GCE e2e failed for commit 7e5027aa5d9ffdfe65f1e74fe4ce788c454e52cc. Full PR test history.

The magic incantation to run this job again is @k8s-bot kubemark e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE Node e2e failed for commit 7e5027aa5d9ffdfe65f1e74fe4ce788c454e52cc. Full PR test history.

The magic incantation to run this job again is @k8s-bot node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GCE e2e failed for commit 7e5027aa5d9ffdfe65f1e74fe4ce788c454e52cc. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit 7e5027aa5d9ffdfe65f1e74fe4ce788c454e52cc. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE e2e failed for commit 7e5027aa5d9ffdfe65f1e74fe4ce788c454e52cc. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE etcd3 e2e failed for commit 7e5027aa5d9ffdfe65f1e74fe4ce788c454e52cc. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@madhusudancs madhusudancs mentioned this pull request Nov 2, 2016
Closed
@k8s-github-robot k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 2, 2016
@k8s-github-robot k8s-github-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 4, 2016
@ghost
Copy link

ghost commented Nov 4, 2016

LGTM

@ghost ghost added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2016
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2016
@madhusudancs madhusudancs mentioned this pull request Nov 5, 2016
Merged
@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit 48853dd4660af52bb31b45a1a8238baa5688ad4f. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit e2890dba8035f9695de87fe71987ddae95a21b07. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@madhusudancs madhusudancs added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2016
@irfanurrehman irfanurrehman mentioned this pull request Nov 6, 2016
Merged
nikhiljindal
nikhiljindal reviewed Nov 6, 2016
View reviewed changes
federation/pkg/kubefed/init/init.go
@@ -389,8 +389,6 @@ func createAPIServer(clientset *client.Clientset, namespace, name, image, creden
"--etcd-servers=http://localhost:2379",
"--service-cluster-ip-range=10.0.0.0/16",
"--secure-port=443",
"--token-auth-file=/etc/federation/apiserver/known_tokens.csv",
"--basic-auth-file=/etc/federation/apiserver/basic_auth.csv",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do support basic auth. That is how I connect to federation apiserver on my browser. Did we break it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh sorry. We do not support these auth mechanisms in the new setup? That is fine for alpha. I assume you have plans to support it later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I have immediate plans to make this work. See the TODO at the top of this file. Also, the code for this is already written in my, now abandoned, PR - #30615 (aac3f0a). I just need to copy it over to this package.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 3c17fa5 into kubernetes:master Nov 7, 2016
k8s-github-robot pushed a commit that referenced this pull request Nov 15, 2016
Merge pull request #36294 from madhusudancs/federation-kubefed-init-10d
d51e27f 
Automatic merge from submit-queue

[Federation][init-10d] Use the right service names in controller manager.

Please review only the last commit here. This is based on PR #36048 which will be reviewed independently.

Design Doc: PR #34484

cc @kubernetes/sig-cluster-federation @nikhiljindal
@madhusudancs madhusudancs deleted the federation-kubefed-init-10c branch November 16, 2016 02:08
@madhusudancs madhusudancs mentioned this pull request Nov 17, 2016
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhiljindal nikhiljindal nikhiljindal left review comments

Assignees
No one assigned
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@madhusudancs @k8s-ci-robot @k8s-github-robot @nikhiljindal @googlebot