Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e: validates that InterPodAntiAffinity is respected if matching 2 #40534

Merged

Conversation

aveshagarwal
Copy link
Member

What this PR does / why we need it:
Fixed e2e: validates that InterPodAntiAffinity is respected if matching 2

• Failure [120.255 seconds]
[k8s.io] SchedulerPredicates [Serial]
/root/code/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/framework/framework.go:656
  validates that InterPodAntiAffinity is respected if matching 2 [It]
  /root/code/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/scheduler_predicates.go:561

  Not scheduled Pods: []v1.Pod(nil)
  Expected
      <int>: 0
  to equal
      <int>: 1

  /root/code/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/scheduler_predicates.go:933

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
#30142

Special notes for your reviewer:
xref: https://bugzilla.redhat.com/show_bug.cgi?id=1413748
While looking into the above bug, I found that the e2e was failing.

Release note:

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 26, 2017
@aveshagarwal
Copy link
Member Author

@kubernetes/sig-scheduling-bugs @kubernetes/rh-cluster-infra

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jan 26, 2017
@spxtr
Copy link
Contributor

spxtr commented Jan 26, 2017

@k8s-bot bazel test this
#40526

@timothysc timothysc added the sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. label Jan 26, 2017
@timothysc timothysc self-assigned this Jan 26, 2017
@timothysc timothysc self-requested a review January 26, 2017 21:26
@timothysc timothysc added this to the v1.6 milestone Jan 26, 2017
@timothysc timothysc added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jan 26, 2017
@timothysc
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2017
@timothysc
Copy link
Member

/approve

@timothysc timothysc added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. labels Jan 26, 2017
@timothysc timothysc added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

The following people have approved this PR: timothysc

Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc @smarterclayton
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 40046, 40073, 40547, 40534, 40249)

@k8s-github-robot k8s-github-robot merged commit 80aea34 into kubernetes:master Jan 27, 2017
@aveshagarwal aveshagarwal deleted the master-pod-anti-affinity-e2e branch March 9, 2017 17:36
@liggitt liggitt removed their assignment Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants