Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plumb subresource through subjectaccessreview #40935

Merged
merged 1 commit into from
Feb 4, 2017
Merged

Plumb subresource through subjectaccessreview #40935

merged 1 commit into from
Feb 4, 2017

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Feb 3, 2017 •
edited

plumb all fields for subjectaccessreview into the resulting authorizer.AttributesRecord

The SubjectAccessReview API passes subresource and resource name information to the authorizer to answer authorization queries.

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 3, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Feb 3, 2017
@liggitt liggitt added this to the v1.5 milestone Feb 3, 2017
@liggitt liggitt added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Feb 3, 2017
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 3, 2017
@deads2k
Copy link
Contributor

deads2k commented Feb 3, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2017
mikedanese
mikedanese reviewed Feb 3, 2017
View reviewed changes
pkg/registry/authorization/util/helpers_test.go Outdated
"testing"

"k8s.io/apiserver/pkg/authorization/authorizer"
"k8s.io/client-go/pkg/util/sets"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your goimports clipped this but it should be k8s.io/kuberentes/pkg/util/sets until we've moved that package into staging/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your goimports clipped this but it should be k8s.io/kuberentes/pkg/util/sets until we've moved that package into staging/

Already moved to apimachinery.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok then we should change this to k8s.io/apimachinery/pkg/util/sets

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok then we should change this to k8s.io/apimachinery/pkg/util/sets

I suspect this code doesn't build in master but does build for 1.5

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well we can always just use k8s.io/kuberentes/pkg/util/sets

Copy link
Member Author

@liggitt liggitt Feb 3, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, will tweak in the cherry-pick

@liggitt
Copy link
Member Author

liggitt commented Feb 3, 2017

added a rest test as well

@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 3, 2017
@liggitt liggitt mentioned this pull request Feb 3, 2017
Merged
@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 3, 2017
@liggitt
Copy link
Member Author

liggitt commented Feb 3, 2017

fixed a govet issue, retagging

@liggitt liggitt added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2017
@smarterclayton
Copy link
Contributor

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: liggitt, smarterclayton

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2017
@liggitt
Copy link
Member Author

liggitt commented Feb 3, 2017

weird github merge failure
@k8s-bot test this

@liggitt
Copy link
Member Author

liggitt commented Feb 4, 2017

@k8s-bot cross build test this

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

@liggitt: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins CRI GCE e2e 3a89d33 link @k8s-bot cri e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 67859ef into kubernetes:master Feb 4, 2017
@saad-ali saad-ali added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 7, 2017
k8s-github-robot pushed a commit that referenced this pull request Feb 10, 2017
Merge pull request #40940 from liggitt/automated-cherry-pick-of-#4093…
0c1029c 
…5-upstream-release-1.5

Automatic merge from submit-queue

Automated cherry pick of #40935

Cherry pick of #40935 on release-1.5.

#40935: Plumb subresource through subjectaccessreview
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.5" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@liggitt liggitt deleted the sar-subresource branch February 10, 2017 15:46
@liggitt liggitt mentioned this pull request Feb 27, 2017
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikedanese mikedanese mikedanese left review comments

@deads2k deads2k deads2k left review comments

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@liggitt @k8s-reviewable @deads2k @smarterclayton @k8s-github-robot @k8s-ci-robot @k8s-cherrypick-bot @mikedanese @saad-ali