Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable authorization.k8s.io API and update integration tests #13128

Merged
merged 2 commits into from
Mar 2, 2017
Merged

Enable authorization.k8s.io API and update integration tests #13128

merged 2 commits into from
Mar 2, 2017

Conversation

enj
Copy link
Contributor

@enj enj commented Feb 27, 2017 •
edited

Supersedes #13021

Integration tests are a bit hacky to avoid having to copy/paste all of them.

Things I have not figured out how to do:

  1. Impersonation tests
  2. Extra and Subresource not populated in kube SARs
  3. NonResourceAttributes not populated in kube SARs

xref issues:

Signed-off-by: Monis Khan mkhan@redhat.com

@enj
Copy link
Contributor Author

enj commented Feb 27, 2017

[test]

@liggitt
Copy link
Contributor

liggitt commented Feb 27, 2017

probably missing kubernetes/kubernetes#40935, part of the pick list for 1.5

@deads2k deads2k mentioned this pull request Feb 28, 2017
Closed
deads2k
deads2k reviewed Feb 28, 2017
View reviewed changes
pkg/cmd/server/kubernetes/master_config.go Outdated
@@ -196,7 +196,7 @@ func BuildDefaultAPIServer(options configapi.MasterConfig) (*apiserveroptions.Se
return server, storageFactory, nil
}

func BuildKubernetesMasterConfig(options configapi.MasterConfig, requestContextMapper kapi.RequestContextMapper, kubeClient kclientset.Interface, informers shared.InformerFactory, admissionControl admission.Interface, originAuthenticator authenticator.Request) (*MasterConfig, error) {
func BuildKubernetesMasterConfig(options configapi.MasterConfig, requestContextMapper kapi.RequestContextMapper, kubeClient kclientset.Interface, informers shared.InformerFactory, admissionControl admission.Interface, originAuthenticator authenticator.Request, kubeAuthorizer authorizer.Authorizer) (*MasterConfig, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a TODO to rethink this. Seven arguments is a bit much.

deads2k
deads2k reviewed Feb 28, 2017
View reviewed changes
pkg/cmd/server/start/start_master.go
@@ -357,8 +358,19 @@ func BuildKubernetesMasterConfig(openshiftConfig *origin.MasterConfig) (*kuberne
if openshiftConfig.Options.KubernetesMasterConfig == nil {
return nil, nil
}
kubeConfig, err := kubernetes.BuildKubernetesMasterConfig(openshiftConfig.Options, openshiftConfig.RequestContextMapper, openshiftConfig.KubeClientset(), openshiftConfig.Informers, openshiftConfig.KubeAdmissionControl, openshiftConfig.Authenticator)
return kubeConfig, err
kubeAuthorizer, err := adapter.NewAuthorizer(openshiftConfig.Authorizer)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Find the issue to collapse these. @soltysh did you have a pull that did that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recall anything like that. I think sttts has/had a todo for that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sttts any comments?

deads2k
deads2k reviewed Feb 28, 2017
View reviewed changes
test/cmd/authentication.sh Outdated
@@ -74,7 +74,7 @@ os::cmd::expect_success_and_text "curl -k -XPOST -H 'Content-Type: application/j
os::cmd::expect_success_and_text "oc policy can-i create pods --token='${accesstoken}' -n '${project}' --ignore-scopes" 'yes'
os::cmd::expect_success_and_text "oc policy can-i create pods --token='${accesstoken}' -n '${project}'" 'no'
os::cmd::expect_success_and_text "oc policy can-i create subjectaccessreviews --token='${accesstoken}' -n '${project}'" 'no'
os::cmd::expect_success_and_text "oc policy can-i create subjectaccessreviews --token='${accesstoken}' -n '${project}' --ignore-scopes" 'yes'
os::cmd::expect_success_and_text "oc policy can-i create subjectaccessreviews.v1. --token='${accesstoken}' -n '${project}' --ignore-scopes" 'yes'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not have needed tweaking. Why did it change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subjectaccessreviews without group info is ambiguous now since it could refer to either the kube or origin resource.

Copy link
Contributor

@liggitt liggitt Feb 28, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the resolution should treat the one without the group (the origin one) as an exact match and not fail. if it fails, we should fix that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subjectaccessreviews without group info is ambiguous now since it could refer to either the kube or origin resource.

Are you getting an error? It should be ambiguous with a preference.

Copy link
Contributor Author

@enj enj Feb 28, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some logging to debug better:

With subjectaccessreviews we get unversioned.GroupResource{Group:"", Resource:"subjectaccessreviews"} + .WithVersion("") + mapper.ResourceFor-> unversioned.GroupVersionResource{Group:"authorization.k8s.io", Version:"v1beta1", Resource:"subjectaccessreviews"}

With subjectaccessreviews.v1. we get unversioned.GroupVersionResource{Group:"", Version:"v1", Resource:"subjectaccessreviews"} directly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like the priority in the discovery doc is wrong.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mapper's priority seems OK:

kubectl.OutputVersionMapper {
    RESTMapper: util.ShortcutExpander {
        RESTMapper: meta.FirstHitRESTMapper {
            MultiRESTMapper: meta.MultiRESTMapper {
                ( * discovery.DeferredDiscoveryRESTMapper)(0xc420be2d80), meta.PriorityRESTMapper {
                    Delegate: meta.MultiRESTMapper {
                        ( * meta.DefaultRESTMapper)(0xc4201a3770), ( * meta.DefaultRESTMapper)(0xc420016410), ( * meta.DefaultRESTMapper)(0xc420016780), meta.MultiRESTMapper {
                            meta.MultiRESTMapper {
                                meta.MultiRESTMapper {
                                    meta.MultiRESTMapper {
                                        meta.MultiRESTMapper {
                                            meta.MultiRESTMapper {
                                                meta.MultiRESTMapper {
                                                    meta.MultiRESTMapper {
                                                        meta.MultiRESTMapper {
                                                            meta.MultiRESTMapper {
                                                                meta.MultiRESTMapper {
                                                                    meta.MultiRESTMapper {
                                                                        ( * meta.DefaultRESTMapper)(0xc4201a3450), ( * meta.DefaultRESTMapper)(0xc42021f770)
                                                                    }, ( * meta.DefaultRESTMapper)(0xc42021f860)
                                                                }, ( * meta.DefaultRESTMapper)(0xc42021f9f0)
                                                            }, ( * meta.DefaultRESTMapper)(0xc42021fc20)
                                                        }, ( * meta.DefaultRESTMapper)(0xc42021fc70)
                                                    }, ( * meta.DefaultRESTMapper)(0xc42021fcc0)
                                                }, ( * meta.DefaultRESTMapper)(0xc42021fd10)
                                            }, ( * meta.DefaultRESTMapper)(0xc42021fe00)
                                        }, ( * meta.DefaultRESTMapper)(0xc42021fe50)
                                    }, ( * meta.DefaultRESTMapper)(0xc42021fea0)
                                }, ( * meta.DefaultRESTMapper)(0xc42021fef0)
                            }, ( * meta.DefaultRESTMapper)(0xc42021ff40)
                        }, ( * meta.DefaultRESTMapper)(0xc4201a3d10), ( * meta.DefaultRESTMapper)(0xc420016320), ( * meta.DefaultRESTMapper)(0xc4201a3590), ( * meta.DefaultRESTMapper)(0xc4201a3e00), ( * meta.DefaultRESTMapper)(0xc4201a2b40), ( * meta.DefaultRESTMapper)(0xc4201a39a0), ( * meta.DefaultRESTMapper)(0xc4200164b0), ( * meta.DefaultRESTMapper)(0xc4200168c0), ( * meta.DefaultRESTMapper)(0xc4201a3630)
                    },
                    ResourcePriority: [] unversioned.GroupVersionResource {
                        unversioned.GroupVersionResource {
                            Group: "",
                            Version: "v1",
                            Resource: "*"
                        }, unversioned.GroupVersionResource {
                            Group: "extensions",
                            Version: "v1beta1",
                            Resource: "*"
                        }, unversioned.GroupVersionResource {
                            Group: "",
                            Version: "*",
                            Resource: "*"
                        }, unversioned.GroupVersionResource {
                            Group: "extensions",
                            Version: "*",
                            Resource: "*"
                        }, unversioned.GroupVersionResource {
                            Group: "metrics",
                            Version: "*",
                            Resource: "*"
                        }, unversioned.GroupVersionResource {
                            Group: "apps",
                            Version: "v1beta1",
                            Resource: "*"
                        }, unversioned.GroupVersionResource {
                            Group: "authentication.k8s.io",
                            Version: "v1beta1",
                            Resource: "*"
                        }, unversioned.GroupVersionResource {
                            Group: "authorization.k8s.io",
                            Version: "v1beta1",
                            Resource: "*"
                        }, unversioned.GroupVersionResource {
                            Group: "autoscaling",
                            Version: "v1",
                            Resource: "*"
                        }, unversioned.GroupVersionResource {
                            Group: "batch",
                            Version: "v1",
                            Resource: "*"
                        }, unversioned.GroupVersionResource {
                            Group: "certificates.k8s.io",
                            Version: "v1alpha1",
                            Resource: "*"
                        }, unversioned.GroupVersionResource {
                            Group: "componentconfig",
                            Version: "v1alpha1",
                            Resource: "*"
                        }, unversioned.GroupVersionResource {
                            Group: "federation",
                            Version: "v1beta1",
                            Resource: "*"
                        }, unversioned.GroupVersionResource {
                            Group: "policy",
                            Version: "v1beta1",
                            Resource: "*"
                        }, unversioned.GroupVersionResource {
                            Group: "rbac.authorization.k8s.io",
                            Version: "v1alpha1",
                            Resource: "*"
                        }, unversioned.GroupVersionResource {
                            Group: "storage.k8s.io",
                            Version: "v1beta1",
                            Resource: "*"
                        }, unversioned.GroupVersionResource {
                            Group: "apps",
                            Version: "*",
                            Resource: "*"
                        }, unversioned.GroupVersionResource {
                            Group: "authentication.k8s.io",
                            Version: "*",
                            Resource: "*"
                        }, unversioned.GroupVersionResource {
                            Group: "authorization.k8s.io",
                            Version: "*",
                            Resource: "*"
                        }, unversioned.GroupVersionResource {
                            Group: "autoscaling",
                            Version: "*",
                            Resource: "*"
                        }, unversioned.GroupVersionResource {
                            Group: "batch",
                            Version: "*",
                            Resource: "*"
                        }, unversioned.GroupVersionResource {
                            Group: "certificates.k8s.io",
                            Version: "*",
                            Resource: "*"
                        }, unversioned.GroupVersionResource {
                            Group: "componentconfig",
                            Version: "*",
                            Resource: "*"
                        }, unversioned.GroupVersionResource {
                            Group: "federation",
                            Version: "*",
                            Resource: "*"
                        }, unversioned.GroupVersionResource {
                            Group: "policy",
                            Version: "*",
                            Resource: "*"
                        }, unversioned.GroupVersionResource {
                            Group: "rbac.authorization.k8s.io",
                            Version: "*",
                            Resource: "*"
                        }, unversioned.GroupVersionResource {
                            Group: "storage.k8s.io",
                            Version: "*",
                            Resource: "*"
                        }
                    },
                    KindPriority: [] unversioned.GroupVersionKind {
                        unversioned.GroupVersionKind {
                            Group: "",
                            Version: "v1",
                            Kind: "*"
                        }, unversioned.GroupVersionKind {
                            Group: "extensions",
                            Version: "v1beta1",
                            Kind: "*"
                        }, unversioned.GroupVersionKind {
                            Group: "",
                            Version: "*",
                            Kind: "*"
                        }, unversioned.GroupVersionKind {
                            Group: "extensions",
                            Version: "*",
                            Kind: "*"
                        }, unversioned.GroupVersionKind {
                            Group: "metrics",
                            Version: "*",
                            Kind: "*"
                        }, unversioned.GroupVersionKind {
                            Group: "apps",
                            Version: "v1beta1",
                            Kind: "*"
                        }, unversioned.GroupVersionKind {
                            Group: "authentication.k8s.io",
                            Version: "v1beta1",
                            Kind: "*"
                        }, unversioned.GroupVersionKind {
                            Group: "authorization.k8s.io",
                            Version: "v1beta1",
                            Kind: "*"
                        }, unversioned.GroupVersionKind {
                            Group: "autoscaling",
                            Version: "v1",
                            Kind: "*"
                        }, unversioned.GroupVersionKind {
                            Group: "batch",
                            Version: "v1",
                            Kind: "*"
                        }, unversioned.GroupVersionKind {
                            Group: "certificates.k8s.io",
                            Version: "v1alpha1",
                            Kind: "*"
                        }, unversioned.GroupVersionKind {
                            Group: "componentconfig",
                            Version: "v1alpha1",
                            Kind: "*"
                        }, unversioned.GroupVersionKind {
                            Group: "federation",
                            Version: "v1beta1",
                            Kind: "*"
                        }, unversioned.GroupVersionKind {
                            Group: "policy",
                            Version: "v1beta1",
                            Kind: "*"
                        }, unversioned.GroupVersionKind {
                            Group: "rbac.authorization.k8s.io",
                            Version: "v1alpha1",
                            Kind: "*"
                        }, unversioned.GroupVersionKind {
                            Group: "storage.k8s.io",
                            Version: "v1beta1",
                            Kind: "*"
                        }, unversioned.GroupVersionKind {
                            Group: "apps",
                            Version: "*",
                            Kind: "*"
                        }, unversioned.GroupVersionKind {
                            Group: "authentication.k8s.io",
                            Version: "*",
                            Kind: "*"
                        }, unversioned.GroupVersionKind {
                            Group: "authorization.k8s.io",
                            Version: "*",
                            Kind: "*"
                        }, unversioned.GroupVersionKind {
                            Group: "autoscaling",
                            Version: "*",
                            Kind: "*"
                        }, unversioned.GroupVersionKind {
                            Group: "batch",
                            Version: "*",
                            Kind: "*"
                        }, unversioned.GroupVersionKind {
                            Group: "certificates.k8s.io",
                            Version: "*",
                            Kind: "*"
                        }, unversioned.GroupVersionKind {
                            Group: "componentconfig",
                            Version: "*",
                            Kind: "*"
                        }, unversioned.GroupVersionKind {
                            Group: "federation",
                            Version: "*",
                            Kind: "*"
                        }, unversioned.GroupVersionKind {
                            Group: "policy",
                            Version: "*",
                            Kind: "*"
                        }, unversioned.GroupVersionKind {
                            Group: "rbac.authorization.k8s.io",
                            Version: "*",
                            Kind: "*"
                        }, unversioned.GroupVersionKind {
                            Group: "storage.k8s.io",
                            Version: "*",
                            Kind: "*"
                        }
                    }
                }
            }
        },
        All: [] unversioned.GroupResource {
            unversioned.GroupResource {
                Group: "",
                Resource: "buildconfigs"
            }, unversioned.GroupResource {
                Group: "",
                Resource: "builds"
            }, unversioned.GroupResource {
                Group: "",
                Resource: "imagestreams"
            }, unversioned.GroupResource {
                Group: "",
                Resource: "deploymentconfigs"
            }, unversioned.GroupResource {
                Group: "extensions",
                Resource: "deployments"
            }, unversioned.GroupResource {
                Group: "autoscaling",
                Resource: "horizontalpodautoscalers"
            }, unversioned.GroupResource {
                Group: "",
                Resource: "replicationcontrollers"
            }, unversioned.GroupResource {
                Group: "",
                Resource: "routes"
            }, unversioned.GroupResource {
                Group: "",
                Resource: "services"
            }, unversioned.GroupResource {
                Group: "apps",
                Resource: "statefulsets"
            }, unversioned.GroupResource {
                Group: "extensions",
                Resource: "jobs"
            }, unversioned.GroupResource {
                Group: "extensions",
                Resource: "replicasets"
            }, unversioned.GroupResource {
                Group: "",
                Resource: "pods"
            }
        },
        discoveryClient: ( * util.CachedDiscoveryClient)(0xc420be65c0)
    },
    OutputVersions: [] unversioned.GroupVersion {
        unversioned.GroupVersion {
            Group: "",
            Version: "v1"
        }
    }
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest mapper making the choice doesn't seem to agree. It looks be doing an alpha sort.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, where did you get yours? The discovery restmappers is in discovery order.

deads2k
deads2k reviewed Feb 28, 2017
View reviewed changes
test/integration/authorization_test.go
}
}

if test.kubeAuthInterface != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would this ever be nil? Seems like I'd always want to do this check and rather than accidentally skip it, we should fail.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the kube clientset have a way to handle impersonation? We have tests that check SAR functionality while impersonating a different user. If we cannot test that with kube then I can explicitly whitelist those and make kubeAuthInterface required otherwise.

deads2k
deads2k reviewed Feb 28, 2017
View reviewed changes
test/integration/authorization_test.go Outdated
if test.kubeAuthInterface != nil {
var testNS string
if test.localReview != nil {
if len(test.localReview.Namespace) > 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there so many different signals?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically the original tests do not provide namespace info directly because it is either inferred or is part of the auth interface that is passed in. I wanted to avoid changing the old test data to prevent me from accidentally invalidating it.

deads2k
deads2k reviewed Feb 28, 2017
View reviewed changes
test/integration/authorization_test.go Outdated
if test.kubeAuthInterface != nil {
var testNS string
if test.localReview != nil {
if len(test.localReview.Namespace) > 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switch/case please.

deads2k
deads2k reviewed Feb 28, 2017
View reviewed changes
test/integration/authorization_test.go Outdated
failMessage = ""
return true, nil
})
func toKubeSelfSAR(testNS string, sar *authorizationapi.LocalSubjectAccessReview) *kubeauthorizationapi.SelfSubjectAccessReview {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these fully convertible to and from? I'll give this to you for now, but if they are convertible, you should write a real conversion and fuzz it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think they are fully convertible. Our SAR stuff defaults the namespace and user to the current if not given, kube requires it. Kube SAR also has NonResourceAttributes and Subresource which we do not seem to have. I am also not sure if kube's Extra and our Scopes can be round tripped without losing data.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think they are fully convertible. Our SAR stuff defaults the namespace and user to the current if not given, kube requires it. Kube SAR also has NonResourceAttributes and Subresource which we do not seem to have. I am also not sure if kube's Extra and our Scopes can be round tripped without losing data.

ok.

deads2k
deads2k reviewed Feb 28, 2017
View reviewed changes
test/integration/authorization_test.go Outdated
//Subresource :sar.Subreouse,?? TODO
Name: sar.ResourceName,
},
//NonResourceAttributes: &kubeauthorizationapi.NonResourceAttributes{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these commented out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I planned on simply removing it but I was not sure if the origin SAR stuff even handled NonResourceAttributes. While both ResourceAttributes and NonResourceAttributes cannot be specified together, the origin stuff does have a .Path so I feel like that should be used at some point.

deads2k
deads2k reviewed Feb 28, 2017
View reviewed changes
test/integration/authorization_test.go Outdated
Spec: kubeauthorizationapi.SubjectAccessReviewSpec{
User: sar.User,
Groups: sar.Groups.List(),
//Extra: scope?? TODO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scopes can be translated to extras. Issue.

deads2k
deads2k reviewed Feb 28, 2017
View reviewed changes
test/integration/authorization_test.go
clusterReview: askCanDannyGetProject,
kubeAuthInterface: dannySARGetter,
err: `User "danny" cannot create subjectaccessreviews at the cluster scope`,
kubeErr: `User "danny" cannot create authorization.k8s.io.subjectaccessreviews at the cluster scope`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue, that message looks backwards. I expected subjectaccessreviews.authorization.k8s.io.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The authorizer's messages put the group first (and none of its unit tests provide group info).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The authorizer's messages put the group first (and none of its unit tests provide group info).

Write an issue. It's a human readable message, so we should be able to change it.

deads2k
deads2k reviewed Feb 28, 2017
View reviewed changes
vendor/k8s.io/kubernetes/plugin/pkg/admission/namespace/lifecycle/admission.go Outdated
unversioned.GroupResource{Group: "", Resource: "localresourceaccessreviews"}: true,
unversioned.GroupResource{Group: "", Resource: "selfsubjectrulesreviews"}: true,
unversioned.GroupResource{Group: "", Resource: "subjectrulesreviews"}: true,
unversioned.GroupResource{Group: "authorization.k8s.io", Resource: "selfsubjectaccessreviews"}: true, // TODO import group name?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't import group name. This is correct.

@deads2k
Copy link
Contributor

deads2k commented Feb 28, 2017

Minor comments. You need a separate commit for your upstream patch. It should be an UPSTREAM: : remove post 1.7 rebase. Make the pick Jordan requested and this will be about ready.

@liggitt
Copy link
Contributor

liggitt commented Feb 28, 2017

pick is open at #13086

This was referenced Feb 28, 2017
Closed
Open
Closed
Closed
@enj enj force-pushed the enj/t/api_authorization.k8s.io branch from 53d4e5a to 083a442 Compare February 28, 2017 22:38
@enj
Copy link
Contributor Author

enj commented Feb 28, 2017

@deads2k comments addressed, issues opened, squashed, ready for merge if tests pass / you are good.

@enj
Enable authorization.k8s.io API and update integration tests
31d089a 
Signed-off-by: Monis Khan <mkhan@redhat.com>
@enj enj force-pushed the enj/t/api_authorization.k8s.io branch from 083a442 to b5fce7e Compare March 1, 2017 01:00
@deads2k
Copy link
Contributor

deads2k commented Mar 1, 2017

Waiting for #13085 .

Also, renamed your commit UPSTREAM: <drop>: xxx.

@enj
UPSTREAM: <drop>: admission namespace isAccessReview, remove post 1.7…
87fa28d 
… rebase

Signed-off-by: Monis Khan <mkhan@redhat.com>
@enj enj force-pushed the enj/t/api_authorization.k8s.io branch from b5fce7e to 87fa28d Compare March 1, 2017 15:00
@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 87fa28d

@deads2k
Copy link
Contributor

deads2k commented Mar 1, 2017

lgtm [merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/676/) (Base Commit: 1f33720)

@deads2k
Copy link
Contributor

deads2k commented Mar 2, 2017

re[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 87fa28d

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 2, 2017 •
edited

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/760/) (Base Commit: b6847b3) (Image: devenv-rhel7_6019)

@openshift-bot openshift-bot merged commit 8eafae6 into openshift:master Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh left review comments

@liggitt liggitt liggitt left review comments

@deads2k deads2k deads2k left review comments

Assignees

@liggitt liggitt

@deads2k deads2k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@enj @liggitt @deads2k @openshift-bot @soltysh