Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectl drain errors if pod is already deleted #47270

Merged
merged 1 commit into from Jun 10, 2017
Merged

kubectl drain errors if pod is already deleted #47270

merged 1 commit into from Jun 10, 2017

Conversation

derekwaynecarr
Copy link
Member

What this PR does / why we need it:
kubectl drain can throw an error if the pod it attempts to delete has already been deleted.

fixes kubernetes/kubectl#28

@derekwaynecarr derekwaynecarr added this to the v1.7 milestone Jun 9, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jun 9, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 9, 2017
@derekwaynecarr derekwaynecarr added kind/bug Categorizes issue or PR as related to a bug. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-label-needed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 9, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jun 9, 2017
@derekwaynecarr
Copy link
Member Author

@eparis @smarterclayton -- this is a fix for an issue we hit in our most recent upgrade. drain threw an error that multiple pods were already deleted.

@derekwaynecarr derekwaynecarr added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jun 9, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 9, 2017
@dims
Copy link
Member

dims commented Jun 10, 2017

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2017
@smarterclayton
Copy link
Contributor

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, dims, smarterclayton

Associated issue: 28

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 1168552 into kubernetes:master Jun 10, 2017
@derekwaynecarr derekwaynecarr mentioned this pull request Jun 15, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dims dims

@ghodss ghodss

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

kubectl drain errors if a pod has already been deleted
6 participants
@derekwaynecarr @dims @smarterclayton @k8s-github-robot @ghodss @k8s-ci-robot