Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add statefulset upgrade tests to cluster_upgrade #50397

Merged
merged 1 commit into from
Aug 24, 2017

Conversation

bdbauer
Copy link
Contributor

@bdbauer bdbauer commented Aug 9, 2017

What this PR does / why we need it:
Adds already created statefulset upgrade tests to cluster_upgrade.go. With further test infra changes, this will allow them to be continuously run, giving better signals.

Detect and prevent issues like #48327

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 9, 2017
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Aug 9, 2017
Copy link
Contributor

@krousey krousey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Name() method of all the upgrade tests should also have a sig tag to indicate ownership.

})
})

var _ = SIGDescribe("stateful Upgrade [Feature:StatefulUpgrade]", func() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to put "[sig-cluster-lifecycle]" in the name when I don't think we're going to own it. Can you use the standard describe and add an owning sig here?

framework.ExpectNoError(err)

testSuite := &junit.TestSuite{Name: "Stateful upgrade"}
statefulUpgradeTest := &junit.TestCase{Name: "stateful-upgrade", Classname: "upgrade_tests"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name needs a sig tag.

@pwittrock
Copy link
Member

/unassign @pwittrock

@pwittrock
Copy link
Member

/assign @foxish

@bdbauer
Copy link
Contributor Author

bdbauer commented Aug 16, 2017

/cc @mml

@k8s-ci-robot k8s-ci-robot requested a review from mml August 16, 2017 18:00
@bdbauer
Copy link
Contributor Author

bdbauer commented Aug 16, 2017

/cc @maisem

@foxish
Copy link
Contributor

foxish commented Aug 22, 2017

Thanks!

/lgtm
/approve

A test of this setup being correct and working would be to detect the upgrade issue between 1.6 and 1.7 tracked in #48327.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2017
@foxish
Copy link
Contributor

foxish commented Aug 22, 2017

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bdbauer, foxish

Associated issue: 48327

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2017
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 51113, 46597, 50397, 51052, 51166)

@k8s-github-robot k8s-github-robot merged commit 14cc8cd into kubernetes:master Aug 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants