-
Notifications
You must be signed in to change notification settings - Fork 39k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add statefulset upgrade tests to cluster_upgrade #50397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Name() method of all the upgrade tests should also have a sig tag to indicate ownership.
}) | ||
}) | ||
|
||
var _ = SIGDescribe("stateful Upgrade [Feature:StatefulUpgrade]", func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to put "[sig-cluster-lifecycle]" in the name when I don't think we're going to own it. Can you use the standard describe and add an owning sig here?
framework.ExpectNoError(err) | ||
|
||
testSuite := &junit.TestSuite{Name: "Stateful upgrade"} | ||
statefulUpgradeTest := &junit.TestCase{Name: "stateful-upgrade", Classname: "upgrade_tests"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name needs a sig tag.
/unassign @pwittrock |
/assign @foxish |
1324e60
to
ec39a47
Compare
/cc @mml |
/cc @maisem |
73ad80b
to
e58ca34
Compare
e58ca34
to
014b765
Compare
Thanks! /lgtm A test of this setup being correct and working would be to detect the upgrade issue between 1.6 and 1.7 tracked in #48327. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bdbauer, foxish Associated issue: 48327 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/retest Review the full test history for this PR. |
Automatic merge from submit-queue (batch tested with PRs 51113, 46597, 50397, 51052, 51166) |
What this PR does / why we need it:
Adds already created statefulset upgrade tests to cluster_upgrade.go. With further test infra changes, this will allow them to be continuously run, giving better signals.
Detect and prevent issues like #48327
Release note: