-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove ipv4 in pkg/util/ipvs #53120
remove ipv4 in pkg/util/ipvs #53120
Conversation
/assign @thockin |
66bdb33
to
71d3782
Compare
71d3782
to
93ebd29
Compare
93ebd29
to
30e1a3d
Compare
30e1a3d
to
101b569
Compare
101b569
to
074c846
Compare
@kubernetes/sig-network-bugs can someone with IPVS familiarity look at the changes to the test cases here? |
I just changed the UT from single test case(IPV4) to multiple test cases(IPV4 and IPV6).
I know the change seems large, but many changes are just indent. |
Ok, thanks /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: m1093782566, smarterclayton Associated issue: 51866 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all Tests are more than 96 hours old. Re-running tests. |
Automatic merge from submit-queue (batch tested with PRs 53227, 53120). If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it:
remove ipv4 in util/ipvs
Which issue this PR fixes:
xref: #51866
Special notes for your reviewer:
Release note: