Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ipv4 in pkg/util/ipvs #53120

Merged
merged 1 commit into from
Oct 5, 2017

Conversation

m1093782566
Copy link
Contributor

@m1093782566 m1093782566 commented Sep 27, 2017

What this PR does / why we need it:

remove ipv4 in util/ipvs

Which issue this PR fixes:

xref: #51866

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 27, 2017
@m1093782566
Copy link
Contributor Author

/assign @thockin

@m1093782566 m1093782566 changed the title remove ipv4 in util/ipvs/testing remove ipv4 in util/ipvs Sep 27, 2017
@m1093782566 m1093782566 changed the title remove ipv4 in util/ipvs remove ipv4 in pkg/util/ipvs Sep 27, 2017
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. area/ipv6 labels Sep 27, 2017
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 27, 2017
@k8s-github-robot k8s-github-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 27, 2017
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 27, 2017
@m1093782566 m1093782566 mentioned this pull request Sep 27, 2017
13 tasks
@smarterclayton
Copy link
Contributor

@kubernetes/sig-network-bugs can someone with IPVS familiarity look at the changes to the test cases here?

@m1093782566
Copy link
Contributor Author

m1093782566 commented Oct 5, 2017

@smarterclayton

I just changed the UT from single test case(IPV4) to multiple test cases(IPV4 and IPV6).

tests := {IPV4, IPV6}
for i := range tests {
  TestFOO(tests[i]) // Original test code
}

I know the change seems large, but many changes are just indent.

@smarterclayton
Copy link
Contributor

Ok, thanks

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: m1093782566, smarterclayton

Associated issue: 51866

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

/test all

Tests are more than 96 hours old. Re-running tests.

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 53227, 53120). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 3b1b19a into kubernetes:master Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ipv6 cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants