Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NONE in CHANGELOG-1.9 #53873

Closed
wants to merge 1 commit into from
Closed

Remove NONE in CHANGELOG-1.9 #53873

wants to merge 1 commit into from

Conversation

yuexiao-wang
Copy link
Contributor

@yuexiao-wang yuexiao-wang commented Oct 13, 2017 •
edited
Loading

Signed-off-by: yuexiao-wang wang.yuexiao@zte.com.cn

What this PR does / why we need it:
There should be not NONE in CHANGELOG and remove these NONE

Which issue this PR fixes : fixes #

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. retest-not-required-docs-only size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 13, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @yuexiao-wang. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 13, 2017
@yuexiao-wang
Copy link
Contributor Author

/assign @lavalamp

@xiangpengzhao
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 13, 2017
@yuexiao-wang
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-gpu

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 14, 2017
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 16, 2017
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 16, 2017
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 16, 2017
@yuexiao-wang
Copy link
Contributor Author

@verult @abgworrall PTAL

@yuexiao-wang
Copy link
Contributor Author

/cc @smarterclayton @lavalamp

@yuexiao-wang
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-bazel

@yuexiao-wang yuexiao-wang reopened this Oct 16, 2017
@yuexiao-wang yuexiao-wang changed the title Fix the NONE in changelog for v1.8.0-beta.1 Fix the NONE in changelog for v1.9 Oct 16, 2017
@yuexiao-wang
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-bazel

@yuexiao-wang
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-etcd3

@verult
Copy link
Contributor

verult commented Oct 16, 2017

My PR can be removed from the changelog as it only affects e2e tests.

@yuexiao-wang
Copy link
Contributor Author

I am waiting for the result from you. If need to remove the PR from CHANGELOG, I would like to do it

@xiangpengzhao
Copy link
Contributor

I think the three places you touch can be removed directly.
BTW, this PR don't need a release note :)
/release-note-none

@k8s-ci-robot
Copy link
Contributor

@xiangpengzhao: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none".

In response to this:

I think the three places you touch can be removed directly.
BTW, this PR don't need a release note :)
/release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xiangpengzhao
Copy link
Contributor

The bot doesn't allow me to label release-note-none. @yuexiao-wang can you modify the PR body?

@xiangpengzhao xiangpengzhao mentioned this pull request Oct 18, 2017
Merged
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 18, 2017
@yuexiao-wang yuexiao-wang changed the title Fix the NONE in changelog for v1.9 Remove NONE in CHANGELOG-1.9 Oct 18, 2017
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 18, 2017
@yuexiao-wang
Fix the NONE in changelog for CHANGELOG-1.9
d200bd0 
Signed-off-by: yuexiao-wang <wang.yuexiao@zte.com.cn>
@yuexiao-wang
Copy link
Contributor Author

/cc @lavalamp @smarterclayton

@xiangpengzhao
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xiangpengzhao, yuexiao-wang
We suggest the following additional approver: lavalamp

Assign the PR to them by writing /assign @lavalamp in a comment when ready.

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@yuexiao-wang
Copy link
Contributor Author

/assign @lavalamp

@yuexiao-wang
Copy link
Contributor Author

see #55302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp Awaiting requested review from lavalamp

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@lavalamp lavalamp

@smarterclayton smarterclayton

@xiangpengzhao xiangpengzhao

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@yuexiao-wang @k8s-ci-robot @xiangpengzhao @verult @k8s-github-robot @lavalamp @smarterclayton