Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promote PodNodeSelector admission controller annotations to stable #60284

Closed
wants to merge 2 commits into from

Conversation

colemickens
Copy link
Contributor

What this PR does / why we need it:

(Note: it intentionally drops support for the alpha configuration format due to some discussed potential concerns about incorrectly parsing legacy configuration in a way that leaves the cluster mistakenly open in some way. The format also was just undesirable due to effectively being a map with a special-cased key.)

Which issue(s) this PR fixes: Partially addresses #57424 (the other half, addressing PodTolerationRestriction will follow this PR).

Corresponding Docs PR: kubernetes/website#7134 (This will be updated again to discuss the versioned config, etc).

Release note:

* PodNodeSelector: `scheduler.alpha.kubernetes.io/node-selector` is deprecated in favor of `scheduler.kubernetes.io/node-selector`
* PodNodeSelector: support for alpha configuration format is removed. support for v1 configuration is added.

cc: @ericchiang @liggitt

deprecated: "scheduler.alpha.kubernetes.io/node-selector"
added: "scheduler.kubernetes.io/node-selector"
(drops support for unversioned alpha config)
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 23, 2018
@colemickens colemickens changed the title promote PodNodeSelector to v1 stable promote PodNodeSelector admission controller annotions stable Feb 23, 2018
@colemickens colemickens changed the title promote PodNodeSelector admission controller annotions stable promote PodNodeSelector admission controller annotations to stable Feb 23, 2018
@ericchiang
Copy link
Contributor

Flaking on #59426

/test pull-kubernetes-unit

@colemickens
Copy link
Contributor Author

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Feb 23, 2018
@lavalamp
Copy link
Member

lavalamp commented Mar 1, 2018

Stable features should not be using annotations like this, I think. Has this been debated?

@lavalamp
Copy link
Member

lavalamp commented Mar 1, 2018

Why is this api machinery?

@wanghaoran1988
Copy link
Contributor

/sig scheduling

@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Mar 2, 2018
@lavalamp lavalamp removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Mar 8, 2018
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 26, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 31, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 30, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@adampl
Copy link

adampl commented May 14, 2021

Hi, what about this issue? Has it been sorted out?

@pierluigilenoci
Copy link

@colemickens what happened to this PR?

@adampl
Copy link

adampl commented May 25, 2022

@colemickens reopen?

@adampl
Copy link

adampl commented May 31, 2022

@liggitt Please reopen if it makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants