-
Notifications
You must be signed in to change notification settings - Fork 39.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
promote PodNodeSelector admission controller annotations to stable #60284
Conversation
deprecated: "scheduler.alpha.kubernetes.io/node-selector" added: "scheduler.kubernetes.io/node-selector"
(drops support for unversioned alpha config)
Flaking on #59426 /test pull-kubernetes-unit |
/sig api-machinery |
Stable features should not be using annotations like this, I think. Has this been debated? |
Why is this api machinery? |
/sig scheduling |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Hi, what about this issue? Has it been sorted out? |
@colemickens what happened to this PR? |
@colemickens reopen? |
@liggitt Please reopen if it makes sense. |
What this PR does / why we need it:
PodNodeSelector
admission controller and annotations to stable, per discussion on PodNodeSelector and PodTolerationRestriction feature status is unclear #57424scheduler.alpha.kubernetes.io/node-selector
) but supports it simultaneously with the new annotation (scheduler.kubernetes.io/node-selector
), again per discussion on PodNodeSelector and PodTolerationRestriction feature status is unclear #57424(Note: it intentionally drops support for the alpha configuration format due to some discussed potential concerns about incorrectly parsing legacy configuration in a way that leaves the cluster mistakenly open in some way. The format also was just undesirable due to effectively being a map with a special-cased key.)
Which issue(s) this PR fixes: Partially addresses #57424 (the other half, addressing
PodTolerationRestriction
will follow this PR).Corresponding Docs PR: kubernetes/website#7134 (This will be updated again to discuss the versioned config, etc).
Release note:
cc: @ericchiang @liggitt