Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #62308 #62884

Closed
wants to merge 1 commit into from
Closed

Automated cherry pick of #62308 #62884

wants to merge 1 commit into from

Conversation

harsh-px
Copy link
Contributor

Cherry pick of #62308 on release-1.9.

#62308: Add support to resize Portworx volume

Add support to resize Portworx volume
03872a0 
Closes kubernetes#62305

Signed-off-by: Harsh Desai <harsh@portworx.com>

update comment and variable references to GiB

Signed-off-by: Harsh Desai <harsh@portworx.com>

explicitly check volume size after resize and fix size volume spec

Signed-off-by: Harsh Desai <harsh@portworx.com>

If Portworx volume is already greater than new size, skip resize

Signed-off-by: Harsh Desai <harsh@portworx.com>

Allow updated volume to be greater than requested size

Signed-off-by: Harsh Desai <harsh@portworx.com>
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 19, 2018
@k8s-github-robot
Copy link

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge/cherry-pick-not-approved label.

@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Apr 19, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: harsh-px
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers: derekwaynecarr, thockin

Assign the PR to them by writing /assign @derekwaynecarr @thockin in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 19, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 19, 2018
@harsh-px
Copy link
Contributor Author

/assign @derekwaynecarr

@mbohlool
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 10, 2018
@ixdy
Copy link
Member

ixdy commented May 10, 2018

/retest

@k8s-ci-robot
Copy link
Contributor

@harsh-px: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-device-plugin-gpu 03872a0 link /test pull-kubernetes-e2e-gce-device-plugin-gpu
pull-kubernetes-bazel-test 03872a0 link /test pull-kubernetes-bazel-test
pull-kubernetes-bazel-build 03872a0 link /test pull-kubernetes-bazel-build
pull-kubernetes-kubemark-e2e-gce 03872a0 link /test pull-kubernetes-kubemark-e2e-gce
pull-kubernetes-e2e-gce 03872a0 link /test pull-kubernetes-e2e-gce
pull-kubernetes-e2e-kops-aws 03872a0 link /test pull-kubernetes-e2e-kops-aws
pull-kubernetes-integration 03872a0 link /test pull-kubernetes-integration
pull-kubernetes-node-e2e 03872a0 link /test pull-kubernetes-node-e2e
pull-kubernetes-verify 03872a0 link /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mbohlool
Copy link
Contributor

/hold

This will not get into 1.9.8 patch release. Please contact me if you think it should be otherwise it will be included in next patch release.

(still has test failures)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2018
@mbohlool
Copy link
Contributor

@harsh-px tests are failing. Also PR needs approval and lgtm. Any updates?

@mbohlool
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2018
@mbohlool
Copy link
Contributor

closing this for no activities. Please re-open if you want this to be patched into 1.9

@mbohlool mbohlool closed this Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@verult verult Awaiting requested review from verult

Assignees

@derekwaynecarr derekwaynecarr

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@harsh-px @k8s-github-robot @k8s-ci-robot @mbohlool @ixdy @derekwaynecarr