Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Disable the public cadvisor port by default #63881
Disabling the publicly-available cAdvisor port is beneficial for security, as you might not want to expose the UI with lots of information about what your system is doing. We already did this for all kubeadm deployments in v1.7, and haven't recieved any issues for that. This should be okay to do at this stage, as this flag was deprecated in v1.10. Given we need to support this flag for one more release (v1.11), it makes perfect sense to instead switch it off in preparation for v1.12 when we can delete it (see the deprecation policy)
Which issue(s) this PR fixes (optional, in
Special notes for your reviewer:
I removed the e2e test that expects cAdvisor to be running, as we don't expect it to be anymore.
Will it have been depreciated for 6 months as of the 1.11 release? I don't think it has been 6 months since the 1.10 release at this point...
1 similar comment
@luxas: The following test failed, say