Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg: kubelet: remote: increase grpc client default size #63977

Merged
merged 1 commit into from
May 19, 2018
Merged

pkg: kubelet: remote: increase grpc client default size #63977

merged 1 commit into from
May 19, 2018

Conversation

runcom
Copy link
Contributor

@runcom runcom commented May 17, 2018 •
edited
Loading

Signed-off-by: Antonio Murdaca runcom@redhat.com

What this PR does / why we need it:

when running lots and lots of containers and having tons of images on a given node, we started seeing this in the logs (with docker):

Unable to retrieve pods: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (4208374 vs. 4194304)

That's because the grpc client is defaulting to a 4MB response size.
This patch increases the resp size to 8MB to avoid such issue.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

increase grpc client default response size

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 17, 2018
@runcom
Copy link
Contributor Author

runcom commented May 17, 2018

@sjenning @Random-Liu @feiskyer PTAL

@runcom
Copy link
Contributor Author

runcom commented May 17, 2018

@mrunalp PTAL as well

@runcom
pkg: kubelet: remote: increase grpc client default size
57a2eec 
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
@sjenning
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2018
@dims
Copy link
Member

dims commented May 17, 2018

@runcom also see discussion in #63858 i had a WIP PR too which i can abandon

resouer
resouer reviewed May 17, 2018
View reviewed changes
Copy link
Contributor

@resouer resouer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm Thanks!

@mrunalp
Copy link
Contributor

mrunalp commented May 17, 2018

/lgtm

@ceshihao
Copy link
Contributor

The same concern I commented in dims's PR #63894

I think it is OK as a temporary solution.
However, it can not resolve the problem finally if more and more message (size > 16M), and we have to increase it again.

Perhaps, it can have a final solution, like stream output message, result pagination or something else.

@derekwaynecarr
Copy link
Member

/test pull-kubernetes-kubemark-e2e-gce
/test pull-kubernetes-e2e-gce

@derekwaynecarr
Copy link
Member

/assign @derekwaynecarr

@derekwaynecarr
Copy link
Member

i am fine w/ this as a temporary solution.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, mrunalp, resouer, runcom, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2018
@sjenning sjenning mentioned this pull request May 18, 2018
Merged
@sjenning
Copy link
Contributor

flake #63427
/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 60012, 63692, 63977, 63960, 64008). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 4d786a9 into kubernetes:master May 19, 2018
@runcom runcom deleted the increase-grpc-resp-size branch May 19, 2018 09:46
feiskyer
feiskyer reviewed May 19, 2018
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dims dims mentioned this pull request May 19, 2018
Merged
k8s-github-robot pushed a commit that referenced this pull request May 21, 2018
Merge pull request #63894 from dims/bump-grpc-max-message-size-for-do…
bf790f4 
…cker-service

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Bump grpc max message size for docker service

**What this PR does / why we need it**:
When we have a lot of containers, we run into the limit in grpc ( https://github.com/grpc/grpc-go/blob/master/clientconn.go#L118 )

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #63858

**Special notes for your reviewer**:
In #63977 we fixed the send and receive sizes on the client side. we should fix the docker service too 

**Release note**:

```release-note
NONE
```
@mcluseau mcluseau mentioned this pull request Jun 6, 2018
Merged
k8s-github-robot pushed a commit that referenced this pull request Jun 13, 2018
Merge pull request #64804 from mcluseau/automated-cherry-pick-of-#63977-
d9823e4 
#64672-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #63977: pkg: kubelet: remote: increase grpc client default size #64672: pkg: kubelet: remote: increase grpc client default size to

Cherry pick of #63977 #64672 on release-1.10.

#63977: pkg: kubelet: remote: increase grpc client default size
#64672: pkg: kubelet: remote: increase grpc client default size to

```release-note
CRI: increase grpc client default size to 16MB
```
mysunshine92 referenced this pull request in mysunshine92/k8s-study Aug 12, 2018
@mysunshine92
Create kubelet_error
2ceca15
@rjhowe rjhowe mentioned this pull request Feb 18, 2019
Merged
@sjenning sjenning mentioned this pull request Feb 28, 2019
Closed
@dims dims mentioned this pull request Apr 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@resouer resouer resouer left review comments

@tallclair tallclair Awaiting requested review from tallclair

Assignees

@mrunalp mrunalp

@sjenning sjenning

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet