Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apiserver: do not print feature gates for glog v=0 #65584

Merged
merged 1 commit into from
Jun 28, 2018
Merged

apiserver: do not print feature gates for glog v=0 #65584

merged 1 commit into from
Jun 28, 2018

Conversation

neolit123
Copy link
Member

@neolit123 neolit123 commented Jun 28, 2018 •
edited by luxas
Loading

What this PR does / why we need it:
Demand verbosity level > 0 for glog Infof() calls when
setting feature gates in pkg/util/feature_gate.go.

Without this, regular calls to things like kubeadm token generate would also print feature_gate.go:230] feature gates: &{map[]}.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes kubernetes/kubeadm#953

Special notes for your reviewer:
i doubt there is a particular reason to not use verbosity level here?
is v=1 sufficient here?

/area apiserver
/area kubeadm
/kind cleanup
/cc @kubernetes/sig-cluster-lifecycle-pr-reviews
/cc @kubernetes/sig-api-machinery-pr-reviews

Release note:

bugfix: Do not print feature gates in the generic apiserver code for glog level 0

@neolit123
apiserver: do not print feature gates for glog v=0
ac5f5b4 
Demand verbosity level > 0 for glog Infof() calls when
setting feature gates in pkg/util/feature_gate.go.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. area/apiserver sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/kubeadm sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 28, 2018
@smarterclayton
Copy link
Contributor

/approve

@smarterclayton
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 28, 2018
@neolit123
Copy link
Member Author

/test pull-kubernetes-e2e-gce

luxas
luxas approved these changes Jun 28, 2018
View reviewed changes
Copy link
Member

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Let's get this into v1.11.1 as a bug fix. Okay by everybody else?
Thanks @neolit123!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: luxas, neolit123, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@luxas luxas added this to the v1.11 milestone Jun 28, 2018
@luxas luxas added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Jun 28, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Needs Approval

@luxas @neolit123 @smarterclayton @kubernetes/sig-api-machinery-misc @kubernetes/sig-cluster-lifecycle-misc

Action required: This pull request must have the status/approved-for-milestone label applied by a SIG maintainer.

Pull Request Labels
  • sig/api-machinery sig/cluster-lifecycle: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/cleanup: Adding tests, refactoring, fixing old bugs.
Help

@luxas
Copy link
Member

luxas commented Jun 28, 2018

(critical-urgent only because that's the only priority the bot allows for PRs in a milestone I think)

@neolit123
Copy link
Member Author

/test pull-kubernetes-e2e-gce

1 similar comment
@neolit123
Copy link
Member Author

/test pull-kubernetes-e2e-gce

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@fedebongio
Copy link
Contributor

/cc @cheftako

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit f0dcdd7 into kubernetes:master Jun 28, 2018
@luxas luxas mentioned this pull request Jun 29, 2018
Closed
9 tasks
@neolit123 neolit123 mentioned this pull request Jun 29, 2018
Merged
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 29, 2018
k8s-github-robot pushed a commit that referenced this pull request Jul 3, 2018
Merge pull request #65652 from neolit123/automated-cherry-pick-of-#65…
edc00ab 
…584-upstream-release-1.11

Automatic merge from submit-queue.

Automated cherry pick of #65584: apiserver: do not print feature gates for glog v=0

Cherry pick of #65584 on release-1.11.

#65584: apiserver: do not print feature gates for glog v=0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luxas luxas luxas approved these changes

@CaoShuFeng CaoShuFeng Awaiting requested review from CaoShuFeng

@sttts sttts Awaiting requested review from sttts

@cheftako cheftako Awaiting requested review from cheftako

Assignees

@smarterclayton smarterclayton

@luxas luxas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. milestone/needs-approval priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

Getting extra output 'feature_gate.go:230] feature gates: &{map[]}' when running kubeadm token create command.
6 participants
@neolit123 @smarterclayton @k8s-ci-robot @k8s-github-robot @luxas @fedebongio