fix azure storage account creation failure #65846

andyzhangx · 2018-07-05T06:45:46Z

What this PR does / why we need it:
fix azure storage account creation failure

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #65845

Special notes for your reviewer:
This bug is due to azure-sdk-for-go API change introduced in v1.11:
https://github.com/Azure/azure-sdk-for-go/blob/fbe7db0e3f9793ba3e5704efbab84f51436c136e/services/storage/mgmt/2017-10-01/storage/models.go#L381-L382

there is a new field Kind which is required, so any sdk upgrade from and old version would break the storage account creation since old code won't use Kind. I have filed an issue to azure-sdk-for-go: Azure/azure-sdk-for-go#2182

Release note:

fix azure storage account creation failure

/kind bug
/sig azure
/assign @khenidak @feiskyer
cc @brendandburns

karataliu · 2018-07-05T09:08:52Z

The document listed in code is for update. For creation, all 3 kinds are supported:
https://docs.microsoft.com/en-us/rest/api/storagerp/storageaccounts/create#kind

So according to the docs, If we're to make it StorageV2 in future, that'd be a decision we make, not limited by api. Can consider updating the comment in code.

andyzhangx · 2018-07-05T12:07:59Z

@karataliu original storage account is identical to StorageV1, and StorageV2 is recommended according to https://docs.microsoft.com/en-us/azure/storage/common/storage-account-options?toc=%2fazure%2fstorage%2fblobs%2ftoc.json, and BlobStorage is only for block blob, so let's switch to use StorageV2, paste some info here:

The three different storage account options are:
General-purpose v2 (GPv2) accounts
General-purpose v1 (GPv1) accounts
Blob storage accounts

General-purpose v2
General-purpose v2 (GPv2) accounts are storage accounts that support all of the latest features for blobs, files, queues, and tables. GPv2 accounts support all APIs and features supported in GPv1 and Blob storage accounts. They also support the same durability, availability, scalability, and performance features in those account types. Pricing for GPv2 accounts has been designed to deliver the lowest per gigabyte prices, and industry competitive transaction prices.

You can upgrade your GPv1 or Blob storage account to a GPv2 account using Azure portal, PowerShell, or Azure CLI.

andyzhangx · 2018-07-05T12:08:19Z

/test pull-kubernetes-e2e-kops-aws

andyzhangx · 2018-07-05T12:08:56Z

BTW, this is a critical bug, storage account creation is broken on v1.11 and master branch

feiskyer · 2018-07-05T13:42:54Z

pkg/cloudprovider/providers/azure/azure_storageaccount.go

@@ -113,6 +113,8 @@ func (az *Cloud) ensureStorageAccount(accountName, accountType, location, genAcc
 				accountName, az.ResourceGroup, location, accountType)
 			cp := storage.AccountCreateParameters{
 				Sku: &storage.Sku{Name: storage.SkuName(accountType)},
+				// set as StorageV2 according to https://docs.microsoft.com/en-us/rest/api/storagerp/StorageAccounts/Update


nit: Also add a comment: "Currently only StorageV2 supported" for updates?

hmm, this is only for create, so all 3 kinds are supported here. So it's better changing the link to https://docs.microsoft.com/en-us/azure/storage/common/storage-account-options and add a comment of why StorageV2 is chosen

This is exactly what i meant.
The comment should be 'StorageV2' is chosen by purpose, not limited by api.

fixed by new comment

feiskyer · 2018-07-05T13:44:42Z

/priority critical-urgent

ddebroy · 2018-07-05T22:16:39Z

Will it make sense to add an e2e case for dynamic provisioning of AzureFile backed volumes to catch such issues (resulting from upgrading azure SDK or due to some other reason) in the future?

fix comments

andyzhangx

@feiskyer @karataliu PTAL

andyzhangx · 2018-07-06T06:16:47Z

pkg/cloudprovider/providers/azure/azure_storageaccount.go

@@ -113,6 +113,8 @@ func (az *Cloud) ensureStorageAccount(accountName, accountType, location, genAcc
 				accountName, az.ResourceGroup, location, accountType)
 			cp := storage.AccountCreateParameters{
 				Sku: &storage.Sku{Name: storage.SkuName(accountType)},
+				// set as StorageV2 according to https://docs.microsoft.com/en-us/rest/api/storagerp/StorageAccounts/Update


fixed by new comment

andyzhangx · 2018-07-06T06:21:05Z

@ddebroy good question, I found this issue on Azure acs-engine regression test, while in upstream, there is no such plan to add Azure e2e test since cloud provider will be split to standalone repo in the near future.

karataliu · 2018-07-06T06:34:30Z

/lgtm

k8s-ci-robot · 2018-07-06T06:34:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, karataliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/cloudprovider/providers/azure/OWNERS~~ [andyzhangx,karataliu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

feiskyer · 2018-07-06T07:04:19Z

Will it make sense to add an e2e case for dynamic provisioning of AzureFile backed volumes to catch such issues (resulting from upgrading azure SDK or due to some other reason) in the future?

Azure related e2e tests are adding to https://github.com/kubernetes/cloud-provider-azure. @karataliu is working on that part.

k8s-github-robot · 2018-07-06T07:38:55Z

/test all [submit-queue is verifying that this PR is safe to merge]

andyzhangx · 2018-07-06T08:45:22Z

/test pull-kubernetes-e2e-gce-device-plugin-gpu
/test pull-kubernetes-bazel-test

k8s-github-robot · 2018-07-06T08:59:53Z

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

…5846-upstream-release-1.11 Automatic merge from submit-queue. Automated cherry pick of #65846: fix azure storage account creation failure Cherry pick of #65846 on release-1.11. #65846: fix azure storage account creation failure

k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 5, 2018

k8s-ci-robot assigned feiskyer and khenidak Jul 5, 2018

k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/azure labels Jul 5, 2018

k8s-ci-robot requested review from brendandburns and karataliu July 5, 2018 06:45

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 5, 2018

feiskyer reviewed Jul 5, 2018

View reviewed changes

k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Jul 5, 2018

fix azure storage account creation failure

b76a3a1

fix comments

andyzhangx force-pushed the azure-storage-account-fix branch from 8e41b09 to b76a3a1 Compare July 6, 2018 06:16

andyzhangx commented Jul 6, 2018

View reviewed changes

k8s-ci-robot assigned karataliu Jul 6, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2018

k8s-github-robot merged commit 6ca53a0 into kubernetes:master Jul 6, 2018

andyzhangx mentioned this pull request Jul 6, 2018

Automated cherry pick of #65846: fix azure storage account creation failure #65893

Merged

weherdh mentioned this pull request Aug 10, 2018

fix azure disk create failure due to sdk upgrade #67236

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix azure storage account creation failure #65846

fix azure storage account creation failure #65846

andyzhangx commented Jul 5, 2018

karataliu commented Jul 5, 2018 •

edited

Loading

andyzhangx commented Jul 5, 2018

andyzhangx commented Jul 5, 2018

andyzhangx commented Jul 5, 2018

feiskyer Jul 5, 2018 •

edited

Loading

feiskyer Jul 5, 2018

karataliu Jul 6, 2018

andyzhangx Jul 6, 2018

feiskyer commented Jul 5, 2018

ddebroy commented Jul 5, 2018

andyzhangx left a comment

andyzhangx Jul 6, 2018

andyzhangx commented Jul 6, 2018

karataliu commented Jul 6, 2018

k8s-ci-robot commented Jul 6, 2018

feiskyer commented Jul 6, 2018

k8s-github-robot commented Jul 6, 2018

andyzhangx commented Jul 6, 2018

k8s-github-robot commented Jul 6, 2018

fix azure storage account creation failure #65846

fix azure storage account creation failure #65846

Conversation

andyzhangx commented Jul 5, 2018

karataliu commented Jul 5, 2018 • edited Loading

andyzhangx commented Jul 5, 2018

andyzhangx commented Jul 5, 2018

andyzhangx commented Jul 5, 2018

feiskyer Jul 5, 2018 • edited Loading

Choose a reason for hiding this comment

feiskyer Jul 5, 2018

Choose a reason for hiding this comment

karataliu Jul 6, 2018

Choose a reason for hiding this comment

andyzhangx Jul 6, 2018

Choose a reason for hiding this comment

feiskyer commented Jul 5, 2018

ddebroy commented Jul 5, 2018

andyzhangx left a comment

Choose a reason for hiding this comment

andyzhangx Jul 6, 2018

Choose a reason for hiding this comment

andyzhangx commented Jul 6, 2018

karataliu commented Jul 6, 2018

k8s-ci-robot commented Jul 6, 2018

feiskyer commented Jul 6, 2018

k8s-github-robot commented Jul 6, 2018

andyzhangx commented Jul 6, 2018

k8s-github-robot commented Jul 6, 2018

karataliu commented Jul 5, 2018 •

edited

Loading

feiskyer Jul 5, 2018 •

edited

Loading